{"thread":{"id":"20233","subject":"git format-patch from date never set","startedAt":"2009-07-25T21:39:27Z","lastAt":"2009-07-26T00:06:11Z","messageCount":5,"participants":["Dan Savilonis","Alex Riesen","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"118792","messageId":"325c62f60907251439n6f3f661dhf0e76a74ce1eaec8@mail.gmail.com","threadId":"20233","inReplyTo":null,"subject":"git format-patch from date never set","fromName":"Dan Savilonis","fromEmail":"djs@n-cube.org","sentAt":"2009-07-25T21:39:27Z","receivedAt":"2009-07-25T21:39:27Z","isPatch":false,"sender":{"key":"djs@n-cube.org","avatar":null},"body":"git format-patch always sets the date in the From: line to the git\ndefault date, e.g.\n\n From b9ff0ba6f3e228e1a8b67a25bc7be6b1da5ed1f3 Mon Sep 17 00:00:00 2001\n\nThe command uses GIT_COMMITTER_DATE as the date, but this env variable\nis never set in cmd_format_patch(). Is this a bug or 'feature'?\n\n--\nDan\n"},{"id":"118793","messageId":"81b0412b0907251531u7566813fr10bdd70187e9aca6@mail.gmail.com","threadId":"20233","inReplyTo":"325c62f60907251439n6f3f661dhf0e76a74ce1eaec8@mail.gmail.com","subject":"Re: git format-patch from date never set","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2009-07-25T22:31:31Z","receivedAt":"2009-07-25T22:31:31Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On Sat, Jul 25, 2009 at 23:39, Dan Savilonis wrote:\n> git format-patch always sets the date in the From: line to the git\n> default date, e.g.\n>\n>    From b9ff0ba6f3e228e1a8b67a25bc7be6b1da5ed1f3 Mon Sep 17 00:00:00 2001\n>\n> The command uses GIT_COMMITTER_DATE as the date, but this env variable\n> is never set in cmd_format_patch(). Is this a bug or 'feature'?\n\nNeither. This is not a date, but a part of \"loosely defined\" mbox format.\n"},{"id":"118794","messageId":"325c62f60907251549o27ebc8f2gcd1d728adb662ffd@mail.gmail.com","threadId":"20233","inReplyTo":"81b0412b0907251531u7566813fr10bdd70187e9aca6@mail.gmail.com","subject":"Re: git format-patch from date never set","fromName":"Dan Savilonis","fromEmail":"djs@n-cube.org","sentAt":"2009-07-25T22:49:34Z","receivedAt":"2009-07-25T22:49:34Z","isPatch":false,"sender":{"key":"djs@n-cube.org","avatar":null},"body":"On Sat, Jul 25, 2009 at 6:31 PM, Alex Riesen wrote:\n> Neither. This is not a date, but a part of \"loosely defined\" mbox format.\n>\n\nIn the examples of mbox format I have found, the date in the From:\nline is generally the same as in the Date: line, albeit in a more\nambiguous format. Further, the the git code treats it as a date and\nattempts to set it. It remains at the default date only because\ngit_committer_info() is called without GIT_COMMITTER_DATE set.\n\nSo is the code misleading? Was it designed to just meet the minimal\nrequirement of having a date-like string to comform to the mbox\nformat? What's the disadvantage to using the real commit date?\n\n--\nDan\n"},{"id":"118802","messageId":"7v7hxwtlf7.fsf@alter.siamese.dyndns.org","threadId":"20233","inReplyTo":"325c62f60907251549o27ebc8f2gcd1d728adb662ffd@mail.gmail.com","subject":"Re: git format-patch from date never set","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-07-25T23:03:40Z","receivedAt":"2009-07-25T23:03:40Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Dan Savilonis writes:\n\n> On Sat, Jul 25, 2009 at 6:31 PM, Alex Riesen wrote:\n>> Neither. This is not a date, but a part of \"loosely defined\" mbox format.\n>>\n>\n> In the examples of mbox format I have found, the date in the From:\n> line is generally the same as in the Date: line, albeit in a more\n> ambiguous format. Further, the the git code treats it as a date and\n> attempts to set it. It remains at the default date only because\n> git_committer_info() is called without GIT_COMMITTER_DATE set.\n>\n> So is the code misleading? Was it designed to just meet the minimal\n> requirement of having a date-like string to comform to the mbox\n> format? What's the disadvantage to using the real commit date?\n\nHaving it as a fixed date-looking string was to help /etc/magic entry\npeople may want to invent to detect format-patch output.\n"},{"id":"118810","messageId":"325c62f60907251706i4d9bf656n8e094a22a8736924@mail.gmail.com","threadId":"20233","inReplyTo":"7v7hxwtlf7.fsf@alter.siamese.dyndns.org","subject":"Re: git format-patch from date never set","fromName":"Dan Savilonis","fromEmail":"djs@n-cube.org","sentAt":"2009-07-26T00:06:11Z","receivedAt":"2009-07-26T00:06:11Z","isPatch":false,"sender":{"key":"djs@n-cube.org","avatar":null},"body":"Okay, I can see that. I suppose I don't really have an argument in\nfavor of using the real date, other than aesthetics.\n\n--\nDan\n\nOn Sat, Jul 25, 2009 at 7:03 PM, Junio C Hamano wrote:\n> Dan Savilonis writes:\n>\n>> On Sat, Jul 25, 2009 at 6:31 PM, Alex Riesen wrote:\n>>> Neither. This is not a date, but a part of \"loosely defined\" mbox format.\n>>>\n>>\n>> In the examples of mbox format I have found, the date in the From:\n>> line is generally the same as in the Date: line, albeit in a more\n>> ambiguous format. Further, the the git code treats it as a date and\n>> attempts to set it. It remains at the default date only because\n>> git_committer_info() is called without GIT_COMMITTER_DATE set.\n>>\n>> So is the code misleading? Was it designed to just meet the minimal\n>> requirement of having a date-like string to comform to the mbox\n>> format? What's the disadvantage to using the real commit date?\n>\n> Having it as a fixed date-looking string was to help /etc/magic entry\n> people may want to invent to detect format-patch output.\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n>\n"}]}