{"thread":{"id":"20203","subject":"[PATCH 4] janitor: useless checks before free","startedAt":"2009-07-22T21:51:55Z","lastAt":"2009-07-22T21:51:55Z","messageCount":1,"participants":["Pierre Habouzit"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"118501","messageId":"20090722215154.GD13823@artemis.corp","threadId":"20203","inReplyTo":null,"subject":"[PATCH 4] janitor: useless checks before free","fromName":"Pierre Habouzit","fromEmail":"madcoder@debian.org","sentAt":"2009-07-22T21:51:55Z","receivedAt":"2009-07-22T21:51:55Z","isPatch":true,"sender":{"key":"madcoder@debian.org","avatar":"https://avatars.githubusercontent.com/u/44708?v=4"},"body":"Signed-off-by: Pierre Habouzit <madcoder@debian.org>\n---\n\n   On the same vein, a few simplifications wrt if (x) free(x)\n\n pack-revindex.c |    3 +--\n walker.c        |    2 +-\n 2 files changed, 2 insertions(+), 3 deletions(-)\n\ndiff --git a/pack-revindex.c b/pack-revindex.c\nindex 1de53c8..77a0465 100644\n--- a/pack-revindex.c\n+++ b/pack-revindex.c\n@@ -149,8 +149,7 @@ void discard_revindex(void)\n \tif (pack_revindex_hashsz) {\n \t\tint i;\n \t\tfor (i = 0; i < pack_revindex_hashsz; i++)\n-\t\t\tif (pack_revindex[i].revindex)\n-\t\t\t\tfree(pack_revindex[i].revindex);\n+\t\t\tfree(pack_revindex[i].revindex);\n \t\tfree(pack_revindex);\n \t\tpack_revindex_hashsz = 0;\n \t}\ndiff --git a/walker.c b/walker.c\nindex e57630e..11d9052 100644\n--- a/walker.c\n+++ b/walker.c\n@@ -245,7 +245,7 @@ void walker_targets_free(int targets, char **target, const char **write_ref)\n {\n \twhile (targets--) {\n \t\tfree(target[targets]);\n-\t\tif (write_ref && write_ref[targets])\n+\t\tif (write_ref)\n \t\t\tfree((char *) write_ref[targets]);\n \t}\n }\n-- \n1.6.4.rc1.193.g47c25d\n\n"}]}