{"thread":{"id":"20188","subject":"[PATCH] bash: gitk accepts common log-shortlog options","startedAt":"2009-07-21T22:20:02Z","lastAt":"2009-07-22T14:05:05Z","messageCount":3,"participants":["SZEDER Gábor","Thomas Rast"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"118433","messageId":"1248214802-2996-1-git-send-email-szeder@ira.uka.de","threadId":"20188","inReplyTo":null,"subject":"[PATCH] bash: gitk accepts common log-shortlog options","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2009-07-21T22:20:02Z","receivedAt":"2009-07-21T22:20:02Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"Commit a393777e (bash completion: refactor common log, shortlog and gitk\noptions, 2009-02-16) introduced a list of command line options that go\nwell with 'git log' and 'git shortlog' but not with gitk.  However,\nthese options are all 'git rev-list' options, and, therefore, are\naccepted by gitk, too.\n\nThis patch moves these options to the list of common options, making\nthem available for gitk option completion, too.  Since the list of\nlog-shortlog options becomes empty with this move, this patch deletes\nit.\n\nSigned-off-by: SZEDER Gábor <szeder@ira.uka.de>\n---\n contrib/completion/git-completion.bash |    9 ++-------\n 1 files changed, 2 insertions(+), 7 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex bc2d8b4..f0cd5e3 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1118,6 +1118,8 @@ __git_log_common_options=\"\n \t--max-count=\n \t--max-age= --since= --after=\n \t--min-age= --until= --before=\n+\t--author= --committer= --grep=\n+\t--all-match\n \"\n # Options that go well for log and gitk (not shortlog)\n __git_log_gitk_options=\"\n@@ -1125,11 +1127,6 @@ __git_log_gitk_options=\"\n \t--simplify-merges --simplify-by-decoration\n \t--left-right\n \"\n-# Options that go well for log and shortlog (not gitk)\n-__git_log_shortlog_options=\"\n-\t--author= --committer= --grep=\n-\t--all-match\n-\"\n \n __git_log_pretty_formats=\"oneline short medium full fuller email raw format:\"\n __git_log_date_formats=\"relative iso8601 rfc2822 short local default raw\"\n@@ -1162,7 +1159,6 @@ _git_log ()\n \t--*)\n \t\t__gitcomp \"\n \t\t\t$__git_log_common_options\n-\t\t\t$__git_log_shortlog_options\n \t\t\t$__git_log_gitk_options\n \t\t\t--root --topo-order --date-order --reverse\n \t\t\t--follow --full-diff\n@@ -1822,7 +1818,6 @@ _git_shortlog ()\n \t--*)\n \t\t__gitcomp \"\n \t\t\t$__git_log_common_options\n-\t\t\t$__git_log_shortlog_options\n \t\t\t--numbered --summary\n \t\t\t\"\n \t\treturn\n-- \n1.6.4.rc1.73.ga0daf\n"},{"id":"118434","messageId":"200907220036.42917.trast@student.ethz.ch","threadId":"20188","inReplyTo":"1248214802-2996-1-git-send-email-szeder@ira.uka.de","subject":"Re: [PATCH] bash: gitk accepts common log-shortlog options","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2009-07-21T22:36:36Z","receivedAt":"2009-07-21T22:36:36Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"SZEDER Gábor wrote:\n> Commit a393777e (bash completion: refactor common log, shortlog and gitk\n> options, 2009-02-16) introduced a list of command line options that go\n> well with 'git log' and 'git shortlog' but not with gitk.  However,\n> these options are all 'git rev-list' options, and, therefore, are\n> accepted by gitk, too.\n[...]\n> +\t--author= --committer= --grep=\n> +\t--all-match\n\nAt the time, I tried to skip options to gitk that disconnect history\nin places where it really is connected.  This applies to --author,\n--committer and --grep, which also have a GUI equivalent.  However,\n--all-match doesn't, and then the other three are also needed, so I\nguess this makes sense.\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"},{"id":"118461","messageId":"20090722140505.GQ3581@saturnine","threadId":"20188","inReplyTo":"200907220036.42917.trast@student.ethz.ch","subject":"Re: [PATCH] bash: gitk accepts common log-shortlog options","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2009-07-22T14:05:05Z","receivedAt":"2009-07-22T14:05:05Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"On Wed, Jul 22, 2009 at 12:36:36AM +0200, Thomas Rast wrote:\n> SZEDER Gábor wrote:\n> > Commit a393777e (bash completion: refactor common log, shortlog and gitk\n> > options, 2009-02-16) introduced a list of command line options that go\n> > well with 'git log' and 'git shortlog' but not with gitk.  However,\n> > these options are all 'git rev-list' options, and, therefore, are\n> > accepted by gitk, too.\n> [...]\n> > +\t--author= --committer= --grep=\n> > +\t--all-match\n> \n> At the time, I tried to skip options to gitk that disconnect history\n> in places where it really is connected.  This applies to --author,\n> --committer and --grep, which also have a GUI equivalent.  However,\n> --all-match doesn't, and then the other three are also needed, so I\n> guess this makes sense.\n\nI see.  I was not sure what you meant by \"go well\", but suspected\nthis.  However, the '--no-merges' option was already there earlier,\nand it also produces disconnected history.  I'm not sure how often\nthese options are used with gitk, but it just happened yesterday that\nI wanted to use 'gitk --author=<me> ...' to find one of my commits.\n\n\nBest,\nGábor\n"}]}