{"thread":{"id":"20154","subject":"instaweb does not start because of a small syntax error in .git/gitweb/httpd.conf","startedAt":"2009-07-18T15:08:19Z","lastAt":"2009-07-26T10:10:14Z","messageCount":3,"participants":["Bodo Schlecht","Sean Estabrooks","Eric Wong"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"118235","messageId":"4A61E563.7000401@superdigi.de","threadId":"20154","inReplyTo":null,"subject":"instaweb does not start because of a small syntax error in .git/gitweb/httpd.conf","fromName":"Bodo Schlecht","fromEmail":"schlecht@superdigi.de","sentAt":"2009-07-18T15:08:19Z","receivedAt":"2009-07-18T15:08:19Z","isPatch":false,"sender":{"key":"schlecht@superdigi.de","avatar":null},"body":"When I start instaweb with\n\n  git instaweb\n\nI get this error:\n\n  Syntax error on line 8 of /media/disk1part4/Eigene Dateien/superdigi/superdigientwicklung/.git/gitweb/httpd.conf:\n  TypesConfig takes one argument, the MIME types config file\n  Could not execute http daemon apache2 -f.\n\nLine 8 of /.git/gitweb/httpd.conf reads\n\n  TypesConfig /media/disk1part4/Eigene Dateien/superdigi/superdigientwicklung/.git/mime.types\n\nAs you see, there is a space in the path so it should be quotes:\n\n  TypesConfig \"/media/disk1part4/Eigene Dateien/superdigi/superdigientwicklung/.git/mime.types\"\n\nIn all other lines of http.conf the path is correctly in quotes:\n\n  ServerName \"git-instaweb\"\n  ServerRoot \"/media/disk1part4/Eigene Dateien/superdigi/superdigientwicklung/.git/gitweb\"\n  DocumentRoot \"/media/disk1part4/Eigene Dateien/superdigi/superdigientwicklung/.git/gitweb\"\n  PidFile \"/media/disk1part4/Eigene Dateien/superdigi/superdigientwicklung/.git/pid\"\n  Listen 127.0.0.1:4321\n  LoadModule mime_module  /usr/lib/apache2/modules/mod_mime.so\n  LoadModule dir_module  /usr/lib/apache2/modules/mod_dir.so\n  TypesConfig /media/disk1part4/Eigene Dateien/superdigi/superdigientwicklung/.git/mime.types\n  DirectoryIndex gitweb.cgi\n  LoadModule cgi_module /usr/lib/apache2/modules/mod_cgi.so\n  AddHandler cgi-script .cgi\n  <Location /gitweb.cgi>\n    Options +ExecCGI\n  </Location>\n"},{"id":"118238","messageId":"BLU0-SMTP74459FFFD6FF936D27AD4FAE1F0@phx.gbl","threadId":"20154","inReplyTo":"4A61E563.7000401@superdigi.de","subject":"[PATCH] Trivial path quoting fixes in git-instaweb","fromName":"Sean Estabrooks","fromEmail":"seanlkml@sympatico.ca","sentAt":"2009-07-18T16:45:44Z","receivedAt":"2009-07-18T16:45:44Z","isPatch":true,"sender":{"key":"seanlkml@sympatico.ca","avatar":"https://gravatar.com/avatar/f92923f54fc08c401fc59b71829d4b89e9b8087fbba45ff87c82e6a83aee02ae?d=mp&s=160"},"body":"\nBodo Schlecht noticed that Instaweb didn't propely quote all\npath instances in the Apache config file it generated.\n---\n git-instaweb.sh |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/git-instaweb.sh b/git-instaweb.sh\nindex 5f4419b..32f6496 100755\n--- a/git-instaweb.sh\n+++ b/git-instaweb.sh\n@@ -256,7 +256,7 @@ apache2_conf () {\n \tmkdir -p \"$GIT_DIR/gitweb/logs\"\n \tbind=\n \ttest x\"$local\" = xtrue && bind='127.0.0.1:'\n-\techo 'text/css css' > $fqgitdir/mime.types\n+\techo 'text/css css' > \"$fqgitdir/mime.types\"\n \tcat > \"$conf\" <<EOF\n ServerName \"git-instaweb\"\n ServerRoot \"$fqgitdir/gitweb\"\n@@ -272,7 +272,7 @@ EOF\n \t\tfi\n \tdone\n \tcat >> \"$conf\" <<EOF\n-TypesConfig $fqgitdir/mime.types\n+TypesConfig \"$fqgitdir/mime.types\"\n DirectoryIndex gitweb.cgi\n EOF\n \n-- \n1.6.3.3\n"},{"id":"118826","messageId":"20090726101014.GA27702@dcvr.yhbt.net","threadId":"20154","inReplyTo":"BLU0-SMTP74459FFFD6FF936D27AD4FAE1F0@phx.gbl","subject":"Re: [PATCH] Trivial path quoting fixes in git-instaweb","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2009-07-26T10:10:14Z","receivedAt":"2009-07-26T10:10:14Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Sean Estabrooks <seanlkml@sympatico.ca> wrote:\n> \n> Bodo Schlecht noticed that Instaweb didn't propely quote all\n> path instances in the Apache config file it generated.\n\nWorks for me here, thank you.\n\nAcked-by: Eric Wong <normalperson@yhbt.net>\n\n> ---\n>  git-instaweb.sh |    4 ++--\n>  1 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/git-instaweb.sh b/git-instaweb.sh\n> index 5f4419b..32f6496 100755\n> --- a/git-instaweb.sh\n> +++ b/git-instaweb.sh\n> @@ -256,7 +256,7 @@ apache2_conf () {\n>  \tmkdir -p \"$GIT_DIR/gitweb/logs\"\n>  \tbind=\n>  \ttest x\"$local\" = xtrue && bind='127.0.0.1:'\n> -\techo 'text/css css' > $fqgitdir/mime.types\n> +\techo 'text/css css' > \"$fqgitdir/mime.types\"\n>  \tcat > \"$conf\" <<EOF\n>  ServerName \"git-instaweb\"\n>  ServerRoot \"$fqgitdir/gitweb\"\n> @@ -272,7 +272,7 @@ EOF\n>  \t\tfi\n>  \tdone\n>  \tcat >> \"$conf\" <<EOF\n> -TypesConfig $fqgitdir/mime.types\n> +TypesConfig \"$fqgitdir/mime.types\"\n>  DirectoryIndex gitweb.cgi\n>  EOF\n>  \n> -- \n"}]}