{"thread":{"id":"20137","subject":"[PATCH 1/2] refs.c: release file descriptor on error return","startedAt":"2009-07-16T21:25:17Z","lastAt":"2009-07-16T21:25:19Z","messageCount":3,"participants":["Brandon Casey"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"118138","messageId":"W0GiRm9n1NEfjVB8xBotanSRY89hxjLPu3Wksn_EsZusMJjkHNIRf8JuQmUh43ny21xTKBn1Li8@cipher.nrlssc.navy.mil","threadId":"20137","inReplyTo":null,"subject":"[PATCH 0/2] Two miscellaneous patches found while debugging 'next'","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2009-07-16T21:25:17Z","receivedAt":"2009-07-16T21:25:17Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey <drafnel@gmail.com>\n\nNoticed these two issues while debugging a segfault on next.\nPatch for 'next' to follow.\n\n-brandon\n\n\nBrandon Casey (2):\n  refs.c: release file descriptor on error return\n  sha1_name.c: avoid unnecessary strbuf_release\n\n refs.c      |    4 +++-\n sha1_name.c |    2 --\n 2 files changed, 3 insertions(+), 3 deletions(-)\n"},{"id":"118137","messageId":"W0GiRm9n1NEfjVB8xBotapRpIoR0jr6qkttRpkkGMPpe-bfqtvLM7YBvkMsGo7-vheQxRPBUAEU@cipher.nrlssc.navy.mil","threadId":"20137","inReplyTo":"W0GiRm9n1NEfjVB8xBotanSRY89hxjLPu3Wksn_EsZusMJjkHNIRf8JuQmUh43ny21xTKBn1Li8@cipher.nrlssc.navy.mil","subject":"[PATCH 1/2] refs.c: release file descriptor on error return","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2009-07-16T21:25:18Z","receivedAt":"2009-07-16T21:25:18Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey <drafnel@gmail.com>\n\n\nSigned-off-by: Brandon Casey <drafnel@gmail.com>\n---\n refs.c |    4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/refs.c b/refs.c\nindex dffe395..e15880f 100644\n--- a/refs.c\n+++ b/refs.c\n@@ -1525,8 +1525,10 @@ int for_each_recent_reflog_ent(const char *ref, each_reflog_ent_fn fn, long ofs,\n \t\tif (fstat(fileno(logfp), &statbuf) ||\n \t\t    statbuf.st_size < ofs ||\n \t\t    fseek(logfp, -ofs, SEEK_END) ||\n-\t\t    fgets(buf, sizeof(buf), logfp))\n+\t\t    fgets(buf, sizeof(buf), logfp)) {\n+\t\t\tfclose(logfp);\n \t\t\treturn -1;\n+\t\t}\n \t}\n \n \twhile (fgets(buf, sizeof(buf), logfp)) {\n-- \n1.6.3.1.24.g152f4\n"},{"id":"118139","messageId":"W0GiRm9n1NEfjVB8xBotan7WQ5BVS-0Yy_3hikrJN4b57ORvs0sreBFZFVMQljOVkzTQg_oO16A@cipher.nrlssc.navy.mil","threadId":"20137","inReplyTo":"W0GiRm9n1NEfjVB8xBotapRpIoR0jr6qkttRpkkGMPpe-bfqtvLM7YBvkMsGo7-vheQxRPBUAEU@cipher.nrlssc.navy.mil","subject":"[PATCH 2/2] sha1_name.c: avoid unnecessary strbuf_release","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2009-07-16T21:25:19Z","receivedAt":"2009-07-16T21:25:19Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey <drafnel@gmail.com>\n\nWhen we fall back to a standard for_each_reflog_ent() after failing to find\nthe nth branch switch (or if we had a short reflog) with the call to\nfor_each_recent_reflog_ent(), we do not need to free the memory allocated\nfor our strbuf's since a strbuf_reset() will be performed in\ngrab_nth_branch_switch() before assigning to the entry.\n\nPlus, the strbuf_release() negates the non-zero hint we initially gave to\nstrbuf_init() just above these lines.\n\nSigned-off-by: Brandon Casey <drafnel@gmail.com>\n---\n sha1_name.c |    2 --\n 1 files changed, 0 insertions(+), 2 deletions(-)\n\ndiff --git a/sha1_name.c b/sha1_name.c\nindex 904bcd9..44bb62d 100644\n--- a/sha1_name.c\n+++ b/sha1_name.c\n@@ -777,8 +777,6 @@ int interpret_branch_name(const char *name, struct strbuf *buf)\n \tfor_each_recent_reflog_ent(\"HEAD\", grab_nth_branch_switch, 40960, &cb);\n \tif (cb.cnt < nth) {\n \t\tcb.cnt = 0;\n-\t\tfor (i = 0; i < nth; i++)\n-\t\t\tstrbuf_release(&cb.buf[i]);\n \t\tfor_each_reflog_ent(\"HEAD\", grab_nth_branch_switch, &cb);\n \t}\n \tif (cb.cnt < nth)\n-- \n1.6.3.1.24.g152f4\n"}]}