{"thread":{"id":"20132","subject":"[PATCH] Disable asciidoc 8.4.1+ semantics for `{plus}` and friends","startedAt":"2009-07-16T13:54:06Z","lastAt":"2009-07-25T16:56:45Z","messageCount":3,"participants":["Thomas Rast","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"118114","messageId":"8e1edb4fb24a009e8eee419df31d0ae17a63a866.1247752162.git.trast@student.ethz.ch","threadId":"20132","inReplyTo":null,"subject":"[PATCH] Disable asciidoc 8.4.1+ semantics for `{plus}` and friends","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2009-07-16T13:54:06Z","receivedAt":"2009-07-16T13:54:06Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"asciidoc 8.4.1 changed the semantics of inline backtick quoting so\nthat they disable parsing of inline constructs, i.e.,\n\n  Input:\t`{plus}`\n  Pre 8.4.1:\t+\n  Post 8.4.1:\t{plus}\n\nFix this by defining the asciidoc attribute 'no-inline-literal'\n(which, per the 8.4.1 changelog, is the toggle to return to the old\nbehaviour) when under ASCIIDOC8.\n\nSigned-off-by: Thomas Rast <trast@student.ethz.ch>\n---\n\nI checked the output of 8.4.4 with ASCIIDOC8 and ASCIIDOC_NO_ROFF set.\nI unfortunately cannot test if the extra attribute affects pre-8.4.1\nversions.  (If it conflicts, we will have to introduce yet another\nASCIIDOC_* option, but I'm trying to avoid it.)\n\n\n Documentation/Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex 7a8037f..06b0c57 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -84,7 +84,7 @@ endif\n #\n \n ifdef ASCIIDOC8\n-ASCIIDOC_EXTRA += -a asciidoc7compatible\n+ASCIIDOC_EXTRA += -a asciidoc7compatible -a no-inline-literal\n endif\n ifdef DOCBOOK_XSL_172\n ASCIIDOC_EXTRA += -a git-asciidoc-no-roff\n-- \n1.6.4.rc1.193.g17735.dirty\n"},{"id":"118714","messageId":"8e1edb4fb24a009e8eee419df31d0ae17a63a866.1248523345.git.trast@student.ethz.ch","threadId":"20132","inReplyTo":"8e1edb4fb24a009e8eee419df31d0ae17a63a866.1247752162.git.trast@student.ethz.ch","subject":"[PATCH resend] Disable asciidoc 8.4.1+ semantics for `{plus}` and friends","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2009-07-25T12:06:50Z","receivedAt":"2009-07-25T12:06:50Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"asciidoc 8.4.1 changed the semantics of inline backtick quoting so\nthat they disable parsing of inline constructs, i.e.,\n\n  Input:\t`{plus}`\n  Pre 8.4.1:\t+\n  Post 8.4.1:\t{plus}\n\nFix this by defining the asciidoc attribute 'no-inline-literal'\n(which, per the 8.4.1 changelog, is the toggle to return to the old\nbehaviour) when under ASCIIDOC8.\n\nSigned-off-by: Thomas Rast <trast@student.ethz.ch>\n---\n\nI wrote:\n> I checked the output of 8.4.4 with ASCIIDOC8 and ASCIIDOC_NO_ROFF set.\n> I unfortunately cannot test if the extra attribute affects pre-8.4.1\n> versions.  (If it conflicts, we will have to introduce yet another\n> ASCIIDOC_* option, but I'm trying to avoid it.)\n\nJunio, can this go in before 1.6.4?  Otherwise the docs will not be\nrendered right with asciidoc 8.4.1 and newer.  I got hold of a machine\nwith asciidoc 8.2.7 and it does not affect the output there.\n\n\n Documentation/Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex 7a8037f..06b0c57 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -84,7 +84,7 @@ endif\n #\n \n ifdef ASCIIDOC8\n-ASCIIDOC_EXTRA += -a asciidoc7compatible\n+ASCIIDOC_EXTRA += -a asciidoc7compatible -a no-inline-literal\n endif\n ifdef DOCBOOK_XSL_172\n ASCIIDOC_EXTRA += -a git-asciidoc-no-roff\n-- \n1.6.4.rc2.216.g3239.dirty\n"},{"id":"118731","messageId":"7vprbou2eq.fsf@alter.siamese.dyndns.org","threadId":"20132","inReplyTo":"8e1edb4fb24a009e8eee419df31d0ae17a63a866.1248523345.git.trast@student.ethz.ch","subject":"Re: [PATCH resend] Disable asciidoc 8.4.1+ semantics for `{plus}` and friends","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-07-25T16:56:45Z","receivedAt":"2009-07-25T16:56:45Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.  Will queue.\n"}]}