{"thread":{"id":"20112","subject":"[commit 4ecbc178704] Incosistency?","startedAt":"2009-07-14T21:41:40Z","lastAt":"2009-07-17T17:42:13Z","messageCount":7,"participants":["Unknown","Jeff King","Johannes Schindelin","Thomas Adam"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"117985","messageId":"Pine.LNX.4.64.0907142335210.31779@cube","threadId":"20112","inReplyTo":null,"subject":"[commit 4ecbc178704] Incosistency?","fromName":"Unknown","fromEmail":"borg@uu3.net","sentAt":"2009-07-14T21:41:40Z","receivedAt":"2009-07-14T21:41:40Z","isPatch":false,"sender":{"key":"borg@uu3.net","avatar":null},"body":"commit 4ecbc178704ca6c1027a38483e98f5fe493b1322\nAuthor: Jeff King \nDate: Thu Jul 9 02:37:35 2009 -0400\n\nbla bla.. some strange SUDO fix (who the hell uses git that way?)\nI dont like it.. git-add in libexecdir was good!\n\ndiff --git a/Makefile b/Makefile\nindex 78cc113..311ce7d 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1641,15 +1641,15 @@ ifneq (,$X)\n endif\n bindir=$$(cd '$(DESTDIR_SQ)$(bindir_SQ)' && pwd) && \\\n execdir=$$(cd '$(DESTDIR_SQ)$(gitexec_instdir_SQ)' && pwd) && \\\n- { $(RM) \"$$execdir/git-add$X\" && \\\n+ { $(RM) \"$$execdir/git$X\" && \\\n test -z \"$(NO_CROSS_DIRECTORY_HARDLINKS)\" && \\\n- ln \"$$bindir/git$X\" \"$$execdir/git-add$X\" 2>/dev/null || \\\n- cp \"$$bindir/git$X\" \"$$execdir/git-add$X\"; } && \\\n- { for p in $(filter-out git-add$X,$(BUILT_INS)); do \\\n+ ln \"$$bindir/git$X\" \"$$execdir/git$X\" 2>/dev/null || \\\n+ cp \"$$bindir/git$X\" \"$$execdir/git$X\"; } && \\\n+ { for p in $(BUILT_INS); do \\\n $(RM) \"$$execdir/$$p\" && \\\n- ln \"$$execdir/git-add$X\" \"$$execdir/$$p\" 2>/dev/null || \\\n- ln -s \"git-add$X\" \"$$execdir/$$p\" 2>/dev/null || \\\n- cp \"$$execdir/git-add$X\" \"$$execdir/$$p\" || exit; \\\n+ ln \"$$execdir/git$X\" \"$$execdir/$$p\" 2>/dev/null || \\\n+ ln -s \"git$X\" \"$$execdir/$$p\" 2>/dev/null || \\\n+ cp \"$$execdir/git$X\" \"$$execdir/$$p\" || exit; \\\n done; } && \\\n ./check_bindir \"z$$bindir\" \"z$$execdir\" \"$$bindir/git-add$X\"\n\nIsnt check_bindir is broken now?\ngit-add is no more..\n"},{"id":"117986","messageId":"20090714214852.GA2786@coredump.intra.peff.net","threadId":"20112","inReplyTo":"Pine.LNX.4.64.0907142335210.31779@cube","subject":"Re: [commit 4ecbc178704] Incosistency?","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2009-07-14T21:48:52Z","receivedAt":"2009-07-14T21:48:52Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Jul 14, 2009 at 11:41:40PM +0200, Unknown wrote:\n\n> commit 4ecbc178704ca6c1027a38483e98f5fe493b1322\n> Author: Jeff King \n> Date: Thu Jul 9 02:37:35 2009 -0400\n> \n> bla bla.. some strange SUDO fix (who the hell uses git that way?)\n> I dont like it.. git-add in libexecdir was good!\n\nHmm. I think I wrote a better commit message than that...\n\n> - { for p in $(filter-out git-add$X,$(BUILT_INS)); do \\\n> + ln \"$$bindir/git$X\" \"$$execdir/git$X\" 2>/dev/null || \\\n> + cp \"$$bindir/git$X\" \"$$execdir/git$X\"; } && \\\n> + { for p in $(BUILT_INS); do \\\n> $(RM) \"$$execdir/$$p\" && \\\n> - ln \"$$execdir/git-add$X\" \"$$execdir/$$p\" 2>/dev/null || \\\n> - ln -s \"git-add$X\" \"$$execdir/$$p\" 2>/dev/null || \\\n> - cp \"$$execdir/git-add$X\" \"$$execdir/$$p\" || exit; \\\n> + ln \"$$execdir/git$X\" \"$$execdir/$$p\" 2>/dev/null || \\\n> + ln -s \"git$X\" \"$$execdir/$$p\" 2>/dev/null || \\\n> + cp \"$$execdir/git$X\" \"$$execdir/$$p\" || exit; \\\n> done; } && \\\n> ./check_bindir \"z$$bindir\" \"z$$execdir\" \"$$bindir/git-add$X\"\n> \n> Isnt check_bindir is broken now?\n> git-add is no more..\n\nNo. Two things you are missing:\n\n 1. \"git-add\" still goes in exec-dir. It's just not the magic one we do\n separately (see how we no longer need to use filter-out?).\n\n 2. check_bindir is actually about looking for dashed-form commands in\n the $bindir, which would indicate cruft from an older installed\n version of git. We can't use \"git\" for this, because that is the\n command that is _supposed_ to be in $bindir.\n\n-Peff\n"},{"id":"117987","messageId":"alpine.DEB.1.00.0907150030180.3155@pacific.mpi-cbg.de","threadId":"20112","inReplyTo":"20090714214852.GA2786@coredump.intra.peff.net","subject":"Re: [commit 4ecbc178704] Incosistency?","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-07-14T22:30:43Z","receivedAt":"2009-07-14T22:30:43Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 14 Jul 2009, Jeff King wrote:\n\n> On Tue, Jul 14, 2009 at 11:41:40PM +0200, Unknown wrote:\n> \n> > commit 4ecbc178704ca6c1027a38483e98f5fe493b1322\n> > Author: Jeff King \n> > Date: Thu Jul 9 02:37:35 2009 -0400\n> > \n> > bla bla.. some strange SUDO fix (who the hell uses git that way?)\n> > I dont like it.. git-add in libexecdir was good!\n> \n> Hmm. I think I wrote a better commit message than that...\n\nSee? No good deed goes unpunished.\n\nCiao,\nDscho\n"},{"id":"117988","messageId":"18071eea0907141542g46d9deb2k1647cabc998e61ea@mail.gmail.com","threadId":"20112","inReplyTo":"Pine.LNX.4.64.0907142335210.31779@cube","subject":"Re: [commit 4ecbc178704] Incosistency?","fromName":"Thomas Adam","fromEmail":"thomas.adam22@gmail.com","sentAt":"2009-07-14T22:42:12Z","receivedAt":"2009-07-14T22:42:12Z","isPatch":false,"sender":{"key":"thomas.adam22@gmail.com","avatar":"https://gravatar.com/avatar/137f9858bc6bfd5b2f743aefd988c81ce0cbd306248889df80e269519cfc8741?d=mp&s=160"},"body":"Dear me --\n\n2009/7/14 Unknown :\n> commit 4ecbc178704ca6c1027a38483e98f5fe493b1322\n> Author: Jeff King \n> Date:   Thu Jul 9 02:37:35 2009 -0400\n>\n> bla bla.. some strange SUDO fix (who the hell uses git that way?)\n> I dont like it.. git-add in libexecdir was good!\n\nNo, your understanding of that stinks. The test, *without* your\nso-called patch wotk just fine.\n\n-- Thomas Adam\n"},{"id":"118007","messageId":"Pine.LNX.4.64.0907151028050.10773@cube","threadId":"20112","inReplyTo":"20090714214852.GA2786@coredump.intra.peff.net","subject":"Re: [commit 4ecbc178704] Incosistency?","fromName":"Unknown","fromEmail":"borg@uu3.net","sentAt":"2009-07-15T08:32:32Z","receivedAt":"2009-07-15T08:32:32Z","isPatch":false,"sender":{"key":"borg@uu3.net","avatar":null},"body":"On Tue, 14 Jul 2009, Jeff King wrote:\n> Hmm. I think I wrote a better commit message than that...\nYes you did :)\n\n> No. Two things you are missing:\n>\n> 1. \"git-add\" still goes in exec-dir. It's just not the magic one we do\n> separately (see how we no longer need to use filter-out?).\nRight. but git-add now is a link to git. Now we have one more file out \nthere.\n\n> 2. check_bindir is actually about looking for dashed-form commands in\n> the $bindir, which would indicate cruft from an older installed\n> version of git. We can't use \"git\" for this, because that is the\n> command that is _supposed_ to be in $bindir.\nIndeed. Thanks for clarification.\n\nRegards,\nBorg\n"},{"id":"118008","messageId":"20090715094252.GA26048@coredump.intra.peff.net","threadId":"20112","inReplyTo":"Pine.LNX.4.64.0907151028050.10773@cube","subject":"Re: [commit 4ecbc178704] Incosistency?","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2009-07-15T09:42:52Z","receivedAt":"2009-07-15T09:42:52Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Jul 15, 2009 at 10:32:32AM +0200, Unknown wrote:\n\n> > 1. \"git-add\" still goes in exec-dir. It's just not the magic one we do\n> > separately (see how we no longer need to use filter-out?).\n> Right. but git-add now is a link to git. Now we have one more file\n> out there.\n\nSorry, I don't understand the significance. Is having 'git' in the\nexecdir causing some kind of problem?\n\nI agree that it shouldn't be necessary for most sane setups, but sadly\nthere are some insane ones, and I don't think this solution should be\nhurting anyone else. Am I wrong?\n\n-Peff\n"},{"id":"118189","messageId":"Pine.LNX.4.64.0907171939350.5833@cube","threadId":"20112","inReplyTo":"20090715094252.GA26048@coredump.intra.peff.net","subject":"Re: [commit 4ecbc178704] Incosistency?","fromName":"Unknown","fromEmail":"borg@uu3.net","sentAt":"2009-07-17T17:42:13Z","receivedAt":"2009-07-17T17:42:13Z","isPatch":false,"sender":{"key":"borg@uu3.net","avatar":null},"body":"Sorry for long answer.. my CRT died.. and I had to get temp replacement.\n\nAfter resolving conflicts it should work clean on my old cygwin too.\nSo no problem. I think its best to close this topic.\n\nRegards,\nBorg\n\nOn Wed, 15 Jul 2009, Jeff King wrote:\n> Sorry, I don't understand the significance. Is having 'git' in the\n> execdir causing some kind of problem?\n>\n> I agree that it shouldn't be necessary for most sane setups, but sadly\n> there are some insane ones, and I don't think this solution should be\n> hurting anyone else. Am I wrong?\n>\n> -Peff\n>\n"}]}