{"thread":{"id":"19989","subject":"[PATCH] http-push: fix xml_entities() string parsing overrun","startedAt":"2009-07-01T00:24:47Z","lastAt":"2009-07-01T00:24:47Z","messageCount":1,"participants":["Hunter, D. Seth"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"117278","messageId":"D7CBF77D2B9C1D4D8C5E528FBBB35D8B58EC70ECDA@LLE2K7-BE02.mitll.ad.local","threadId":"19989","inReplyTo":null,"subject":"[PATCH] http-push: fix xml_entities() string parsing overrun","fromName":"Hunter, D. Seth","fromEmail":"hunter@ll.mit.edu","sentAt":"2009-07-01T00:24:47Z","receivedAt":"2009-07-01T00:24:47Z","isPatch":true,"sender":{"key":"hunter@ll.mit.edu","avatar":null},"body":"xml_entities() in http-push.c did not properly stop at the end of the string being examined, which would occasionally cause nonsense to be appended to escaped URL strings and result in failed DAV XML queries\n\nSigned-off-by: Seth Hunter <hunter@ll.mit.edu>\n---\n http-push.c |    2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/http-push.c b/http-push.c\nindex 8cc8ee0..00e83dc 100644\n--- a/http-push.c\n+++ b/http-push.c\n@@ -193,6 +193,8 @@ static char *xml_entities(char *s)\n \t\tcase '&':\n \t\t\tstrbuf_addstr(&buf, \"&amp;\");\n \t\t\tbreak;\n+\t\tcase 0:\n+\t\t\treturn strbuf_detach(&buf, NULL);\n \t\t}\n \t\ts++;\n \t}\n-- \n1.6.3.3\n"}]}