{"thread":{"id":"19799","subject":"[PATCH QGit] Fix \"Save as...\" for a file changed in the working dir","startedAt":"2009-06-13T11:04:04Z","lastAt":"2009-06-13T11:04:04Z","messageCount":1,"participants":["Markus Heidelberg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"116223","messageId":"1244891044-10582-2-git-send-email-markus.heidelberg@web.de","threadId":"19799","inReplyTo":null,"subject":"[PATCH QGit] Fix \"Save as...\" for a file changed in the working dir","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-06-13T11:04:04Z","receivedAt":"2009-06-13T11:04:04Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"The second argument of Git::saveFile() is the filename, but the commit\nSHA1 has been used, leading to the following error message:\n\nAn error occurred while executing command:\n\ncat 0000000000000000000000000000000000000000\n\nGit says:\n\n/bin/cat: 0000000000000000000000000000000000000000: No such file or directory\n\nSigned-off-by: Markus Heidelberg <markus.heidelberg@web.de>\n---\n\n\tIs there a difference between rv->st.fileName() and f.filename()?\n\tThey seem to be equal, I chose the former for the function call.\n\n src/mainimpl.cpp |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/src/mainimpl.cpp b/src/mainimpl.cpp\nindex bd19ea1..382dc5d 100644\n--- a/src/mainimpl.cpp\n+++ b/src/mainimpl.cpp\n@@ -1353,7 +1353,7 @@ void MainImpl::ActSaveFile_activated() {\n \n \tQApplication::setOverrideCursor(QCursor(Qt::WaitCursor));\n \tQString fileSha(git->getFileSha(rv->st.fileName(), rv->st.sha()));\n-\tif (!git->saveFile(fileSha, rv->st.sha(), fileName))\n+\tif (!git->saveFile(fileSha, rv->st.fileName(), fileName))\n \t\tstatusBar()->showMessage(\"Unable to save \" + fileName);\n \n \tQApplication::restoreOverrideCursor();\n-- \n1.6.3.2.248.g8cb59\n"}]}