{"thread":{"id":"1979","subject":"[PATCH] Fix gcc-4 warning in accept() call","startedAt":"2005-09-29T21:05:01Z","lastAt":"2005-09-30T06:21:35Z","messageCount":5,"participants":["Pavel Roskin","Junio C Hamano","H. Peter Anvin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"9500","messageId":"1128027901.24397.57.camel@dv","threadId":"1979","inReplyTo":null,"subject":"[PATCH] Fix gcc-4 warning in accept() call","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2005-09-29T21:05:01Z","receivedAt":"2005-09-29T21:05:01Z","isPatch":true,"sender":{"key":"proski@gnu.org","avatar":null},"body":"Fix gcc-4 warning in accept() call\n\ngcc-4 warns about sign mismatch in pointers.  Third argument in accept()\nis socklen_t, which is unsigned.  Since Linus doesn't like socklen_t\n(see commit 7fa090844f7d1624c7d1ffc621aae6aec84a1110), let's use\nunsigned int.\n\nSigned-off-by: Pavel Roskin <proski@gnu.org>\n\ndiff --git a/daemon.c b/daemon.c\n--- a/daemon.c\n+++ b/daemon.c\n@@ -459,7 +459,7 @@ static int serve(int port)\n \n \t\t\tif (FD_ISSET(sockfd, &fds)) {\n \t\t\t\tstruct sockaddr_storage ss;\n-\t\t\t\tint sslen = sizeof(ss);\n+\t\t\t\tunsigned int sslen = sizeof(ss);\n \t\t\t\tint incoming = accept(sockfd, (struct sockaddr *)&ss, &sslen);\n \t\t\t\tif (incoming < 0) {\n \t\t\t\t\tswitch (errno) {\n\n\n-- \nRegards,\nPavel Roskin\n"},{"id":"9531","messageId":"7vachv9kbq.fsf@assigned-by-dhcp.cox.net","threadId":"1979","inReplyTo":"1128027901.24397.57.camel@dv","subject":"Re: [PATCH] Fix gcc-4 warning in accept() call","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-09-30T05:49:13Z","receivedAt":"2005-09-30T05:49:13Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Pavel Roskin <proski@gnu.org> writes:\n\n> gcc-4 warns about sign mismatch in pointers.  Third argument in accept()\n> is socklen_t, which is unsigned.  Since Linus doesn't like socklen_t\n> (see commit 7fa090844f7d1624c7d1ffc621aae6aec84a1110), let's use\n> unsigned int.\n\nBased on the list comments, I'd drop this patch -- it appears\nthat gcc-4 warning is useless in this case.\n"},{"id":"9533","messageId":"433CD2E7.5090909@zytor.com","threadId":"1979","inReplyTo":"7vachv9kbq.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Fix gcc-4 warning in accept() call","fromName":"H. Peter Anvin","fromEmail":"hpa@zytor.com","sentAt":"2005-09-30T05:53:43Z","receivedAt":"2005-09-30T05:53:43Z","isPatch":true,"sender":{"key":"hpa@zytor.com","avatar":null},"body":"Junio C Hamano wrote:\n> Pavel Roskin <proski@gnu.org> writes:\n> \n> \n>>gcc-4 warns about sign mismatch in pointers.  Third argument in accept()\n>>is socklen_t, which is unsigned.  Since Linus doesn't like socklen_t\n>>(see commit 7fa090844f7d1624c7d1ffc621aae6aec84a1110), let's use\n>>unsigned int.\n> \n> Based on the list comments, I'd drop this patch -- it appears\n> that gcc-4 warning is useless in this case.\n> \n\nNo, it's not.  The proper type, if you don't use socklen_t, is int, not \nunsigned int.\n\n\t-hpa\n"},{"id":"9534","messageId":"433CD412.8020409@zytor.com","threadId":"1979","inReplyTo":"433CD2E7.5090909@zytor.com","subject":"Re: [PATCH] Fix gcc-4 warning in accept() call","fromName":"H. Peter Anvin","fromEmail":"hpa@zytor.com","sentAt":"2005-09-30T05:58:42Z","receivedAt":"2005-09-30T05:58:42Z","isPatch":true,"sender":{"key":"hpa@zytor.com","avatar":null},"body":"H. Peter Anvin wrote:\n> Junio C Hamano wrote:\n> \n>> Pavel Roskin <proski@gnu.org> writes:\n>>\n>>\n>>> gcc-4 warns about sign mismatch in pointers.  Third argument in accept()\n>>> is socklen_t, which is unsigned.  Since Linus doesn't like socklen_t\n>>> (see commit 7fa090844f7d1624c7d1ffc621aae6aec84a1110), let's use\n>>> unsigned int.\n>>\n>>\n>> Based on the list comments, I'd drop this patch -- it appears\n>> that gcc-4 warning is useless in this case.\n>>\n> \n> No, it's not.  The proper type, if you don't use socklen_t, is int, not \n> unsigned int.\n> \n\nApparently I'm wrong; socklen_t is unsigned int at least on glibc for \ni386.  I'll shut up now.\n\n\t-hpa\n"},{"id":"9535","messageId":"7vvf0j849c.fsf@assigned-by-dhcp.cox.net","threadId":"1979","inReplyTo":"433CD412.8020409@zytor.com","subject":"Re: [PATCH] Fix gcc-4 warning in accept() call","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-09-30T06:21:35Z","receivedAt":"2005-09-30T06:21:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"H. Peter Anvin\" <hpa@zytor.com> writes:\n\n> Apparently I'm wrong; socklen_t is unsigned int at least on glibc for \n> i386.  I'll shut up now.\n\nAh, I should shut up too.  Thanks for checking what we should\nuse.\n"}]}