{"thread":{"id":"19785","subject":"[PATCH QGit] Fix compiler warning due to ambiguous 'else'","startedAt":"2009-06-12T12:07:55Z","lastAt":"2009-06-12T12:07:55Z","messageCount":1,"participants":["Markus Heidelberg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"116146","messageId":"1244808481-13012-1-git-send-email-markus.heidelberg@web.de","threadId":"19785","inReplyTo":null,"subject":"[PATCH QGit] Fix compiler warning due to ambiguous 'else'","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-06-12T12:07:55Z","receivedAt":"2009-06-12T12:07:55Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"g++ 4.3.2 produced the following warning:\n\ntreeview.cpp: In member function ‘void TreeView::updateTree()’:\ntreeview.cpp:221: warning: suggest explicit braces to avoid ambiguous ‘else’\n\nSigned-off-by: Markus Heidelberg <markus.heidelberg@web.de>\n---\n src/treeview.cpp |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/src/treeview.cpp b/src/treeview.cpp\nindex 346c577..d391a32 100644\n--- a/src/treeview.cpp\n+++ b/src/treeview.cpp\n@@ -222,7 +222,7 @@ void TreeView::updateTree() {\n \t    && treeIsValid\n \t    && root\n \t    && st->sha() != QGit::ZERO_SHA\n-\t    && root->treeSha != QGit::ZERO_SHA)\n+\t    && root->treeSha != QGit::ZERO_SHA) {\n \t\t// root->treeSha could reference a different sha from current\n \t\t// one in case the tree is the same, i.e. has the same files.\n \t\t// so we prefer to use the previous state sha to call isSameFiles()\n@@ -233,6 +233,7 @@ void TreeView::updateTree() {\n \t\t\tnewTree = !git->isSameFiles(st->sha(false), st->sha(true));\n \t\telse\n \t\t\tnewTree = !git->isSameFiles(root->treeSha, st->sha(true));\n+\t}\n \n \tif (newTree) // ok, we really need to update the tree\n \t\tsetTree(st->sha());\n-- \n1.6.3.2.236.ge505d\n"}]}