{"thread":{"id":"19753","subject":"[PATCH] fix handling of iconv configuration options","startedAt":"2009-06-09T03:46:38Z","lastAt":"2009-06-09T03:46:38Z","messageCount":1,"participants":["Marco Nelissen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"115868","messageId":"3a3d9e520906082046g648ac0fah1d72c0c4fd4335ca@mail.gmail.com","threadId":"19753","inReplyTo":null,"subject":"[PATCH] fix handling of iconv configuration options","fromName":"Marco Nelissen","fromEmail":"marcone@xs4all.nl","sentAt":"2009-06-09T03:46:38Z","receivedAt":"2009-06-09T03:46:38Z","isPatch":true,"sender":{"key":"marcone@xs4all.nl","avatar":null},"body":"Fix the way in which the configure script handles --without-iconv\n(and --with-iconv=no), which it  used to essentially ignore.\nAlso fix the way the configure script determines the value of\nNEEDS_LIBICONV, which would be incorrectly set to 'YesPlease' on\nsystems that lack iconv entirely.\n\nSigned-off-by: Marco Nelissen <marcone@xs4all.nl>\n---\n\nTake two: use doublequotes in test\n\n configure.ac |    8 ++++++++\n 1 files changed, 8 insertions(+), 0 deletions(-)\n\ndiff --git a/configure.ac b/configure.ac\nindex 108a97f..bd00eba 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -385,6 +385,8 @@ AC_SUBST(NO_EXPAT)\n # some Solaris installations).\n # Define NO_ICONV if neither libc nor libiconv support iconv.\n\n+if test -z \"$NO_ICONV\"; then\n+\n GIT_STASH_FLAGS($ICONVDIR)\n\n AC_DEFUN([ICONVTEST_SRC], [\n@@ -431,6 +433,12 @@ GIT_UNSTASH_FLAGS($ICONVDIR)\n AC_SUBST(NEEDS_LIBICONV)\n AC_SUBST(NO_ICONV)\n\n+if test -n \"$NO_ICONV\"; then\n+    NEEDS_LIBICONV=\n+fi\n+\n+fi\n+\n #\n # Define NO_DEFLATE_BOUND if deflateBound is missing from zlib.\n\n-- \n1.6.3.1\n"}]}