{"thread":{"id":"19712","subject":"[PATCH QGit 0/4] enhancements for the context menu of the Rev list","startedAt":"2009-06-06T11:57:47Z","lastAt":"2009-06-07T17:18:20Z","messageCount":9,"participants":["Markus Heidelberg","Marco Costalba","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"115641","messageId":"1244289471-698-1-git-send-email-markus.heidelberg@web.de","threadId":"19712","inReplyTo":null,"subject":"[PATCH QGit 0/4] enhancements for the context menu of the Rev list","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-06-06T11:57:47Z","receivedAt":"2009-06-06T11:57:47Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"Markus Heidelberg (4):\n Don't count the submenu entries for checking if it is empty\n Correctly count the entries in the revs context menu\n Avoid submenus with merely 1 entry\n Create a separate submenu for tags\n\n src/mainimpl.cpp | 51 +++++++++++++++++++++++++++++++++++++++------------\n 1 files changed, 39 insertions(+), 12 deletions(-)\n"},{"id":"115646","messageId":"200906061414.27371.markus.heidelberg@web.de","threadId":"19712","inReplyTo":"1244289471-698-1-git-send-email-markus.heidelberg@web.de","subject":"Re: [PATCH QGit 0/4] enhancements for the context menu of the Rev list","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-06-06T12:14:26Z","receivedAt":"2009-06-06T12:14:26Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"Markus Heidelberg, 06.06.2009:\n> Markus Heidelberg (4):\n> Don't count the submenu entries for checking if it is empty\n> Correctly count the entries in the revs context menu\n> Avoid submenus with merely 1 entry\n> Create a separate submenu for tags\n\nHmm, no In-Reply-To in 1..4/4\n\nI think I managed to do this earlier with just\n $ git format-patch -4 -s\n $ git send-email 000*\n\nBut not even\n $ git send-email --thread 000*\nseems to work.\n\nOnly \n $ git format-patch -4 -s --thread\n $ git send-email 000*\n"},{"id":"115649","messageId":"e5bfff550906060650p691bd6d0o136a981159b5050e@mail.gmail.com","threadId":"19712","inReplyTo":"1244289471-698-1-git-send-email-markus.heidelberg@web.de","subject":"Re: [PATCH QGit 0/4] enhancements for the context menu of the Rev list","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2009-06-06T13:50:23Z","receivedAt":"2009-06-06T13:50:23Z","isPatch":true,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On Sat, Jun 6, 2009 at 13:57, Markus Heidelberg wrote:\n> Markus Heidelberg (4):\n>  Don't count the submenu entries for checking if it is empty\n>  Correctly count the entries in the revs context menu\n>  Avoid submenus with merely 1 entry\n>  Create a separate submenu for tags\n>\n>  src/mainimpl.cpp |   51 +++++++++++++++++++++++++++++++++++++++------------\n>  1 files changed, 39 insertions(+), 12 deletions(-)\n>\n>\n\nThanks for this series. Context menu really needed some love.\n\nPatches applied and pushed to\n\nhttp://git.kernel.org/?p=qgit/qgit4.git;a=summary\n\n\nMarco\n"},{"id":"115709","messageId":"1244388019-12763-1-git-send-email-markus.heidelberg@web.de","threadId":"19712","inReplyTo":"200906061414.27371.markus.heidelberg@web.de","subject":"[PATCH 1/2] add a test case for threaded mails without chain-reply-to","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-06-07T15:20:18Z","receivedAt":"2009-06-07T15:20:18Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"\nSigned-off-by: Markus Heidelberg \n---\n\n> Markus Heidelberg, 06.06.2009:\n> > Markus Heidelberg (4):\n> > Don't count the submenu entries for checking if it is empty\n> > Correctly count the entries in the revs context menu\n> > Avoid submenus with merely 1 entry\n> > Create a separate submenu for tags\n> \n> Hmm, no In-Reply-To in 1..4/4\n> \n> I think I managed to do this earlier with just\n> $ git format-patch -4 -s\n> $ git send-email 000*\n> \n> But not even\n> $ git send-email --thread 000*\n> seems to work.\n> \n> Only \n> $ git format-patch -4 -s --thread\n> $ git send-email 000*\n\nIndeed a regression.\n\n t/t9001-send-email.sh | 11 +++++++++++\n 1 files changed, 11 insertions(+), 0 deletions(-)\n\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex ce26ea4..576bbd3 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -621,4 +621,15 @@ test_expect_success 'in-reply-to but no threading' '\n \tgrep \"In-Reply-To: \"\n '\n \n+test_expect_failure 'threading but no chain-reply-to' '\n+\tgit send-email \\\n+\t\t--dry-run \\\n+\t\t--from=\"Example \" \\\n+\t\t--to=nobody@example.com \\\n+\t\t--thread \\\n+\t\t--no-chain-reply-to \\\n+\t\t$patches $patches |\n+\tgrep \"In-Reply-To: \"\n+'\n+\n test_done\n-- \n1.6.3.2.216.g24c61\n"},{"id":"115710","messageId":"1244388019-12763-2-git-send-email-markus.heidelberg@web.de","threadId":"19712","inReplyTo":"1244388019-12763-1-git-send-email-markus.heidelberg@web.de","subject":"[PATCH 2/2] send-email: fix threaded mails without chain-reply-to","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-06-07T15:20:19Z","receivedAt":"2009-06-07T15:20:19Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"These commands didn't send threaded mails anymore:\n\n $ git format-patch \n $ git send-email --thread --no-chain-reply-to \n\nThis regression was introduced in commit 15da108 (\"send-email:\n'References:' should only reference what is sent\", 2009-04-13) by a\nhidden code style change:\n\n ! defined $reply_to || length($reply_to) == 0\nwas changed to\n not defined $reply_to || length($reply_to) == 0\nwhich is\n not (defined $reply_to || length($reply_to) == 0)\ninstead of\n (not defined $reply_to) || (length($reply_to) == 0)\n\nSigned-off-by: Markus Heidelberg \n---\n git-send-email.perl | 2 +-\n t/t9001-send-email.sh | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 3d6a982..c914bff 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -1142,7 +1142,7 @@ foreach my $t (@files) {\n \tmy $message_was_sent = send_message();\n \n \t# set up for the next message\n-\tif ($message_was_sent and $chain_reply_to || not defined $reply_to || length($reply_to) == 0) {\n+\tif ($message_was_sent and $chain_reply_to || !defined $reply_to || length($reply_to) == 0) {\n \t\t$reply_to = $message_id;\n \t\tif (length $references > 0) {\n \t\t\t$references .= \"\\n $message_id\";\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex 576bbd3..bb03aa4 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -621,7 +621,7 @@ test_expect_success 'in-reply-to but no threading' '\n \tgrep \"In-Reply-To: \"\n '\n \n-test_expect_failure 'threading but no chain-reply-to' '\n+test_expect_success 'threading but no chain-reply-to' '\n \tgit send-email \\\n \t\t--dry-run \\\n \t\t--from=\"Example \" \\\n-- \n1.6.3.2.216.g24c61\n"},{"id":"115715","messageId":"7vskic9e3e.fsf@alter.siamese.dyndns.org","threadId":"19712","inReplyTo":"1244388019-12763-2-git-send-email-markus.heidelberg@web.de","subject":"Re: [PATCH 2/2] send-email: fix threaded mails without chain-reply-to","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-06-07T16:57:09Z","receivedAt":"2009-06-07T16:57:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"},{"id":"115718","messageId":"200906071859.02871.markus.heidelberg@web.de","threadId":"19712","inReplyTo":"1244388019-12763-2-git-send-email-markus.heidelberg@web.de","subject":"Re: [PATCH 2/2] send-email: fix threaded mails without chain-reply-to","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-06-07T16:59:02Z","receivedAt":"2009-06-07T16:59:02Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"Markus Heidelberg, 07.06.2009:\n> These commands didn't send threaded mails anymore:\n> \n> $ git format-patch \n> $ git send-email --thread --no-chain-reply-to \n\nI also just noticed a warning without this patch, can't remember if I\nhave seen it before...\n\nUse of uninitialized value in length at\n/home/markus/git/install/libexec/git-core/git-send-email line 1146.\n"},{"id":"115719","messageId":"1244394750-30189-1-git-send-email-markus.heidelberg@web.de","threadId":"19712","inReplyTo":"1244388019-12763-1-git-send-email-markus.heidelberg@web.de","subject":"[PATCH v2] add a test case for threaded mails without chain-reply-to","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-06-07T17:12:30Z","receivedAt":"2009-06-07T17:12:30Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"---\n\n--nochain-reply-to instead of\n--no-chain-reply-to\n\nsee commits 3fee1fe8 and 84eeb687:\nt9001: use older Getopt::Long boolean prefix '--no' rather than '--no-'\n\n t/t9001-send-email.sh | 11 +++++++++++\n 1 files changed, 11 insertions(+), 0 deletions(-)\n\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex ce26ea4..4ccca44 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -621,4 +621,15 @@ test_expect_success 'in-reply-to but no threading' '\n \tgrep \"In-Reply-To: \"\n '\n \n+test_expect_failure 'threading but no chain-reply-to' '\n+\tgit send-email \\\n+\t\t--dry-run \\\n+\t\t--from=\"Example \" \\\n+\t\t--to=nobody@example.com \\\n+\t\t--thread \\\n+\t\t--nochain-reply-to \\\n+\t\t$patches $patches |\n+\tgrep \"In-Reply-To: \"\n+'\n+\n test_done\n-- \n1.6.3.2.216.g24c61.dirty\n"},{"id":"115720","messageId":"200906071918.21241.markus.heidelberg@web.de","threadId":"19712","inReplyTo":"1244394750-30189-1-git-send-email-markus.heidelberg@web.de","subject":"Re: [PATCH v2] add a test case for threaded mails without chain-reply-to","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-06-07T17:18:20Z","receivedAt":"2009-06-07T17:18:20Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"Markus Heidelberg, 07.06.2009:\n> ---\n> \n> --nochain-reply-to instead of\n> --no-chain-reply-to\n> \n> see commits 3fee1fe8 and 84eeb687:\n> t9001: use older Getopt::Long boolean prefix '--no' rather than '--no-'\n> \n> t/t9001-send-email.sh | 11 +++++++++++\n> 1 files changed, 11 insertions(+), 0 deletions(-)\n\nAh, the subject should have been [PATCH v2 1/2] and there should have\nbeen a Signed-Off. I'll resend cleanly with some more patches in a\nseries shortly (I guess :))\n"}]}