{"thread":{"id":"1964","subject":"[PATCH] Fix git-add argument parsing","startedAt":"2005-09-28T14:27:53Z","lastAt":"2005-09-28T14:27:53Z","messageCount":1,"participants":["Timo Hirvonen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"9422","messageId":"20050928172753.0e883738.tihirvon@gmail.com","threadId":"1964","inReplyTo":null,"subject":"[PATCH] Fix git-add argument parsing","fromName":"Timo Hirvonen","fromEmail":"tihirvon@gmail.com","sentAt":"2005-09-28T14:27:53Z","receivedAt":"2005-09-28T14:27:53Z","isPatch":true,"sender":{"key":"tihirvon@gmail.com","avatar":null},"body":"Complain if no arguments given instead of adding all files\nto the index.\n\nSigned-off-by: Timo Hirvonen <tihirvon@gmail.com>\n\n---\n\n git-add.sh |   44 ++++++++++++++++++++++++++++++--------------\n 1 files changed, 30 insertions(+), 14 deletions(-)\n\n60d2803555831a9a9bfa2d97cec5ab2fbed1fb2c\ndiff --git a/git-add.sh b/git-add.sh\n--- a/git-add.sh\n+++ b/git-add.sh\n@@ -1,23 +1,39 @@\n #!/bin/sh\n \n+usage()\n+{\n+\techo \"usage: git add [-n] [-v] <file>...\"\n+\texit 1\n+}\n+\n show_only=\n verbose=\n-while : ; do\n-  case \"$1\" in\n-    -n)\n-\tshow_only=true\n-\tverbose=true\n-\t;;\n-    -v)\n-\tverbose=true\n-\t;;\n-    *)\n-\tbreak\n-\t;;\n-  esac\n-  shift\n+while test $# -gt 0\n+do\n+\tcase \"$1\" in\n+\t-n)\n+\t\tshow_only=true\n+\t\tverbose=true\n+\t\t;;\n+\t-v)\n+\t\tverbose=true\n+\t\t;;\n+\t--)\n+\t\tshift\n+\t\tbreak\n+\t\t;;\n+\t-*)\n+\t\tusage\n+\t\t;;\n+\t*)\n+\t\tbreak\n+\t\t;;\n+\tesac\n+\tshift\n done\n \n+test $# -eq 0 && usage\n+\n GIT_DIR=$(git-rev-parse --git-dir) || exit\n global_exclude=\n if [ -f \"$GIT_DIR/info/exclude\" ]; then\n"}]}