{"thread":{"id":"19632","subject":"wrong expectation from \"git log -p\"","startedAt":"2009-06-02T00:34:53Z","lastAt":"2009-07-05T08:35:01Z","messageCount":6,"participants":["Thomas Spura","Junio C Hamano","Todd Zullinger","Thomas Rast","Eric Wong"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"115224","messageId":"pan.2009.06.02.00.34.36@fedoraproject.org","threadId":"19632","inReplyTo":null,"subject":"wrong expectation from \"git log -p\"","fromName":"Thomas Spura","fromEmail":"tomspur@fedoraproject.org","sentAt":"2009-06-02T00:34:53Z","receivedAt":"2009-06-02T00:34:53Z","isPatch":false,"sender":{"key":"tomspur@fedoraproject.org","avatar":"https://gravatar.com/avatar/ddf763cae481e089eeffdb3fb1ed26ec2972fcd73703b3a4d2c04e7bce7b362f?d=mp&s=160"},"body":"If running \"git log -p parse-options.*\", the last commit is \ndf217ed6430efe444a09fffdafd39720ae3f9864\nThere are the changes this commit makes towards parse-options.*.\n\nI was expecting to see the full commit with all changes and not only \ntowards the 2 files - only including the two files.\n\nIs my expactation wrong or is this a bug?\n\n\tThomas\n"},{"id":"115225","messageId":"7vzlcrihew.fsf@alter.siamese.dyndns.org","threadId":"19632","inReplyTo":"pan.2009.06.02.00.34.36@fedoraproject.org","subject":"Re: wrong expectation from \"git log -p\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-06-02T00:54:47Z","receivedAt":"2009-06-02T00:54:47Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thomas Spura writes:\n\n> If running \"git log -p parse-options.*\", the last commit is \n> df217ed6430efe444a09fffdafd39720ae3f9864\n> There are the changes this commit makes towards parse-options.*.\n>\n> I was expecting to see the full commit with all changes and not only \n> towards the 2 files - only including the two files.\n>\n> Is my expactation wrong or is this a bug?\n\nTime to run \"man git-log\" and look for --full-diff, perhaps?\n"},{"id":"115338","messageId":"20090603122230.GZ28808@inocybe.localdomain","threadId":"19632","inReplyTo":"7vzlcrihew.fsf@alter.siamese.dyndns.org","subject":"[PATCH] completion: Add --full-diff to log/gitk options","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2009-06-03T12:22:30Z","receivedAt":"2009-06-03T12:22:30Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Signed-off-by: Todd Zullinger \n---\n\nJunio C Hamano wrote:\n> Thomas Spura writes:\n>\n>> If running \"git log -p parse-options.*\", the last commit is\n>> df217ed6430efe444a09fffdafd39720ae3f9864\n>> There are the changes this commit makes towards parse-options.*.\n>>\n>> I was expecting to see the full commit with all changes and not only\n>> towards the 2 files - only including the two files.\n>>\n>> Is my expactation wrong or is this a bug?\n>\n> Time to run \"man git-log\" and look for --full-diff, perhaps?\n\nWhile this patch won't do much to help people find the option, perhaps\nthose who learn about it will appreciate not having to type it. :)\n\nI *think* __git_log_gitk_options is the proper place for it, but it's\nearly in the a.m. and I'm not averse to being proved wrong.\n\n contrib/completion/git-completion.bash | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 0c8bb53..2b291ea 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1117,7 +1117,7 @@ __git_log_common_options=\"\n \"\n # Options that go well for log and gitk (not shortlog)\n __git_log_gitk_options=\"\n-\t--dense --sparse --full-history\n+\t--dense --sparse --full-diff --full-history\n \t--simplify-merges --simplify-by-decoration\n \t--left-right\n \"\n-- \n1.6.3.1\n\n-- \nTodd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nGoing to hell when I die would just be redundant.\n"},{"id":"115344","messageId":"200906031630.09962.trast@student.ethz.ch","threadId":"19632","inReplyTo":"20090603122230.GZ28808@inocybe.localdomain","subject":"Re: [PATCH] completion: Add --full-diff to log/gitk options","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2009-06-03T14:30:01Z","receivedAt":"2009-06-03T14:30:01Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Todd Zullinger wrote:\n> I *think* __git_log_gitk_options is the proper place for it, but it's\n> early in the a.m. and I'm not averse to being proved wrong.\n[...]\n> # Options that go well for log and gitk (not shortlog)\n> __git_log_gitk_options=\"\n> -\t--dense --sparse --full-history\n> +\t--dense --sparse --full-diff --full-history\n\nGitk has its own setting in the Preferences called \"limit diffs to\nlisted paths\", and ignores this option, so it should go directly in\n_git_log.\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"},{"id":"115369","messageId":"20090603202058.GA28808@inocybe.localdomain","threadId":"19632","inReplyTo":"200906031630.09962.trast@student.ethz.ch","subject":"[PATCH v2] completion: Add --full-diff to log options","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2009-06-03T20:20:58Z","receivedAt":"2009-06-03T20:20:58Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Signed-off-by: Todd Zullinger \n---\n\nThomas Rast wrote:\n> Todd Zullinger wrote:\n>> I *think* __git_log_gitk_options is the proper place for it, but it's\n>> early in the a.m. and I'm not averse to being proved wrong.\n> [...]\n>> # Options that go well for log and gitk (not shortlog)\n>> __git_log_gitk_options=\"\n>> -\t--dense --sparse --full-history\n>> +\t--dense --sparse --full-diff --full-history\n>\n> Gitk has its own setting in the Preferences called \"limit diffs to\n> listed paths\", and ignores this option, so it should go directly in\n> _git_log.\n\nAhh, thanks Thomas.\n\n contrib/completion/git-completion.bash | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 98b9cbe..79a99af 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1157,7 +1157,7 @@ _git_log ()\n \t\t\t$__git_log_shortlog_options\n \t\t\t$__git_log_gitk_options\n \t\t\t--root --topo-order --date-order --reverse\n-\t\t\t--follow\n+\t\t\t--follow --full-diff\n \t\t\t--abbrev-commit --abbrev=\n \t\t\t--relative-date --date=\n \t\t\t--pretty= --format= --oneline\n-- \n1.6.3.1\n\n-- \nTodd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nI have to decide between two equally frightening options. If I wanted\nto do that, I'd vote.\n -- Duckman\n"},{"id":"117454","messageId":"20090705083501.GA13068@dcvr.yhbt.net","threadId":"19632","inReplyTo":"20090603202058.GA28808@inocybe.localdomain","subject":"Re: [PATCH v2] completion: Add --full-diff to log options","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2009-07-05T08:35:01Z","receivedAt":"2009-07-05T08:35:01Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Todd Zullinger wrote:\n> Signed-off-by: Todd Zullinger \n\nI was just missing this completion for \"git log\" myself.\n\nAcked-by: Eric Wong \n\n> ---\n> contrib/completion/git-completion.bash | 2 +-\n> 1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 98b9cbe..79a99af 100755\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -1157,7 +1157,7 @@ _git_log ()\n> \t\t\t$__git_log_shortlog_options\n> \t\t\t$__git_log_gitk_options\n> \t\t\t--root --topo-order --date-order --reverse\n> -\t\t\t--follow\n> +\t\t\t--follow --full-diff\n> \t\t\t--abbrev-commit --abbrev=\n> \t\t\t--relative-date --date=\n> \t\t\t--pretty= --format= --oneline\n> -- \n"}]}