{"thread":{"id":"19570","subject":"[PATCH] Pass \"git config\" flags in the right order","startedAt":"2009-05-29T07:43:50Z","lastAt":"2009-05-29T07:43:50Z","messageCount":1,"participants":["Karl Hasselström"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"114988","messageId":"20090529074300.20591.96310.stgit@october.hq.vtech","threadId":"19570","inReplyTo":null,"subject":"[PATCH] Pass \"git config\" flags in the right order","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2009-05-29T07:43:50Z","receivedAt":"2009-05-29T07:43:50Z","isPatch":true,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"From: Karl Hasselström <kha@treskal.com>\n\nNew enough gits accept the --null and --list flags in any order, but\nolder gits want --null before --list. So do it the way that's fine\nwith everyone.\n\nI think (but haven't verified) that git started to accept the flags in\nany order after commit d64ec16c2af4ddcf3985d11d5dc28a15db181de5 (\"git\nconfig: reorganize to use parseopt\") by Felipe Contreras on\n2009-02-21, first released in git v1.6.3.\n\nSigned-off-by: Karl Hasselström <kha@treskal.com>\n\n---\n\nBug discovered by Daniel Aarno.\n\n stgit/config.py |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\n\ndiff --git a/stgit/config.py b/stgit/config.py\nindex c40756c..dc9c9eb 100644\n--- a/stgit/config.py\n+++ b/stgit/config.py\n@@ -48,7 +48,7 @@ class GitConfig:\n         if self.__cache is not None:\n             return\n         self.__cache = {}\n-        lines = Run('git', 'config', '--list', '--null').raw_output()\n+        lines = Run('git', 'config', '--null', '--list').raw_output()\n         for line in filter(None, lines.split('\\0')):\n             key, value = line.split('\\n', 1)\n             self.__cache.setdefault(key, []).append(value)\n"}]}