{"thread":{"id":"19564","subject":"[PATCH] bisect: use \"clear_commit_marks\" after checking ancestors","startedAt":"2009-05-28T21:24:43Z","lastAt":"2009-05-28T21:24:43Z","messageCount":1,"participants":["Christian Couder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"114969","messageId":"20090528212444.4034.68662.chriscool@tuxfamily.org","threadId":"19564","inReplyTo":null,"subject":"[PATCH] bisect: use \"clear_commit_marks\" after checking ancestors","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2009-05-28T21:24:43Z","receivedAt":"2009-05-28T21:24:43Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"instead of \"unparse_commit\", as it is enough to just clear flags.\n\nSigned-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n bisect.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\n\tAs the patch series where \"unparse_commit\" is added and\n\tused is already in \"next\". Here is a patch to use\n\t\"clear_commit_marks\" instead. The patch that adds\n\t\"unparse_commit\" can be reverted from \"next\" after this\n\tone.\n\ndiff --git a/bisect.c b/bisect.c\nindex c43c120..18f9fa4 100644\n--- a/bisect.c\n+++ b/bisect.c\n@@ -771,7 +771,7 @@ static int check_ancestors(const char *prefix)\n \t/* Clean up objects used, as they will be reused. */\n \tfor (i = 0; i < pending_copy.nr; i++) {\n \t\tstruct object *o = pending_copy.objects[i].item;\n-\t\tunparse_commit((struct commit *)o);\n+\t\tclear_commit_marks((struct commit *)o, ALL_REV_FLAGS);\n \t}\n \n \treturn res;\n-- \n1.6.3.GIT\n"}]}