{"thread":{"id":"19511","subject":"[PATCH] t9120: don't expect failure with SVN_HTTPD_PORT unset","startedAt":"2009-05-26T06:15:47Z","lastAt":"2009-05-26T06:15:47Z","messageCount":1,"participants":["Stephen Boyd"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"114734","messageId":"1243318547-20023-1-git-send-email-bebarino@gmail.com","threadId":"19511","inReplyTo":null,"subject":"[PATCH] t9120: don't expect failure with SVN_HTTPD_PORT unset","fromName":"Stephen Boyd","fromEmail":"bebarino@gmail.com","sentAt":"2009-05-26T06:15:47Z","receivedAt":"2009-05-26T06:15:47Z","isPatch":true,"sender":{"key":"bebarino@gmail.com","avatar":"https://avatars.githubusercontent.com/u/38832?v=4"},"body":"The test still passes when SVN_HTTPD_PORT is not set. Futhermore, t9115\nand t9118 don't check if SVN_HTTPD_PORT is set even though they both use\nstart_httpd() from lib-git-svn.sh. Admittedly, the test is not very\nmeaningful without SVN_HTTPD_PORT, as commit f5530b (support for funky\nbranch and project names over HTTP(S) 2007-11-11) states that the URI\nescaping is only done over HTTP(S).\n\nSigned-off-by: Stephen Boyd <bebarino@gmail.com>\n---\n t/t9120-git-svn-clone-with-percent-escapes.sh |   17 ++++++-----------\n 1 files changed, 6 insertions(+), 11 deletions(-)\n\ndiff --git a/t/t9120-git-svn-clone-with-percent-escapes.sh b/t/t9120-git-svn-clone-with-percent-escapes.sh\nindex 555a018..f159ab6 100755\n--- a/t/t9120-git-svn-clone-with-percent-escapes.sh\n+++ b/t/t9120-git-svn-clone-with-percent-escapes.sh\n@@ -14,17 +14,12 @@ test_expect_success 'setup svnrepo' '\n \tstart_httpd\n '\n \n-if test \"$SVN_HTTPD_PORT\" = \"\"\n-then\n-\ttest_expect_failure 'test clone with percent escapes - needs SVN_HTTPD_PORT set' 'false'\n-else\n-\ttest_expect_success 'test clone with percent escapes' '\n-\t\tgit svn clone \"$svnrepo/pr%20ject\" clone &&\n-\t\tcd clone &&\n-\t\t\tgit rev-parse refs/${remotes_git_svn} &&\n-\t\tcd ..\n-\t'\n-fi\n+test_expect_success 'test clone with percent escapes' '\n+\tgit svn clone \"$svnrepo/pr%20ject\" clone &&\n+\tcd clone &&\n+\t\tgit rev-parse refs/${remotes_git_svn} &&\n+\tcd ..\n+'\n \n stop_httpd\n \n-- \n1.6.3.1.152.g9619f\n"}]}