{"thread":{"id":"19479","subject":"[PATCH 00/18] http*: refactor (v3)","startedAt":"2009-05-24T14:21:01Z","lastAt":"2009-05-24T21:28:16Z","messageCount":3,"participants":["Tay Ray Chuan","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":18},"messages":[{"id":"114570","messageId":"20090524222101.3e6f0496.rctay89@gmail.com","threadId":"19479","inReplyTo":null,"subject":"[PATCH 00/18] http*: refactor (v3)","fromName":"Tay Ray Chuan","fromEmail":"rctay89@gmail.com","sentAt":"2009-05-24T14:21:01Z","receivedAt":"2009-05-24T14:21:01Z","isPatch":true,"sender":{"key":"rctay89@gmail.com","avatar":"https://avatars.githubusercontent.com/u/61553?v=4"},"body":"Junio, I've reworked the patches after \"http-push: fix missing \"#ifdef\nUSE_CURL_MULTI\" around \"is_running_queue\" in rc/http-push. (I thought\nresending everything would clutter things up, but I could for your\nconvenience if you want me to.)\n\nMike, I've only taken some of your patches from your WIP patch series\ndated Jan 18 (http://kerneltrap.org/mailarchive/git/2009/1/18/4757804),\nbecause the rest are more problematic to apply.\n\nHere's a list of changes from Mike's patches and from my previous patch\nseries:\n\n *I removed the contentious http_cleanup in the cleanup patch #7.\n\n *a new http_request return state, HTTP_START_FAILED, has been added.\n\n *http_request prints an error message (\"Unable to start request\") when\n  start_active_slot fails.\n\n *a new http API method, http_error, has been added.\n\n *in patch #12 (http_fetch_ref), the error (\"Unable to start request\")\n  is still removed, like Mike did, since http_request already handles it.\n\n *in patch #13 (remote_exists), the patch has been re-titled from\n  update_remote_info_refs.\n\n *the patches for fetch_http_pack_index and objects/info/packs have\n  been reworked into http_get_info_packs.\n\n *fetch_http_pack_index has been made private.\n\nMike Hommey (6):\n  Don't expect verify_pack() callers to set pack_size\n  Some cleanup in get_refs_via_curl()\n  http: new functions for the http API\n  transport: use the new http API in get_refs_via_curl()\n  http: use the new http API in http_fetch_ref()\n  http-push: use the new http API in fetch_symref()\n\nTay Ray Chuan (12):\n  t5550-http-fetch: test fetching of packed objects\n  http-push, http-walker: style fixes\n  http-walker: verify remote packs\n  http*: copy string returned by sha1_to_hex\n  http-push: do not SEGV after fetching a bad pack idx file\n  http*: move common variables and macros to http.[ch]\n  http: create function end_url_with_slash\n  http-push: use the new http API in remote_exists()\n  http*: add http_get_info_packs\n  http: use new http API in fetch_index()\n  http*: add helper methods for fetching packs\n  http*: add helper methods for fetching objects (loose)\n\n http-push.c           |  533 +++++--------------------------------------\n http-walker.c         |  528 +++++++------------------------------------\n http.c                |  602 +++++++++++++++++++++++++++++++++++++++++++++++--\n http.h                |   85 +++++++\n pack-check.c          |    8 +-\n t/t5550-http-fetch.sh |    8 +\n transport.c           |   33 +--\n 7 files changed, 832 insertions(+), 965 deletions(-)\n"},{"id":"114598","messageId":"7veiueut97.fsf@alter.siamese.dyndns.org","threadId":"19479","inReplyTo":"20090524222101.3e6f0496.rctay89@gmail.com","subject":"Re: [PATCH 00/18] http*: refactor (v3)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-05-24T20:43:16Z","receivedAt":"2009-05-24T20:43:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Tay Ray Chuan <rctay89@gmail.com> writes:\n\n> Junio, I've reworked the patches after \"http-push: fix missing \"#ifdef\n> USE_CURL_MULTI\" around \"is_running_queue\" in rc/http-push. (I thought\n> resending everything would clutter things up, but I could for your\n> convenience if you want me to.)\n\nSending replacements like this while the series is only in 'pu' is\nperfectly fine as long as what patch I have in 'pu' are being replaced.  I\ncan just drop everything between rc/http-push~11 to its tip and apply the\nnew series.\n\nThanks.\n"},{"id":"114599","messageId":"7vk546ry1b.fsf@alter.siamese.dyndns.org","threadId":"19479","inReplyTo":"7veiueut97.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 00/18] http*: refactor (v3)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-05-24T21:28:16Z","receivedAt":"2009-05-24T21:28:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano <gitster@pobox.com> writes:\n\n> Tay Ray Chuan <rctay89@gmail.com> writes:\n>\n>> Junio, I've reworked the patches after \"http-push: fix missing \"#ifdef\n>> USE_CURL_MULTI\" around \"is_running_queue\" in rc/http-push. (I thought\n>> resending everything would clutter things up, but I could for your\n>> convenience if you want me to.)\n>\n> Sending replacements like this while the series is only in 'pu' is\n> perfectly fine as long as what patch I have in 'pu' are being replaced.  I\n\n\"... as long as it is clear what patches I have ...\"; sorry for not\nre-reading what I wrote before sending it out.\n\n> can just drop everything between rc/http-push~11 to its tip and apply the\n> new series.\n>\n> Thanks.\n"}]}