{"thread":{"id":"1947","subject":"Re: [ANNOUNCE qgit-0.95]","startedAt":"2005-09-25T20:37:12Z","lastAt":"2005-09-25T20:37:12Z","messageCount":1,"participants":["Marco Costalba"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"9277","messageId":"20050925203712.48240.qmail@web26305.mail.ukl.yahoo.com","threadId":"1947","inReplyTo":null,"subject":"Re: [ANNOUNCE qgit-0.95]","fromName":"Marco Costalba","fromEmail":"mcostalba@yahoo.it","sentAt":"2005-09-25T20:37:12Z","receivedAt":"2005-09-25T20:37:12Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"Josef Weidendorfer wrote:\n\n>Hi,\n>\n>On Sunday 25 September 2005 07:52, Marco Costalba wrote:\n>\n>>>* The commit time is relative to now, which makes no sense to me. Also,\n>>>it is in the second column instead of the last one like in gitk, which\n>>>seems better to me. At least, the column is too narrow and then it\n>>>blends together with the commit title.\n>\n>\n>I vote for absolute time, and the date column at the end, too.\n\n\n...and 'date column at the end' wins for 3 votes against 0 ;-)\n\n\n>Besides, QT allows to reorder the columns with the mouse (the order should be\n>saved in a config file at end to be persistant over program runs).\n>\n\nYes, good idea.\n\n>>>* Getting to the diff view was non-obvious for me. It'd be nice to have\n>>>some [diff] button as well somewhere. Or you could also show the diff in\n>>>the bottom part of screen in the commit view, I think gitk solved this\n>>>nicely.\n>>\n>>I have tought a lot how to pass to the user the information that to see a\n>>diff you have to double click on the commit:\n>\n>\n>I like the gitk solution better. \n>What about making the commit list a QDockWindow, which can be docked to either \n>side of the window (default: top as currently), but also made a floating \n>window, so that the commit diff gets the whole main window?\n>\n\nShould be nice, but it's a bit of work...maybe I don't know very well QDockWindow.\n\nPeraphs is the commit info pane at the bottom left that could be implemented as a \nQDockWindow with the diff attached below the commit info gitk like.....\n\n\n>\n>I think that diagonal lines as in gitk make it way easier to get an overview.\n>What makes drawing of diagonal lines slow?\n\nwith diagonal line you cannot draw graphs one rev at the time from left to right but you\nneed some information from previous one and eventually pass some information to next one.\n\nThe fact is diagonal lines are originated in a diffrent line from what you are drawing and\nyou need to bring with you that piece of information.\n\nMore, in qgit pixmaps are precalculated in main view ctor and filled in an array, so only \narray indexing is used to retrive and copy correct pixmap according to proper lane type.\n\nAdding diagonals pixmaps is not obvious and not simple, at least for me. I tell you this \nbecause I have tried but the design of graph function became overly complex.\n\n\n>It should be quite fast to subclass QListViewItem for commit entries and\n>overwrite QListViewItem::paintCell to use your own drawing; paintCell is \n>called for visible entries only.\n>\n\nQListViewItem is already subclassed to paint odd/even lines background and tags/heads colors.\nPixmaps are not painted but, as told before, directly copied from a fixed pixmaps array this \nis also done in paintCell(). See ListViewLogItem::paintCell() in mainimpl.cpp if interested.\n\nBecause paintCell() is called for visible entries only, also commit line setup (columns text,\nrelative time calculation, tagging, etc) is done in paintCell() the first time item became\nvisible. So to push to the limit the 'lazy setup' policy and gain speed.\n\n\n>Another wish: The tag/head markers in gitk are really good. In qgit, I only \n>get another background color, and miss the name.\n\nYou can see the name in the status bar when you select the item. Also the refs names are \ncumulative, i.e. if you select a tag that is also a branch head and, eventually also another kind\nof ref, all this information is shown in the status bar. \n\nStatus bar has more avaiable space then inline marker this is the reason I chose that way.\n\n>\n>Yes, really nice.\n>\n\nThanks\n\nMarco\n\n\n__________________________________________________\nDo You Yahoo!?\nTired of spam?  Yahoo! Mail has the best spam protection around \nhttp://mail.yahoo.com \n"}]}