{"thread":{"id":"19408","subject":"[PATCH] gitk: Handle msysGit version during version comparisons","startedAt":"2009-05-18T21:46:01Z","lastAt":"2009-05-19T10:38:08Z","messageCount":5,"participants":["Pat Thoyts","Paul Mackerras","Johannes Schindelin","Michael J Gruber"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"114202","messageId":"87hbzirso6.fsf@users.sourceforge.net","threadId":"19408","inReplyTo":null,"subject":"[PATCH] gitk: Handle msysGit version during version comparisons","fromName":"Pat Thoyts","fromEmail":"patthoyts@users.sourceforge.net","sentAt":"2009-05-18T21:46:01Z","receivedAt":"2009-05-18T21:46:01Z","isPatch":true,"sender":{"key":"patthoyts@users.sourceforge.net","avatar":"https://avatars.githubusercontent.com/u/30739?v=4"},"body":"\n msysGit generates version strings with text appended which cannot\n be used with vcompare. Limit git_version to the first three digits\n which are the real git version.\n\nSigned-off-by: Pat Thoyts \n---\n gitk | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 0804e6e..1855390 100755\n--- a/gitk\n+++ b/gitk\n@@ -11152,7 +11152,7 @@ set nullid2 \"0000000000000000000000000000000000000001\"\n set nullfile \"/dev/null\"\n \n set have_tk85 [expr {[package vcompare $tk_version \"8.5\"] >= 0}]\n-set git_version [lindex [exec git version] end]\n+set git_version [join [lrange [split [lindex [exec git version] end] .] 0 2] .]\n \n set runq {}\n set history {}\n-- \n1.6.3.msysgit.0\n"},{"id":"114206","messageId":"18961.59382.839207.898823@cargo.ozlabs.ibm.com","threadId":"19408","inReplyTo":"87hbzirso6.fsf@users.sourceforge.net","subject":"Re: [PATCH] gitk: Handle msysGit version during version comparisons","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2009-05-18T22:57:58Z","receivedAt":"2009-05-18T22:57:58Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Pat Thoyts writes:\n\n> msysGit generates version strings with text appended which cannot\n> be used with vcompare. Limit git_version to the first three digits\n> which are the real git version.\n\nThanks, applied.\n\nPaul.\n"},{"id":"114242","messageId":"alpine.DEB.1.00.0905191043320.26154@pacific.mpi-cbg.de","threadId":"19408","inReplyTo":"87hbzirso6.fsf@users.sourceforge.net","subject":"Re: [PATCH] gitk: Handle msysGit version during version comparisons","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-05-19T08:43:51Z","receivedAt":"2009-05-19T08:43:51Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 18 May 2009, Pat Thoyts wrote:\n\n> \n> msysGit generates version strings with text appended which cannot\n> be used with vcompare. Limit git_version to the first three digits\n> which are the real git version.\n> \n> Signed-off-by: Pat Thoyts \n\nIs that indent intentional?\n\nCiao,\nDscho\n"},{"id":"114244","messageId":"4A127306.6040904@drmicha.warpmail.net","threadId":"19408","inReplyTo":"alpine.DEB.1.00.0905191043320.26154@pacific.mpi-cbg.de","subject":"Re: [PATCH] gitk: Handle msysGit version during version comparisons","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2009-05-19T08:51:18Z","receivedAt":"2009-05-19T08:51:18Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Johannes Schindelin venit, vidit, dixit 19.05.2009 10:43:\n> Hi,\n> \n> On Mon, 18 May 2009, Pat Thoyts wrote:\n> \n>>\n>> msysGit generates version strings with text appended which cannot\n>> be used with vcompare. Limit git_version to the first three digits\n>> which are the real git version.\n>>\n>> Signed-off-by: Pat Thoyts \n> \n> Is that indent intentional?\n> \n> Ciao,\n> Dscho\n\nIt is clearly indentional :)\n\n[During my git beginnings, the standard output format of git log made me\nbelieve I should format commit message bodies like that, too.]\n\nMichael\n"},{"id":"114250","messageId":"877i0ds7hr.fsf@users.sourceforge.net","threadId":"19408","inReplyTo":"4A127306.6040904@drmicha.warpmail.net","subject":"Re: [PATCH] gitk: Handle msysGit version during version comparisons","fromName":"Pat Thoyts","fromEmail":"patthoyts@users.sourceforge.net","sentAt":"2009-05-19T10:38:08Z","receivedAt":"2009-05-19T10:38:08Z","isPatch":true,"sender":{"key":"patthoyts@users.sourceforge.net","avatar":"https://avatars.githubusercontent.com/u/30739?v=4"},"body":"Michael J Gruber writes:\n\n>Johannes Schindelin venit, vidit, dixit 19.05.2009 10:43:\n>> Hi,\n>> \n>> On Mon, 18 May 2009, Pat Thoyts wrote:\n>> \n>>>\n>>> msysGit generates version strings with text appended which cannot\n>>> be used with vcompare. Limit git_version to the first three digits\n>>> which are the real git version.\n>>>\n>>> Signed-off-by: Pat Thoyts \n>> \n>> Is that indent intentional?\n>> \n>> Ciao,\n>> Dscho\n>\n>It is clearly indentional :)\n>\n>[During my git beginnings, the standard output format of git log made me\n>believe I should format commit message bodies like that, too.]\n\nIt was intentional and the above followup is why. Evidently I should\nnot do so in the future.\n\n-- \nPat Thoyts http://www.patthoyts.tk/\nPGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD\n"}]}