{"thread":{"id":"1937","subject":"Re: [ANNOUNCE qgit-0.95]","startedAt":"2005-09-25T05:52:59Z","lastAt":"2005-09-25T19:19:29Z","messageCount":2,"participants":["Marco Costalba","Josef Weidendorfer"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"9250","messageId":"20050925055259.50066.qmail@web26302.mail.ukl.yahoo.com","threadId":"1937","inReplyTo":null,"subject":"Re: [ANNOUNCE qgit-0.95]","fromName":"Marco Costalba","fromEmail":"mcostalba@yahoo.it","sentAt":"2005-09-25T05:52:59Z","receivedAt":"2005-09-25T05:52:59Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"Petr Baudis wrote:\n\n>\n>Yes, it is several times faster than gitk, good work. Had to do this in\n>order to be able to compile it with gcc-3.3.6, though (it complained\n>about goto'ing after initialization of nc - that's bogus since there's\n>the return, but...):\n\n\nthanks, applied.\n\n>\n>Besides that, this is what I don't like about qgit:\n>\n>* It'd be nice to be able to choose to see all commits in the initial\n>dialog by single click (I know about --all). Perhaps a radio buttons\n>choosing between all and selected? Also, you might add the \"diff against\n>working copy\" option to that dialog as well.\n\nYes.\n\n>\n>* The graph column is too narrow. It should be auto-sized so that the\n>graph fits in, or at least there should be some clear indication that\n>the graph does not fit to the column at the given point. This confused\n>me a lot at first.\n\nAuto fit the column width to the graph can be not always the best choice, see\n0572e3da3ff5c3744b2f606ecf296d5f89a4bbdf (aka Linux v2.6.13-rc7) commit to see what I mean.\n\nBut an inidcation that the graph column is resizable is a good thing.\n\n>\n>* Could you make the grey background for odd commits span to the whole\n>line, including the commit graph?\n>\n\nYes, I am not sure of the results, there are already a lot of colors in the graphs, but I will\ncheck.\n\n\n>* The commit time is relative to now, which makes no sense to me. Also,\n>it is in the second column instead of the last one like in gitk, which\n>seems better to me. At least, the column is too narrow and then it\n>blends together with the commit title.\n>\n\nI took the layout from gitweb where the order is -relative time - author - short log.\nBut this is the second time someone complains about time column so I will\nsend to last column: graph - shortlog - author - time\n\n\n>* In the filter radio buttons groups, only first few letters of the\n>labels are visible, and apparently no tooltips.\n\nYes. I will choose the tooltips way to save space, that line its already too long, this is\nthe reason I try to avoid adding buttons.\n\n> Same problem in the\n>settings dialog, most of the options have the labels cut around 2/3, and\n>the window is non-resizable on top of that - why? I hate non-resizable\n>windows, especially because they are usually too small. :-)\n>\n\nThis is strange, I have resizable setting window and no cutted labels.......\nThis is for sure a bug but I can't reproduce on my box.\n\n>* Single-clicking at a commit produces a significantly slower response\n>than in gitk, where I see the difflist and stuff nearly instantly - it\n>takes several hundreds of ms in qgit. That's quite annoying.\n>\n\nPlease, is flag edit->settings->general->'load file names in background' set?\n\n\n>* Getting to the diff view was non-obvious for me. It'd be nice to have\n>some [diff] button as well somewhere. Or you could also show the diff in\n>the bottom part of screen in the commit view, I think gitk solved this\n>nicely.\n\nI have tought a lot how to pass to the user the information that to see a diff you have to \ndouble click on the commit:\n\n1) Adding a button with a 'double click' tooltip? --> use space forever for a one time\n    information (once you know you can double click the button is useless, the space not).\n\n2) Adding a menu entry with a tool tip? can be.\n\n3) Add a tool tip directly on the commit line: can became annoying really soon.\n\n4) Show always diff in commit info window? can be time consuming for merges (gitk doesn't shows\nmerges diff) and the space is limited or you need to resize forth and then back the commit info\nwindow. Perpahs it's only me, but I need the whole screen to go deep in a diff when I really need\nto understand the change.\n\nIn any case you are right, something has to be made.\n\n>\n>* Clicking on the file was supposed to bring some annotated view, but if\n>it is so, it should write \"Annotate\" in the window title, and should\n>indicate that it is computing it on the background (and is really slow\n>in that, or I don't know, but always only single revision was shown\n>there). It is unclear what the \"pin file\" checkbox is supposed to mean,\n>and the whole dialog is just very confusing. :-)\n>\n\nYes annotate can be slow with linux tree with some vip files ;-)\n\nPlease try with a small project or with a seldom\ntouched file: annotation should appear left aligned.\n\nAn example can be file daemon.c in git archive, you can reach \nfrom commit f8ff0c0641a14770a2214fffbd4271b1ea3a0d61\n\nWhen you browse the file history list on top, the corresponding main view  \ncommit changes as does the file revision content: \"pin file\" checkbox simply avoids \nthe file viewer content to change, only main view is updated.\n\nThis can be useful when you double click on the left align annotation number to jump to commit,\npreserving the file view.\n\n\n>* The lane information might be available as a tooltip in addition to\n>right-clicking on it - that wouldn't occur to me.\n>\n\nYes...now I see its also a little bit broken....bad luck ;-)\n\n\n>* Why is the Edit menu aligned to the right?\n>\n\nIs it? really? I cannot reproduce, Its the only menu without shortcuts, but \nis correctly aligned here.\n\n>* Well - I don't like the line graphics and prefer gitk's. This is\n>perhaps a matter of taste, though. I find the graphics to be too tiny,\n>thin and not so clear as gitk's, which makes it harder to see the commit\n>flow. I also like diagonal lines more than angles, but that might be\n>just because I'm used to them.\n>\n\nDiagonal line could be nicer but doesn't leave you play some tricks to greatly speed up\ngraph drawing. I really like those tricks ;-)\n\nThen when the things get tough, with a lot of lines, the more 'regular' and geometrical\nlayout of qgit could help...but this is just a matter of taste.\n\n>\n>\n>Nice work otherwise. :-)\n>\n\nThanks for your very good feedback.\n\n\n\n__________________________________________________\nDo You Yahoo!?\nTired of spam?  Yahoo! Mail has the best spam protection around \nhttp://mail.yahoo.com \n"},{"id":"9271","messageId":"200509252119.29306.Josef.Weidendorfer@gmx.de","threadId":"1937","inReplyTo":"20050925055259.50066.qmail@web26302.mail.ukl.yahoo.com","subject":"Re: [ANNOUNCE qgit-0.95]","fromName":"Josef Weidendorfer","fromEmail":"josef.weidendorfer@gmx.de","sentAt":"2005-09-25T19:19:29Z","receivedAt":"2005-09-25T19:19:29Z","isPatch":false,"sender":{"key":"josef.weidendorfer@gmx.de","avatar":null},"body":"Hi,\n\nOn Sunday 25 September 2005 07:52, Marco Costalba wrote:\n> >* The commit time is relative to now, which makes no sense to me. Also,\n> >it is in the second column instead of the last one like in gitk, which\n> >seems better to me. At least, the column is too narrow and then it\n> >blends together with the commit title.\n\nI vote for absolute time, and the date column at the end, too.\nRelative has no meaning when searching for an old commit.\nBesides, QT allows to reorder the columns with the mouse (the order should be\nsaved in a config file at end to be persistant over program runs).\n\n> >* Getting to the diff view was non-obvious for me. It'd be nice to have\n> >some [diff] button as well somewhere. Or you could also show the diff in\n> >the bottom part of screen in the commit view, I think gitk solved this\n> >nicely.\n>\n> I have tought a lot how to pass to the user the information that to see a\n> diff you have to double click on the commit:\n\nI like the gitk solution better. \nWhat about making the commit list a QDockWindow, which can be docked to either \nside of the window (default: top as currently), but also made a floating \nwindow, so that the commit diff gets the whole main window?\n\n> commit changes as does the file revision content: \"pin file\" checkbox\n> simply avoids the file viewer content to change, only main view is updated.\n\nThe \"pin\" action is really not-obvious. Why not open new windows for different\nfile annotations? Or one window with tabs for each file?\nPerhaps make the main window contain commit diffs and file annotations in \ntabs?\n\n> Diagonal line could be nicer but doesn't leave you play some tricks to\n> greatly speed up graph drawing. I really like those tricks ;-)\n\nI think that diagonal lines as in gitk make it way easier to get an overview.\nWhat makes drawing of diagonal lines slow?\nIt should be quite fast to subclass QListViewItem for commit entries and\noverwrite QListViewItem::paintCell to use your own drawing; paintCell is \ncalled for visible entries only.\n\nAnother wish: The tag/head markers in gitk are really good. In qgit, I only \nget another background color, and miss the name.\nYou can do the same drawing as in gitk via paintCell, too.\n\n> >Nice work otherwise. :-)\n\nYes, really nice.\n\nJosef\n"}]}