{"thread":{"id":"19349","subject":"[PATCH] Use UTF-8 instead of utf8 for backward compatibility","startedAt":"2009-05-14T13:05:55Z","lastAt":"2009-05-16T07:15:19Z","messageCount":2,"participants":["Alex Riesen","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"113926","messageId":"81b0412b0905140605o21143369ibc3147c6619c7845@mail.gmail.com","threadId":"19349","inReplyTo":null,"subject":"[PATCH] Use UTF-8 instead of utf8 for backward compatibility","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2009-05-14T13:05:55Z","receivedAt":"2009-05-14T13:05:55Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"An old iconv (GNU libiconv 1.11) does not know about utf8, it does know\nUTF-8 though, which is also understood by all newer iconv implementations.\n\nSigned-off-by: Alex Riesen <raa.lkml@gmail.com>\n---\n\n2009/5/12 Junio C Hamano <gitster@pobox.com>:\n> --- a/t/t3900-i18n-commit.sh\n> +++ b/t/t3900-i18n-commit.sh\n> @@ -9,7 +9,15 @@ test_description='commit and log output encodings'\n>\n>  compare_with () {\n>        git show -s $1 | sed -e '1,/^$/d' -e 's/^    //' >current &&\n> -       test_cmp current \"$2\"\n> +       case \"$3\" in\n> +       '')\n> +               test_cmp \"$2\" current ;;\n> +       ?*)\n> +               iconv -f \"$3\" -t utf8 >current.utf8 <current &&\n> +               iconv -f \"$3\" -t utf8 >expect.utf8 <\"$2\" &&\n\nI happen to have an old one (Cygwin):\n$ iconv --version\niconv (GNU libiconv 1.11)\n\n t/t3900-i18n-commit.sh |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t3900-i18n-commit.sh b/t/t3900-i18n-commit.sh\nindex 5dbbcb6..b4ec2b5 100755\n--- a/t/t3900-i18n-commit.sh\n+++ b/t/t3900-i18n-commit.sh\n@@ -13,8 +13,8 @@ compare_with () {\n \t'')\n \t\ttest_cmp \"$2\" current ;;\n \t?*)\n-\t\ticonv -f \"$3\" -t utf8 >current.utf8 <current &&\n-\t\ticonv -f \"$3\" -t utf8 >expect.utf8 <\"$2\" &&\n+\t\ticonv -f \"$3\" -t UTF-8 >current.utf8 <current &&\n+\t\ticonv -f \"$3\" -t UTF-8 >expect.utf8 <\"$2\" &&\n \t\ttest_cmp expect.utf8 current.utf8\n \t\t;;\n \tesac\n-- \n1.6.3.49.ge312c\n\n\nFrom bb9dd160d93cb6753ab08dbc29c6ee840cfd06bc Mon Sep 17 00:00:00 2001\nFrom: Alex Riesen <raa.lkml@gmail.com>\nDate: Thu, 14 May 2009 14:55:54 +0200\nSubject: [PATCH] Use UTF-8 instead of utf8 for backward compatibility\n\nAn old iconv (GNU libiconv 1.11) does not know about utf8, it does know\nUTF-8 though, which is also understood by all newer iconv implementations.\n\nSigned-off-by: Alex Riesen <raa.lkml@gmail.com>\n---\n t/t3900-i18n-commit.sh |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t3900-i18n-commit.sh b/t/t3900-i18n-commit.sh\nindex 5dbbcb6..b4ec2b5 100755\n--- a/t/t3900-i18n-commit.sh\n+++ b/t/t3900-i18n-commit.sh\n@@ -13,8 +13,8 @@ compare_with () {\n \t'')\n \t\ttest_cmp \"$2\" current ;;\n \t?*)\n-\t\ticonv -f \"$3\" -t utf8 >current.utf8 <current &&\n-\t\ticonv -f \"$3\" -t utf8 >expect.utf8 <\"$2\" &&\n+\t\ticonv -f \"$3\" -t UTF-8 >current.utf8 <current &&\n+\t\ticonv -f \"$3\" -t UTF-8 >expect.utf8 <\"$2\" &&\n \t\ttest_cmp expect.utf8 current.utf8\n \t\t;;\n \tesac\n-- \n1.6.3.49.ge312c\n\n"},{"id":"114078","messageId":"7vbpptplh4.fsf@alter.siamese.dyndns.org","threadId":"19349","inReplyTo":"81b0412b0905140605o21143369ibc3147c6619c7845@mail.gmail.com","subject":"Re: [PATCH] Use UTF-8 instead of utf8 for backward compatibility","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-05-16T07:15:19Z","receivedAt":"2009-05-16T07:15:19Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alex Riesen <raa.lkml@gmail.com> writes:\n\n> An old iconv (GNU libiconv 1.11) does not know about utf8, it does know\n> UTF-8 though, which is also understood by all newer iconv implementations.\n\nThanks.  Very much appreciated.\n"}]}