{"thread":{"id":"1932","subject":"The latest commit to add new keybindings","startedAt":"2005-09-24T01:31:20Z","lastAt":"2005-09-26T22:30:54Z","messageCount":4,"participants":["Junio C Hamano","Paul Mackerras","H. Peter Anvin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"9214","messageId":"7v4q8b8d5j.fsf@assigned-by-dhcp.cox.net","threadId":"1932","inReplyTo":null,"subject":"The latest commit to add new keybindings","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-09-24T01:31:20Z","receivedAt":"2005-09-24T01:31:20Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Paul, I was looking at the gitk repository thinking it's about\ntime for me to slurp your changes in, and have two questions.\n\nThe 'new keybindings' commit from Robert Suetterlin changes the\nbeginning of gitk to:\n\n        --- a/gitk\n        +++ b/gitk\n        @@ -1,6 +1,6 @@\n         #!/bin/sh\n         # Tcl ignores the next line -*- tcl -*- \\\n        -exec wish \"$0\" -- \"${1+$@}\"\n        +exec wish8.4 \"$0\" -- \"${1+$@}\"\n\nDo you actually require 8.4, or any reasonably recent wish would\ndo?  The reason I ask is that Debian side (debian/control)\nexplicitly depends on 'tk8.4' but RPM side (git-core.spec.in)\njust says 'tk'.  I could change the RPM side to also require 8.4\nbut I do not have ready access to any RPM machine to test it\nwith, so if that is not needed I'd rather not touch spec.in\nfile.\n\nAnother thing, which is unrelated to Robert's change, is that I\nsuspect the exec command line should be like either one of these\n(the first one is probably more old-fashioned):\n\n\texec wish \"$0\" -- ${1+\"$@\"}\n\texec wish \"$0\" -- \"$@\"\n\nWith \"${1+$@}\", you are passing an empty parameter after '--'\nwhen gitk itself receives no parameter.  Maybe it is intended,\nmaybe not...\n\nprompt$ cat >one.sh <<\\EOF\n#!/bin/sh\nexec ./two.sh \"$0\" -- \"${1+$@}\"\nEOF\nprompt$ cat >two.sh <<\\EOF\n#!/bin/sh\necho \"\\$0 is $0\"\necho \"\\$# is $#\"\ni=1\nfor a\ndo\n\techo \"\\$$i is $a\"\n\ti=`expr $i + 1`\ndone\nEOF\nprompt$ chmod +x one.sh two.sh\nprompt$ ./one.sh foo\n$0 is /var/tmp/gomi/two.sh\n$# is 3\n$1 is <./one.sh>\n$2 is <-->\n$3 is <foo>\nprompt$ ./one.sh\n$0 is /var/tmp/gomi/two.sh\n$# is 3\n$1 is <./one.sh>\n$2 is <-->\n$3 is <>\nprompt$ exit\n"},{"id":"9289","messageId":"17207.16457.551775.470665@cargo.ozlabs.ibm.com","threadId":"1932","inReplyTo":"7v4q8b8d5j.fsf@assigned-by-dhcp.cox.net","subject":"Re: The latest commit to add new keybindings","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2005-09-26T00:26:49Z","receivedAt":"2005-09-26T00:26:49Z","isPatch":false,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Junio C Hamano writes:\n\n> Do you actually require 8.4, or any reasonably recent wish would\n> do?\n\nChecking in the change from \"wish\" to \"wish8.4\" was a mistake - that\nwas a change I made for some tests, and I forgot to change it back.\nHowever, gitk does need tk 8.4 or later, since it uses the panedwindow\nwidget, which tk 8.3 doesn't have.  I have tk8.5a2 installed here,\nwhich is nice because it does antialiased fonts, although it is a bit\nslower (clock format is much slower because they changed it from being\nimplemented in C to Tcl).\n\n> With \"${1+$@}\", you are passing an empty parameter after '--'\n> when gitk itself receives no parameter.  Maybe it is intended,\n> maybe not...\n\nNo, it isn't intended, thanks for pointing that out.\n\nRegards,\nPaul.\n"},{"id":"9336","messageId":"43387087.60708@zytor.com","threadId":"1932","inReplyTo":"17207.16457.551775.470665@cargo.ozlabs.ibm.com","subject":"Re: The latest commit to add new keybindings","fromName":"H. Peter Anvin","fromEmail":"hpa@zytor.com","sentAt":"2005-09-26T22:04:55Z","receivedAt":"2005-09-26T22:04:55Z","isPatch":false,"sender":{"key":"hpa@zytor.com","avatar":null},"body":"Paul Mackerras wrote:\n> Junio C Hamano writes:\n> \n> \n>>Do you actually require 8.4, or any reasonably recent wish would\n>>do?\n> \n> \n> Checking in the change from \"wish\" to \"wish8.4\" was a mistake - that\n> was a change I made for some tests, and I forgot to change it back.\n> However, gitk does need tk 8.4 or later, since it uses the panedwindow\n> widget, which tk 8.3 doesn't have.  I have tk8.5a2 installed here,\n> which is nice because it does antialiased fonts, although it is a bit\n> slower (clock format is much slower because they changed it from being\n> implemented in C to Tcl).\n> \n\nIt would be good if the dependency then said tk >= 8.4.\n\n\t-hpa\n"},{"id":"9343","messageId":"7vek7ba2ch.fsf@assigned-by-dhcp.cox.net","threadId":"1932","inReplyTo":"43387087.60708@zytor.com","subject":"Re: The latest commit to add new keybindings","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-09-26T22:30:54Z","receivedAt":"2005-09-26T22:30:54Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"H. Peter Anvin\" <hpa@zytor.com> writes:\n\n> It would be good if the dependency then said tk >= 8.4.\n\nAgreed.  Will do tonight.\n"}]}