{"thread":{"id":"19306","subject":"Re: [JGIT PATCH] Fix data corruption in DirCacheIterator when EmptyTreeIterator is used","startedAt":"2009-05-12T00:04:06Z","lastAt":"2009-05-12T00:04:06Z","messageCount":1,"participants":["Mark Struberg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"113605","messageId":"5323.360.qm@web27801.mail.ukl.yahoo.com","threadId":"19306","inReplyTo":null,"subject":"Re: [JGIT PATCH] Fix data corruption in DirCacheIterator when EmptyTreeIterator is used","fromName":"Mark Struberg","fromEmail":"struberg@yahoo.de","sentAt":"2009-05-12T00:04:06Z","receivedAt":"2009-05-12T00:04:06Z","isPatch":true,"sender":{"key":"struberg@yahoo.de","avatar":"https://gravatar.com/avatar/119742c3e8dbc8db35a92bdff0581aec8d364d415f770e60431cba262daa974f?d=mp&s=160"},"body":"\nPatch tested, jgit status now works on a repo which previously caused the out of bounds exception.\n\ntxs and LieGrue,\nstrub\n\n--- Shawn O. Pearce <spearce@spearce.org> schrieb am Mo, 11.5.2009:\n\n> Von: Shawn O. Pearce <spearce@spearce.org>\n> Betreff: Re: [JGIT PATCH] Fix data corruption in DirCacheIterator when EmptyTreeIterator is used\n> An: \"Robin Rosenberg\" <robin.rosenberg.lists@dewire.com>\n> CC: \"Mark Struberg\" <struberg@yahoo.de>, git@vger.kernel.org\n> Datum: Montag, 11. Mai 2009, 21:44\n> Robin Rosenberg <robin.rosenberg.lists@dewire.com>\n> wrote:\n> > \n> > Shouldn't we update some unit tests too? The dircache\n> must be reliable.\n> \n> I see you ignored the remark I put in the cover letter\n> below the ---.\n> \n> I think we should have unit tests too.  I just can't\n> come up with\n> a way test the fix to prevent regression.  And I don't\n> have any\n> more time for it probably the rest of this week.  I'd\n> rather have\n> the corruption fix in the tree with no test than continue\n> to have\n> surprising corruption under certain cases.  But if you\n> or Mark can\n> offer a test, I'd love to have it.\n> \n> -- \n> Shawn.\n> --\n> To unsubscribe from this list: send the line \"unsubscribe\n> git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n> \n\n\n      \n"}]}