{"thread":{"id":"19274","subject":"[PATCH] http-push: fix missing \"#ifdef USE_CURL_MULTI\" around \"is_running_queue\"","startedAt":"2009-05-10T16:44:30Z","lastAt":"2009-05-12T04:25:07Z","messageCount":3,"participants":["Christian Couder","Tay Ray Chuan"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"113469","messageId":"20090510164431.3526.47427.chriscool@tuxfamily.org","threadId":"19274","inReplyTo":null,"subject":"[PATCH] http-push: fix missing \"#ifdef USE_CURL_MULTI\" around \"is_running_queue\"","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2009-05-10T16:44:30Z","receivedAt":"2009-05-10T16:44:30Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"As it is breaking the build when USE_CURL_MULTI is not defined.\n\nSigned-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n http-push.c |    2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\nThis patch applies to pu.\n\ndiff --git a/http-push.c b/http-push.c\nindex ef1a9f3..14f3996 100644\n--- a/http-push.c\n+++ b/http-push.c\n@@ -2291,7 +2291,9 @@ int main(int argc, char **argv)\n \t\trepo->url = rewritten_url;\n \t}\n \n+#ifdef USE_CURL_MULTI\n \tis_running_queue = 0;\n+#endif\n \n \t/* Verify DAV compliance/lock support */\n \tif (!locking_available()) {\n-- \n1.6.3.rc1.112.g17e25\n"},{"id":"113535","messageId":"be6fef0d0905110525p7e7072d3y18f5c99b782c9bf9@mail.gmail.com","threadId":"19274","inReplyTo":"20090510164431.3526.47427.chriscool@tuxfamily.org","subject":"Re: [PATCH] http-push: fix missing \"#ifdef USE_CURL_MULTI\" around \"is_running_queue\"","fromName":"Tay Ray Chuan","fromEmail":"rctay89@gmail.com","sentAt":"2009-05-11T12:25:05Z","receivedAt":"2009-05-11T12:25:05Z","isPatch":true,"sender":{"key":"rctay89@gmail.com","avatar":"https://avatars.githubusercontent.com/u/61553?v=4"},"body":"Hi,\n\nOn Mon, May 11, 2009 at 12:44 AM, Christian Couder\n<chriscool@tuxfamily.org> wrote:\n> As it is breaking the build when USE_CURL_MULTI is not defined.\n\nthanks for catching this. By the way, how did you catch this? Are you\nbuilding without USE_CURL_MULTI defined?\n\n-- \nCheers,\nRay Chuan\n"},{"id":"113609","messageId":"200905120625.07383.chriscool@tuxfamily.org","threadId":"19274","inReplyTo":"be6fef0d0905110525p7e7072d3y18f5c99b782c9bf9@mail.gmail.com","subject":"Re: [PATCH] http-push: fix missing \"#ifdef USE_CURL_MULTI\" around \"is_running_queue\"","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2009-05-12T04:25:07Z","receivedAt":"2009-05-12T04:25:07Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Hi,\n\nLe lundi 11 mai 2009, Tay Ray Chuan a écrit :\n> Hi,\n>\n> On Mon, May 11, 2009 at 12:44 AM, Christian Couder\n>\n> <chriscool@tuxfamily.org> wrote:\n> > As it is breaking the build when USE_CURL_MULTI is not defined.\n>\n> thanks for catching this. By the way, how did you catch this? Are you\n> building without USE_CURL_MULTI defined?\n\nMy main development box still runs an old Kubuntu Feisty (7.04). It\nhas some libcurl3 packages version 7.15.5-1ubuntu2.\n\nIn \"/usr/include/curl/curlver.h\", I have:\n\n#define LIBCURL_VERSION_NUM 0x070f05\n\nand in \"http.h\" there is:\n\n#if LIBCURL_VERSION_NUM >= 0x071000\n#define USE_CURL_MULTI\n#define DEFAULT_MAX_REQUESTS 5\n#endif\n\nso yes, I think USE_CURL_MULTI is not defined on my box and that's why\nthe build failed on it.\n\nRegards,\nChristian.\n"}]}