{"thread":{"id":"19269","subject":"[PATCH QGit] Immediately evaluate the ProgramFiles environment variable","startedAt":"2009-05-10T09:53:45Z","lastAt":"2009-05-10T12:09:02Z","messageCount":2,"participants":["Markus Heidelberg","Marco Costalba"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"113454","messageId":"1241949225-10046-1-git-send-email-markus.heidelberg@web.de","threadId":"19269","inReplyTo":null,"subject":"[PATCH QGit] Immediately evaluate the ProgramFiles environment variable","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-05-10T09:53:45Z","receivedAt":"2009-05-10T09:53:45Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"Commit 50d839b (Don't hardcode GIT_EXEC_DIR for Windows so much,\n2009-04-18) broke 'make install' on Windows. Somehow the current working\ndirectory was prepended to the install path given with target.path, when\n$(ProgramFiles) should be evaluated during the call of 'make'.\nThis seems to be a qmake bug with generating the Makefile.\n\nSigned-off-by: Markus Heidelberg <markus.heidelberg@web.de>\n---\n\nFor clarification:\n$ cd C:\\projects\\qgit4\\src\n$ qmake src.pro -win32 -o Makefile\n\nNow the install_target and uninstall_target targets in Makefile.{Debug,Release}\nare wrong, for example\n\nuninstall_target:  FORCE\n\t-$(DEL_FILE) \"c:$(INSTALL_ROOT)\\projects\\qgit\\src\\$(ProgramFiles)\\Git\\bin\\$(TARGET)\"\n\t-$(DEL_DIR) $(INSTALL_ROOT)\"c:\\projects\\qgit\\src\\$(ProgramFiles)\\Git\\bin\\\" \n\ninstead of\n\nuninstall_target:  FORCE\n\t-$(DEL_FILE) \"c:$(INSTALL_ROOT)\\Programme\\Git\\bin\\$(TARGET)\"\n\t-$(DEL_DIR) c:$(INSTALL_ROOT)\\Programme\\Git\\bin \n\nHmm, seems as if there is another bug:\n$(INSTALL_ROOT)\"c:  vs.  c:$(INSTALL_ROOT)\n\nSorry for this and for noticing it just a bit too late. I haven't called 'make\ninstall' before.\n\n src/src.pro |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/src/src.pro b/src/src.pro\nindex 619a9a8..133e64c 100644\n--- a/src/src.pro\n+++ b/src/src.pro\n@@ -1,6 +1,6 @@\n # Under Windows launch script start_qgit.bat needs the\n # value GIT_EXEC_DIR to be set to the git bin directory\n-GIT_EXEC_DIR = \"$(ProgramFiles)\\\\Git\\\\bin\"\n+GIT_EXEC_DIR = \"$$(ProgramFiles)\\\\Git\\\\bin\"\n \n # Under Windows uncomment following line to enable console messages\n #CONFIG += ENABLE_CONSOLE_MSG\n-- \n1.6.3.20.g687dc\n"},{"id":"113458","messageId":"e5bfff550905100509s656caf34u528307a2d629c06b@mail.gmail.com","threadId":"19269","inReplyTo":"1241949225-10046-1-git-send-email-markus.heidelberg@web.de","subject":"Re: [PATCH QGit] Immediately evaluate the ProgramFiles environment variable","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2009-05-10T12:09:02Z","receivedAt":"2009-05-10T12:09:02Z","isPatch":true,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On Sun, May 10, 2009 at 11:53, Markus Heidelberg\n<markus.heidelberg@web.de> wrote:\n> Commit 50d839b (Don't hardcode GIT_EXEC_DIR for Windows so much,\n> 2009-04-18) broke 'make install' on Windows. Somehow the current working\n> directory was prepended to the install path given with target.path, when\n> $(ProgramFiles) should be evaluated during the call of 'make'.\n> This seems to be a qmake bug with generating the Makefile.\n>\n> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>\n> ---\n\nThanks, patch applied and pushed.\n"}]}