{"thread":{"id":"19210","subject":"[RFC/PATCH] Prettify log decorations even more","startedAt":"2009-05-06T22:45:48Z","lastAt":"2009-05-08T07:49:41Z","messageCount":3,"participants":["Felipe Contreras","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"113137","messageId":"1241649948-11765-1-git-send-email-felipe.contreras@gmail.com","threadId":"19210","inReplyTo":null,"subject":"[RFC/PATCH] Prettify log decorations even more","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2009-05-06T22:45:48Z","receivedAt":"2009-05-06T22:45:48Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"\"tag: v1.6.2.5\" looks much better than \"tag: refs/tags/v1.6.2.5\".\n\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n log-tree.c |    1 +\n refs.c     |    3 +--\n refs.h     |    3 ++-\n 3 files changed, 4 insertions(+), 3 deletions(-)\n\ndiff --git a/log-tree.c b/log-tree.c\nindex 5bd29e6..59d63eb 100644\n--- a/log-tree.c\n+++ b/log-tree.c\n@@ -25,6 +25,7 @@ static int add_ref_decoration(const char *refname, const unsigned char *sha1, in\n \tstruct object *obj = parse_object(sha1);\n \tif (!obj)\n \t\treturn 0;\n+\trefname = prettify_refname(refname);\n \tadd_name_decoration(\"\", refname, obj);\n \twhile (obj->type == OBJ_TAG) {\n \t\tobj = ((struct tag *)obj)->tagged;\ndiff --git a/refs.c b/refs.c\nindex e65a3b4..e74461e 100644\n--- a/refs.c\n+++ b/refs.c\n@@ -750,9 +750,8 @@ int check_ref_format(const char *ref)\n \t}\n }\n \n-const char *prettify_ref(const struct ref *ref)\n+const char *prettify_refname(const char *name)\n {\n-\tconst char *name = ref->name;\n \treturn name + (\n \t\t!prefixcmp(name, \"refs/heads/\") ? 11 :\n \t\t!prefixcmp(name, \"refs/tags/\") ? 10 :\ndiff --git a/refs.h b/refs.h\nindex 29d17a4..3de5e1c 100644\n--- a/refs.h\n+++ b/refs.h\n@@ -80,7 +80,8 @@ extern int for_each_reflog(each_ref_fn, void *);\n #define CHECK_REF_FORMAT_WILDCARD (-3)\n extern int check_ref_format(const char *target);\n \n-extern const char *prettify_ref(const struct ref *ref);\n+extern const char *prettify_refname(const char *refname);\n+#define prettify_ref(ref) prettify_refname((ref)->name)\n extern char *shorten_unambiguous_ref(const char *ref, int strict);\n \n /** rename ref, return 0 on success **/\n-- \n1.6.3.rc4.14.g96da.dirty\n"},{"id":"113317","messageId":"20090508074507.GF12989@coredump.intra.peff.net","threadId":"19210","inReplyTo":"1241649948-11765-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [RFC/PATCH] Prettify log decorations even more","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2009-05-08T07:45:07Z","receivedAt":"2009-05-08T07:45:07Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, May 07, 2009 at 01:45:48AM +0300, Felipe Contreras wrote:\n\n> -extern const char *prettify_ref(const struct ref *ref);\n> +extern const char *prettify_refname(const char *refname);\n> +#define prettify_ref(ref) prettify_refname((ref)->name)\n\nI think it is an improvement for this function to take just the name,\nbut I don't see much point in keeping the crufty #define compatibility.\nI would just fix up the few callers, as it really is just\ns/ref/ref->name/.\n\n-Peff\n"},{"id":"113319","messageId":"94a0d4530905080049g28b7aaafn3b8137341c2948dd@mail.gmail.com","threadId":"19210","inReplyTo":"20090508074507.GF12989@coredump.intra.peff.net","subject":"Re: [RFC/PATCH] Prettify log decorations even more","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2009-05-08T07:49:41Z","receivedAt":"2009-05-08T07:49:41Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Fri, May 8, 2009 at 10:45 AM, Jeff King <peff@peff.net> wrote:\n> On Thu, May 07, 2009 at 01:45:48AM +0300, Felipe Contreras wrote:\n>\n>> -extern const char *prettify_ref(const struct ref *ref);\n>> +extern const char *prettify_refname(const char *refname);\n>> +#define prettify_ref(ref) prettify_refname((ref)->name)\n>\n> I think it is an improvement for this function to take just the name,\n> but I don't see much point in keeping the crufty #define compatibility.\n> I would just fix up the few callers, as it really is just\n> s/ref/ref->name/.\n\nGood, I started doing that but I thought it would create a big diff\nand perhaps it was best to send some RFC before.\n\nWill do that.\n\n-- \nFelipe Contreras\n"}]}