{"thread":{"id":"19200","subject":"[BUG] git config: cygwin git version 1.6.1.2 does not deletes empty sections","startedAt":"2009-05-06T15:50:43Z","lastAt":"2009-05-06T20:43:27Z","messageCount":4,"participants":["Constantine Plotnikov","Erik Faye-Lund","Michał Kiedrowicz"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"113091","messageId":"85647ef50905060850t2e6c2051jfa6d3596b680cc74@mail.gmail.com","threadId":"19200","inReplyTo":null,"subject":"[BUG] git config: cygwin git version 1.6.1.2 does not deletes empty sections","fromName":"Constantine Plotnikov","fromEmail":"constantine.plotnikov@gmail.com","sentAt":"2009-05-06T15:50:43Z","receivedAt":"2009-05-06T15:50:43Z","isPatch":false,"sender":{"key":"constantine.plotnikov@gmail.com","avatar":null},"body":"I have encountered a bug related to git config in cygwin git version 1.6.1.2\n\nThe git config --unset might leave an empty section when the last\nproperty is deleted. But consequent \"git config key value\" does not\nuses this empty section. So the following script leaves a sequence of\nempty sections \"[a]\". Looks like a disk space leak to me.\n\ngit config a.b a\ngit config --unset a.b\ngit config a.b a\ngit config --unset a.b\ngit config a.b a\ngit config --unset a.b\ngit config a.b a\ngit config --unset a.b\n\nThe resulting .git/config file:\n\n[core]\n\trepositoryformatversion = 0\n\tfilemode = true\n\tbare = false\n\tlogallrefupdates = true\n\tignorecase = true\n[a]\n[a]\n[a]\n[a]\n\nWas this bug fixed in later versions?\n\nConstantine\n"},{"id":"113092","messageId":"85647ef50905060904w49879c57r4a5773a487f09c85@mail.gmail.com","threadId":"19200","inReplyTo":"85647ef50905060850t2e6c2051jfa6d3596b680cc74@mail.gmail.com","subject":"Re: [BUG] git config: cygwin git version 1.6.1.2 does not deletes empty sections","fromName":"Constantine Plotnikov","fromEmail":"constantine.plotnikov@gmail.com","sentAt":"2009-05-06T16:04:25Z","receivedAt":"2009-05-06T16:04:25Z","isPatch":false,"sender":{"key":"constantine.plotnikov@gmail.com","avatar":null},"body":"The bug is also confirmed on MSYS git version 1.6.2.2.1669.g7eaf8.\n\nConstantine\n\nOn Wed, May 6, 2009 at 7:50 PM, Constantine Plotnikov\n<constantine.plotnikov@gmail.com> wrote:\n> I have encountered a bug related to git config in cygwin git version 1.6.1.2\n>\n> The git config --unset might leave an empty section when the last\n> property is deleted. But consequent \"git config key value\" does not\n> uses this empty section. So the following script leaves a sequence of\n> empty sections \"[a]\". Looks like a disk space leak to me.\n>\n> git config a.b a\n> git config --unset a.b\n> git config a.b a\n> git config --unset a.b\n> git config a.b a\n> git config --unset a.b\n> git config a.b a\n> git config --unset a.b\n>\n> The resulting .git/config file:\n>\n> [core]\n>        repositoryformatversion = 0\n>        filemode = true\n>        bare = false\n>        logallrefupdates = true\n>        ignorecase = true\n> [a]\n> [a]\n> [a]\n> [a]\n>\n> Was this bug fixed in later versions?\n>\n> Constantine\n>\n"},{"id":"113103","messageId":"40aa078e0905061108o21830f07xfb9d5c185c93fda6@mail.gmail.com","threadId":"19200","inReplyTo":"85647ef50905060904w49879c57r4a5773a487f09c85@mail.gmail.com","subject":"Re: [BUG] git config: cygwin git version 1.6.1.2 does not deletes empty sections","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@googlemail.com","sentAt":"2009-05-06T18:08:06Z","receivedAt":"2009-05-06T18:08:06Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Wed, May 6, 2009 at 6:04 PM, Constantine Plotnikov\n<constantine.plotnikov@gmail.com> wrote:\n> The bug is also confirmed on MSYS git version 1.6.2.2.1669.g7eaf8.\n\nThe same issue is present in git 1.6.2.1 on Linux. Not that I'm too\nsure it's really a bug, though ;)\n\n-- \nErik \"kusma\" Faye-Lund\nkusmabite@gmail.com\n(+47) 986 59 656\n"},{"id":"113127","messageId":"20090506224327.23c69a06@gmail.com","threadId":"19200","inReplyTo":"40aa078e0905061108o21830f07xfb9d5c185c93fda6@mail.gmail.com","subject":"Re: [BUG] git config: cygwin git version 1.6.1.2 does not deletes empty sections","fromName":"Michał Kiedrowicz","fromEmail":"michal.kiedrowicz@gmail.com","sentAt":"2009-05-06T20:43:27Z","receivedAt":"2009-05-06T20:43:27Z","isPatch":false,"sender":{"key":"michal.kiedrowicz@gmail.com","avatar":"https://avatars.githubusercontent.com/u/14072847?v=4"},"body":"Erik Faye-Lund <kusmabite@googlemail.com> wrote:\n\n> On Wed, May 6, 2009 at 6:04 PM, Constantine Plotnikov\n> <constantine.plotnikov@gmail.com> wrote:\n> > The bug is also confirmed on MSYS git version 1.6.2.2.1669.g7eaf8.\n> \n> The same issue is present in git 1.6.2.1 on Linux. Not that I'm too\n> sure it's really a bug, though ;)\n> \n\nHappens also in master (v1.6.3-rc4-29-g8146f19). IMO this is because\ngit_parse_file() reports only *variables*, not *sections* and\nstore_aux() doesn't find empty section.\n\n--\nMichał Kiedrowicz\n"}]}