{"thread":{"id":"19169","subject":"Resurrecting an old git-stash discussion","startedAt":"2009-05-04T01:35:55Z","lastAt":"2009-05-04T01:35:55Z","messageCount":1,"participants":["David Aguilar"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"112943","messageId":"20090504013554.GE50640@gmail.com","threadId":"19169","inReplyTo":null,"subject":"Resurrecting an old git-stash discussion","fromName":"David Aguilar","fromEmail":"davvid@gmail.com","sentAt":"2009-05-04T01:35:55Z","receivedAt":"2009-05-04T01:35:55Z","isPatch":false,"sender":{"key":"davvid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/13196?v=4"},"body":"A long time ago there was a patch that made git-stash\nconfigurable:\n\nhttp://lists.zerezo.com/git/msg641406.html\n\n\nJunio's conclusion at the time was:\n\n\"The decision here is that I am open to a change that\nimplements the one-time safety instruction.\"\n\nhttp://lists.zerezo.com/git/msg641442.html\n\nWould this be something worth implementing after this\nrelease cycle?\n\nIf so, would this be the basic logic?:\n\n\nIf stash.quick is undefined:\n- Alert the user to what's going on\n- Ask them whether they'd like to enable the quick behavior,\n  or exit (thus leaving stash.quick undefined).\n\nValid values for stash.quick are then either undefined\nor 'save'.\n\nIs it still a good idea to implement the one-time\nsafety instruction?\n\nI just thought I'd ask.  Why?\nA co-worker ran into this funny situation last week:\n\n\tgit branch\n\tgit stash  # oops, didn't mean that\n\n\tgit stash help # prints usage, though only by luck\n\tgit branch help # oops, didn't mean that\n\nThere's a limit to guarding against the uneducated and by no\nmeans do I think the 2nd \"oops\"'s behavior should be changed.\nWith the proposed change we would've warned him at the first\n\"oops\", and that's better than nothing.\n\nThe above is a silly example despite the fact that it\nactually happened.  'rm help' happily removes your 'help'\nfile.  I just figured I'd mention it since maybe instead of\nprinting usage stash should also warn:\n\n\tError: unknown command 'help'.\n\tRun 'git help stash' for more information.\n\n\nRegarding the 'first time warning' thing:\n\n  97bc00a: Emit helpful status for accidental \"git stash\" save\n\n..seems like it already addressed the issue by telling\nusers how to apply the stash.  That makes the case for\nthe first-time-warning much less compelling.\n\nHmm.. maybe I just answered my own question ;)\n\n\nThe \"unknown command 'help'\" thing might be good nonetheless,\nthough.\n\n\n-- \n\t\tDavid\n"}]}