{"thread":{"id":"19167","subject":"[gitosis] unexpected error for a warning msg","startedAt":"2009-05-03T23:23:00Z","lastAt":"2009-05-03T23:54:02Z","messageCount":2,"participants":["Nicolas Sebrecht","Robin H. Johnson"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"112939","messageId":"20090503232300.GA20066@vidovic","threadId":"19167","inReplyTo":null,"subject":"[gitosis] unexpected error for a warning msg","fromName":"Nicolas Sebrecht","fromEmail":"nicolas.s.dev@gmail.com","sentAt":"2009-05-03T23:23:00Z","receivedAt":"2009-05-03T23:23:00Z","isPatch":false,"sender":{"key":"nicolas.s.dev@gmail.com","avatar":null},"body":"Hi,\n\nI had the following issue using gitosis today:\nhttp://colabti.org/irclogger/irclogger_log/git?date=2009-05-03#l2233\n\nThe name of the key file was 'keydir/Jacques@BLACK_ANTEC.pub' which gave\nthe warning (when pushing): \nWARNING:gitosis.ssh:Unsafe SSH username in keyfile: Jacques@BLACK_ANTEC.pub\n\nChanging the filename into Jacques.pub solved the issue.\n\nI was expecting an error message instead (not a warning) as it seems to\n_not_ permit such a filename.\n\nWhy the initial filename is fobidden?\nCould the warning be substituted by an error?\n\nThanks,\n\n-- \nNicolas Sebrecht\n"},{"id":"112940","messageId":"20090503235402.GA10702@curie-int","threadId":"19167","inReplyTo":"20090503232300.GA20066@vidovic","subject":"Re: [gitosis] unexpected error for a warning msg","fromName":"Robin H. Johnson","fromEmail":"robbat2@gentoo.org","sentAt":"2009-05-03T23:54:02Z","receivedAt":"2009-05-03T23:54:02Z","isPatch":false,"sender":{"key":"robbat2@gentoo.org","avatar":"https://avatars.githubusercontent.com/u/373898?v=4"},"body":"On Mon, May 04, 2009 at 01:23:00AM +0200, Nicolas Sebrecht wrote:\n> I had the following issue using gitosis today:\n> http://colabti.org/irclogger/irclogger_log/git?date=2009-05-03#l2233\n> \n> The name of the key file was 'keydir/Jacques@BLACK_ANTEC.pub' which gave\n> the warning (when pushing): \n> WARNING:gitosis.ssh:Unsafe SSH username in keyfile: Jacques@BLACK_ANTEC.pub\n> \n> Changing the filename into Jacques.pub solved the issue.\n> \n> I was expecting an error message instead (not a warning) as it seems to\n> _not_ permit such a filename.\n> \n> Why the initial filename is fobidden?\n> Could the warning be substituted by an error?\nThey are meant to be valid usernames, which don't include the @ symbol.\n\nFor the git.overlays.gentoo.org site, where we use gitosis, we had some\nissues that were best solved by fixing Gitosis itself (like being able\nto pass SSH key options, eg \"from=\" to restrict hosts). Another one that\nbugged me was that the string at the end of an ssh key is NOT a\nusername, it's a freeform (well, no newline) text field.\n\nI've tried to send the patches to upstream on several occasions, but\nnever gotten any response. \n\nI didn't disable the warning you're complaining about, as I wanted it\nstill, but I do agree it's probably better to upgrade to an error.\n\nYou can find the Gentoo fork here:\nhttp://git.overlays.gentoo.org/gitweb/?p=proj/gitosis-gentoo.git;a=summary\n\n-- \nRobin Hugh Johnson\nGentoo Linux Developer & Infra Guy\nE-Mail     : robbat2@gentoo.org\nGnuPG FP   : 11AC BA4F 4778 E3F6 E4ED  F38E B27B 944E 3488 4E85\n"}]}