{"thread":{"id":"19120","subject":"[PATCH] Documentation: Fix description of archive \"--prefix\"","startedAt":"2009-04-29T13:42:36Z","lastAt":"2009-04-30T02:33:01Z","messageCount":3,"participants":["Holger Weiß","Wesley J. Landaker"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"112635","messageId":"20090429134236.GU36958498@CIS.FU-Berlin.DE","threadId":"19120","inReplyTo":null,"subject":"[PATCH] Documentation: Fix description of archive \"--prefix\"","fromName":"Holger Weiß","fromEmail":"holger@zedat.fu-berlin.de","sentAt":"2009-04-29T13:42:36Z","receivedAt":"2009-04-29T13:42:36Z","isPatch":true,"sender":{"key":"holger@zedat.fu-berlin.de","avatar":"https://avatars.githubusercontent.com/u/71850?v=4"},"body":"The description of the \"--prefix\" option suggested that a slash would\nautomatically be appended to the specified <prefix>, which is not the\ncase.\n\nSigned-off-by: Holger Weiß <holger@zedat.fu-berlin.de>\n---\n Documentation/git-archive.txt |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/git-archive.txt b/Documentation/git-archive.txt\nindex ad38f7f..6848e62 100644\n--- a/Documentation/git-archive.txt\n+++ b/Documentation/git-archive.txt\n@@ -9,7 +9,7 @@ git-archive - Create an archive of files from a named tree\n SYNOPSIS\n --------\n [verse]\n-'git archive' --format=<fmt> [--list] [--prefix=<prefix>/] [<extra>]\n+'git archive' --format=<fmt> [--list] [--prefix=<prefix>] [<extra>]\n \t      [--remote=<repo> [--exec=<git-upload-archive>]] <tree-ish>\n \t      [path...]\n \n@@ -44,8 +44,8 @@ OPTIONS\n --verbose::\n \tReport progress to stderr.\n \n---prefix=<prefix>/::\n-\tPrepend <prefix>/ to each filename in the archive.\n+--prefix=<prefix>::\n+\tPrepend <prefix> to each filename in the archive.\n \n <extra>::\n \tThis can be any options that the archiver backend understands.\n-- \n1.6.2.4\n"},{"id":"112646","messageId":"20090429154941.GB33221014@CIS.FU-Berlin.DE","threadId":"19120","inReplyTo":"20090429134236.GU36958498@CIS.FU-Berlin.DE","subject":"Re: [PATCH] Documentation: Fix description of archive \"--prefix\"","fromName":"Holger Weiß","fromEmail":"holger@zedat.fu-berlin.de","sentAt":"2009-04-29T15:49:41Z","receivedAt":"2009-04-29T15:49:41Z","isPatch":true,"sender":{"key":"holger@zedat.fu-berlin.de","avatar":"https://avatars.githubusercontent.com/u/71850?v=4"},"body":"* Holger Weiß <holger@zedat.fu-berlin.de> [2009-04-29 15:42]:\n> The description of the \"--prefix\" option suggested that a slash would\n> automatically be appended to the specified <prefix>, which is not the\n> case.\n\nNonsense, it's telling the user that appending a slash to the <prefix>\nis mandatory.  Scratch my patch.\n\nSorry, Holger\n"},{"id":"112731","messageId":"200904292033.03899.wjl@icecavern.net","threadId":"19120","inReplyTo":"20090429154941.GB33221014@CIS.FU-Berlin.DE","subject":"Re: [PATCH] Documentation: Fix description of archive \"--prefix\"","fromName":"Wesley J. Landaker","fromEmail":"wjl@icecavern.net","sentAt":"2009-04-30T02:33:01Z","receivedAt":"2009-04-30T02:33:01Z","isPatch":true,"sender":{"key":"wjl@icecavern.net","avatar":"https://avatars.githubusercontent.com/u/67229?v=4"},"body":"On Wednesday 29 April 2009 09:49:41 Holger Weiß wrote:\n> * Holger Weiß <holger@zedat.fu-berlin.de> [2009-04-29 15:42]:\n> > The description of the \"--prefix\" option suggested that a slash would\n> > automatically be appended to the specified <prefix>, which is not the\n> > case.\n>\n> Nonsense, it's telling the user that appending a slash to the <prefix>\n> is mandatory.  Scratch my patch.\n\nI just tried not using a slash; it doesn't give an error or internally add \none, instead it makes a worthless archive:\n\n$ git archive --prefix=noslash HEAD | tar tv | head\n-rw-rw-r-- root/root        51 2009-04-28 01:46 noslash.gitattributes\n-rw-rw-r-- root/root      2416 2009-04-28 01:46 noslash.gitignore\n-rw-rw-r-- root/root      2519 2009-04-28 01:46 noslash.mailmap\n-rw-rw-r-- root/root     18787 2009-04-28 01:46 noslashCOPYING\ndrwxrwxr-x root/root         0 2009-04-28 01:46 noslashDocumentation/\n-rw-rw-r-- root/root        17 2009-04-28 01:46 \nnoslashDocumentation/.gitattributes\n-rw-rw-r-- root/root        91 2009-04-28 01:46 \nnoslashDocumentation/.gitignore\n-rw-rw-r-- root/root      4868 2009-04-28 01:46 \nnoslashDocumentation/CodingGuidelines\n-rw-rw-r-- root/root      9028 2009-04-28 01:46 noslashDocumentation/Makefile\n-rw-rw-r-- root/root      1255 2009-04-28 01:46 \nnoslashDocumentation/RelNotes-1.5.0.1.txt\n\nShould this be fixed by automatically adding a slash if there wasn't one given? \nI can't image anyone would want an archive made of mangled filenames like this, \nso if we don't want that behavior, it seems like it should at least give an \nerror.\n"}]}