{"thread":{"id":"19087","subject":"t3702-add-edit.sh failure in next","startedAt":"2009-04-27T15:12:15Z","lastAt":"2009-04-27T18:01:08Z","messageCount":5,"participants":["Mike Ralphson","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"112422","messageId":"e2b179460904270812t3fa159f1ja3b06905d9effebe@mail.gmail.com","threadId":"19087","inReplyTo":null,"subject":"t3702-add-edit.sh failure in next","fromName":"Mike Ralphson","fromEmail":"mike.ralphson@gmail.com","sentAt":"2009-04-27T15:12:15Z","receivedAt":"2009-04-27T15:12:15Z","isPatch":false,"sender":{"key":"mike.ralphson@gmail.com","avatar":"https://avatars.githubusercontent.com/u/21603?v=4"},"body":"I'm seeing a reproducible failure in t3702 on AIX 5.3, shell set to\nbash (v2.05b)\n\nThe 'test_cmp orig-patch expected-patch' is seeing this diff:\n\n2c2\n< index b9834b5..52aff4c 100644\n---\n> index b9834b5..0b8f197 100644\n\nThe index seems to contain the expected content.\n\nI've tried to eliminate GIT* environment variables which might be\naffecting the commit id, and tried adding extra test_ticks, but I'm\nafraid I can't work out what's up here.\n\nNormally all tests pass fine with the exception of some skipped\nbecause of known iconv issues on this platform.\n\nMike\n"},{"id":"112430","messageId":"alpine.DEB.1.00.0904271812180.7741@intel-tinevez-2-302","threadId":"19087","inReplyTo":"e2b179460904270812t3fa159f1ja3b06905d9effebe@mail.gmail.com","subject":"Re: t3702-add-edit.sh failure in next","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-04-27T16:13:07Z","receivedAt":"2009-04-27T16:13:07Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 27 Apr 2009, Mike Ralphson wrote:\n\n> I'm seeing a reproducible failure in t3702 on AIX 5.3, shell set to\n> bash (v2.05b)\n> \n> The 'test_cmp orig-patch expected-patch' is seeing this diff:\n> \n> 2c2\n> < index b9834b5..52aff4c 100644\n> ---\n> > index b9834b5..0b8f197 100644\n\nCould you send me the output of\n\n\tcd t/trash\\ directory.t3702* &&\n\tgit show 0b8f197 > file.txt\n\n?\n\nThanks,\nDscho\n"},{"id":"112433","messageId":"e2b179460904270930m3c292bd8l5067447fff330fef@mail.gmail.com","threadId":"19087","inReplyTo":"alpine.DEB.1.00.0904271812180.7741@intel-tinevez-2-302","subject":"Re: t3702-add-edit.sh failure in next","fromName":"Mike Ralphson","fromEmail":"mike.ralphson@gmail.com","sentAt":"2009-04-27T16:30:25Z","receivedAt":"2009-04-27T16:30:25Z","isPatch":false,"sender":{"key":"mike.ralphson@gmail.com","avatar":"https://avatars.githubusercontent.com/u/21603?v=4"},"body":"2009/4/27 Johannes Schindelin :\n> On Mon, 27 Apr 2009, Mike Ralphson wrote:\n>> I'm seeing a reproducible failure in t3702 on AIX 5.3, shell set to\n>> bash (v2.05b)\n>>\n>> The 'test_cmp orig-patch expected-patch' is seeing this diff:\n>>\n>> 2c2\n>> < index b9834b5..52aff4c 100644\n>> ---\n>> > index b9834b5..0b8f197 100644\n>\n> Could you send me the output of\n>\n>        cd t/trash\\ directory.t3702* &&\n>        git show 0b8f197 > file.txt\n\nWell I would, but there isn't any. It's an unknown revision. git fsck\n-v doesn't show it anywhere. I have:\n\nChecking HEAD link\nChecking object directory\nChecking directory .git/objects/91\nChecking directory .git/objects/b9\nChecking directory .git/objects/e0\nChecking directory .git/objects/ef\nChecking tree 911cd8fe32ce30bdaee8753cd526394a5c878cc0\nChecking blob b9834b51dd31af09b373c39cae5c5fce38ee1034\nChecking commit e055285ca8312c5bd9f369a5762fb5871ad110e8\nChecking blob ef6e94c5794cbad5c1dc41bec85640ca54a46a55\nChecking reflog\n0000000000000000000000000000000000000000->e055285ca8312c5bd9f369a5762fb5871ad110e8\nChecking reflog\n0000000000000000000000000000000000000000->e055285ca8312c5bd9f369a5762fb5871ad110e8\nChecking connectivity (32 objects)\nChecking ef6e94c5794cbad5c1dc41bec85640ca54a46a55\nChecking b9834b51dd31af09b373c39cae5c5fce38ee1034\nChecking e055285ca8312c5bd9f369a5762fb5871ad110e8\nChecking 911cd8fe32ce30bdaee8753cd526394a5c878cc0\n\nblob, tree and commit of 'initial' I believe plus the new blob of the\nexpected content in ef6e94c (attached).\n\nI've just tried building without INTERNAL_QSORT just in case, and it\ndoesn't seem to be that.\n\nMike\n\n\nLO, praise of the prowess of people-kings\nof spear-armed Danes, in days long sped,\nwe have heard, and what honor the athelings won!\n\nOft Scyld the Scefing from squadroned foes,\nfrom many a tribe, the mead-bench tore,\nawing the earls. Since erst he lay\nfriendless, a foundling, fate repaid him:\n\nfor he waxed under welkin, in wealth he throve,\ntill before him the folk, both far and near,\nwho house by the whale-path, heard his mandate,\ngave him gifts: a good king he!\n"},{"id":"112442","messageId":"alpine.DEB.1.00.0904271940100.7741@intel-tinevez-2-302","threadId":"19087","inReplyTo":"e2b179460904270930m3c292bd8l5067447fff330fef@mail.gmail.com","subject":"[PATCH] t3702: fix reliance on SHELL_PATH being '/bin/sh'","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-04-27T17:51:42Z","receivedAt":"2009-04-27T17:51:42Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nTrying to be lazy and comparing files with fake-editor.sh to avoid\nhaving to provide another example text does not work well: the blob\nname changes when SHELL_PATH changes, and so does the 'index' line\nin the diff.\n\nTherefore provide a second example text.\n\nNoticed by Mike Ralphson.\n\nSigned-off-by: Johannes Schindelin \n---\n\n\tOn Mon, 27 Apr 2009, Mike Ralphson wrote:\n\n\t> 2009/4/27 Johannes Schindelin :\n\t> > On Mon, 27 Apr 2009, Mike Ralphson wrote:\n\t> >> I'm seeing a reproducible failure in t3702 on AIX 5.3, shell set to\n\t> >> bash (v2.05b)\n\t> >>\n\t> >> The 'test_cmp orig-patch expected-patch' is seeing this diff:\n\t> >>\n\t> >> 2c2\n\t> >> < index b9834b5..52aff4c 100644\n\t> >> ---\n\t> >> > index b9834b5..0b8f197 100644\n\t> >\n\t> > Could you send me the output of\n\t> >\n\t> >        cd t/trash\\ directory.t3702* &&\n\t> >        git show 0b8f197 > file.txt\n\n\tAargh.\n\n\tI know what it is. Sorry, _very_ stupid thinko on this side of \n\tthe ocean.\n\n\tTime for a day off.\n\n t/t3702-add-edit.sh | 26 +++++++++++++++++++-------\n 1 files changed, 19 insertions(+), 7 deletions(-)\n\ndiff --git a/t/t3702-add-edit.sh b/t/t3702-add-edit.sh\nindex 7262786..4ee47cc 100755\n--- a/t/t3702-add-edit.sh\n+++ b/t/t3702-add-edit.sh\n@@ -21,6 +21,15 @@ who house by the whale-path, heard his mandate,\n gave him gifts: a good king he!\n EOF\n \n+cat > second-part << EOF\n+To him an heir was afterward born,\n+a son in his halls, whom heaven sent\n+to favor the folk, feeling their woe\n+that erst they had lacked an earl for leader\n+so long a while; the Lord endowed him,\n+the Wielder of Wonder, with world's renown.\n+EOF\n+\n test_expect_success 'setup' '\n \n \tgit add file &&\n@@ -31,10 +40,10 @@ test_expect_success 'setup' '\n \n cat > expected-patch << EOF\n diff --git a/file b/file\n-index b9834b5..0b8f197 100644\n+index b9834b5..9020acb 100644\n --- a/file\n +++ b/file\n-@@ -1,11 +1,3 @@\n+@@ -1,11 +1,6 @@\n -LO, praise of the prowess of people-kings\n -of spear-armed Danes, in days long sped,\n -we have heard, and what honor the athelings won!\n@@ -46,9 +55,12 @@ index b9834b5..0b8f197 100644\n -till before him the folk, both far and near,\n -who house by the whale-path, heard his mandate,\n -gave him gifts: a good king he!\n-+#!$SHELL_PATH\n-+mv -f \"\\$1\" orig-patch &&\n-+mv -f patch \"\\$1\"\n++To him an heir was afterward born,\n++a son in his halls, whom heaven sent\n++to favor the folk, feeling their woe\n++that erst they had lacked an earl for leader\n++so long a while; the Lord endowed him,\n++the Wielder of Wonder, with world's renown.\n EOF\n \n cat > patch << EOF\n@@ -97,9 +109,9 @@ chmod a+x fake-editor.sh\n \n test_expect_success 'add -e' '\n \n-\tcp fake-editor.sh file &&\n+\tcp second-part file &&\n \tgit add -e &&\n-\ttest_cmp fake-editor.sh file &&\n+\ttest_cmp second-part file &&\n \ttest_cmp orig-patch expected-patch &&\n \tgit diff --cached > out &&\n \ttest_cmp out expected\n-- \n1.6.2.1.493.g67cf3\n"},{"id":"112443","messageId":"e2b179460904271101r6b405595yd4ad3562633eae60@mail.gmail.com","threadId":"19087","inReplyTo":"alpine.DEB.1.00.0904271940100.7741@intel-tinevez-2-302","subject":"Re: [PATCH] t3702: fix reliance on SHELL_PATH being '/bin/sh'","fromName":"Mike Ralphson","fromEmail":"mike.ralphson@gmail.com","sentAt":"2009-04-27T18:01:08Z","receivedAt":"2009-04-27T18:01:08Z","isPatch":true,"sender":{"key":"mike.ralphson@gmail.com","avatar":"https://avatars.githubusercontent.com/u/21603?v=4"},"body":"2009/4/27 Johannes Schindelin :\n> Trying to be lazy and comparing files with fake-editor.sh to avoid\n> having to provide another example text does not work well: the blob\n> name changes when SHELL_PATH changes, and so does the 'index' line\n> in the diff.\n>\n>        Aargh.\n>\n>        I know what it is.  Sorry, _very_ stupid thinko on this side of\n>        the ocean.\n>\n>        Time for a day off.\n\nI shall merely extend my thanks for diagnosing the problem (which I\nshould have been able to do), and for fixing it - which I wouldn't\nhave been able to do, because I'd assumed you were trying to be\nclever, not lazy. 8-)\n\nTested-by: Mike Ralphson \n"}]}