{"thread":{"id":"1903","subject":"Another gitweb wishlist","startedAt":"2005-09-21T20:16:56Z","lastAt":"2005-09-22T12:33:40Z","messageCount":3,"participants":["Petr Baudis","Sven Verdoolaege"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"9067","messageId":"20050921201656.GA10575@pasky.or.cz","threadId":"1903","inReplyTo":null,"subject":"Another gitweb wishlist","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2005-09-21T20:16:56Z","receivedAt":"2005-09-21T20:16:56Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"  Hello,\n\n  I have accumulated some more stuff I'm missing in gitweb, so I'm\ndumping it on you now. ;-)\n\n  (i) Speed - the http://kernel.org/git/ document takes anytime between\nroughly 30 seconds to one minute to load. What's taking so long?\n\n  (ii) I need persistent links to the latest version of <file>. Obvious\n\n\thttp://kernel.org/git/?p=cogito/cogito.git;a=blob;f=contrib/ciabot.pl\n\ndoes not quite work right, since there are no links to (most\nimportantly) the plain view (and blob_plain link doesn't work), tree\nview and such.\n\n  (iii) Too hard to follow history of renamed files. Let's take\ngit-log.sh.  I'll immediately stop at the big rename commit:\n\n\thttp://kernel.org/git/?p=git/git.git;a=commit;h=215a7ad1ef790467a4cd3f0dcffbd6e5f04c38f7\n\nIf I want to continue following its history before the rename, I have to\nmanually go to the tree of the parent commit and get the history of the\noriginal file there. This is quite annoying and significantly reduces\npracticality of the feature on the GIT repository precisely because of\nthe big rename.\n\n  (iv) Related to (iii), if you get the hb  parameter to the blob view,\nyou should offer the 'diff' and 'history' links in the blob view. Also\nthe 'log' and 'shortlog' links should point to more sensible locations,\neither the same as in the relevant commit's view, or see (v).\n\n  (v) Only shortlog is available for per-file history. Perhaps it would\nbe nicer to make 'log' and 'shortlog' links in blob context go to the\nfile's history, and in file history switch between shortlog/log display\nmode.\n\n  Thanks,\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nVI has two modes: the one in which it beeps and the one in which\nit doesn't.\n"},{"id":"9069","messageId":"20050921205416.GU15165MdfPADPa@greensroom.kotnet.org","threadId":"1903","inReplyTo":"20050921201656.GA10575@pasky.or.cz","subject":"Re: Another gitweb wishlist","fromName":"Sven Verdoolaege","fromEmail":"skimo@kotnet.org","sentAt":"2005-09-21T20:54:16Z","receivedAt":"2005-09-21T20:54:16Z","isPatch":false,"sender":{"key":"skimo@kotnet.org","avatar":null},"body":"On Wed, Sep 21, 2005 at 10:16:56PM +0200, Petr Baudis wrote:\n>   (ii) I need persistent links to the latest version of <file>. Obvious\n> \n> \thttp://kernel.org/git/?p=cogito/cogito.git;a=blob;f=contrib/ciabot.pl\n> \n\nWorks for me:\nhttp://www.liacs.nl/~sverdool/gitweb.cgi?p=barvinok.git;a=blob;f=README\n\nIt's probably this one:\n\ndiff --git a/gitweb.cgi b/gitweb.cgi\n--- a/gitweb.cgi\n+++ b/gitweb.cgi\n@@ -1269,9 +1269,9 @@ sub git_get_hash_by_path {\n }\n \n sub git_blob {\n+\t$hash_base ||= git_read_hash(\"$project/HEAD\");\n \tif (!defined $hash && defined $file_name) {\n-\t\tmy $base = $hash_base || git_read_hash(\"$project/HEAD\");\n-\t\t$hash = git_get_hash_by_path($base, $file_name, \"blob\");\n+\t\t$hash = git_get_hash_by_path($hash_base, $file_name, \"blob\");\n \t}\n \topen my $fd, \"-|\", \"$gitbin/git-cat-file blob $hash\" or die_error(undef, \"Open failed.\");\n \tmy $base = $file_name || \"\";\n\nskimo\n"},{"id":"9106","messageId":"20050922123340.GI21019@pasky.or.cz","threadId":"1903","inReplyTo":"20050921205416.GU15165MdfPADPa@greensroom.kotnet.org","subject":"Re: Another gitweb wishlist","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2005-09-22T12:33:40Z","receivedAt":"2005-09-22T12:33:40Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Wed, Sep 21, 2005 at 10:54:16PM CEST, I got a letter\nwhere Sven Verdoolaege <skimo@kotnet.org> told me that...\n> On Wed, Sep 21, 2005 at 10:16:56PM +0200, Petr Baudis wrote:\n> >   (ii) I need persistent links to the latest version of <file>. Obvious\n> > \n> > \thttp://kernel.org/git/?p=cogito/cogito.git;a=blob;f=contrib/ciabot.pl\n> > \n> \n> Works for me:\n> http://www.liacs.nl/~sverdool/gitweb.cgi?p=barvinok.git;a=blob;f=README\n\nThis is good, however there is no easy way to see the file's history,\nand showing the last repository commit with the file might lead to a\nfalse impression that the commit actually touched the file, even if that\nis not the case.\n\nAlso, trying to see your changes at\n\n\thttp://www.liacs.nl/~sverdool/gitweb.cgi?p=gitweb.git;a=summary\n\nshows how nice it would be to have some gitk-ish gitweb view.  That\nwould be probably a lot of work, though.\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nVI has two modes: the one in which it beeps and the one in which\nit doesn't.\n"}]}