{"thread":{"id":"19003","subject":"[PATCH 1/2] Documentation: git-svn: fix spurious bolding that mangles the output","startedAt":"2009-04-22T14:51:46Z","lastAt":"2009-04-23T04:21:12Z","messageCount":6,"participants":["Wesley J. Landaker","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"111950","messageId":"1240411907-5002-1-git-send-email-wjl@icecavern.net","threadId":"19003","inReplyTo":null,"subject":"[PATCH 1/2] Documentation: git-svn: fix spurious bolding that mangles the output","fromName":"Wesley J. Landaker","fromEmail":"wjl@icecavern.net","sentAt":"2009-04-22T14:51:46Z","receivedAt":"2009-04-22T14:51:46Z","isPatch":true,"sender":{"key":"wjl@icecavern.net","avatar":"https://avatars.githubusercontent.com/u/67229?v=4"},"body":"Without this fix, the output looks like:\n\n\"Keep in mind that the (asterisk) wildcard of the local ref (right of\nthe :) *must be the ...\" -- with half the sentence spuriously bold.\n\nThis is probably working around an asciidoc bug, but it's better to fix\nthis than to leave the documentation in an unreadable state.\n\nSigned-off-by: Wesley J. Landaker \n---\n Documentation/git-svn.txt | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex 9229d45..b03c1f0 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -694,7 +694,7 @@ listed below are allowed:\n ------------------------------------------------------------------------\n \n Keep in mind that the '*' (asterisk) wildcard of the local ref\n-(right of the ':') *must* be the farthest right path component;\n+(right of the ':') must be the farthest right path component;\n however the remote wildcard may be anywhere as long as it's own\n independent path component (surrounded by '/' or EOL). This\n type of configuration is not automatically created by 'init' and\n-- \n1.6.2.3\n"},{"id":"111951","messageId":"1240411907-5002-2-git-send-email-wjl@icecavern.net","threadId":"19003","inReplyTo":"1240411907-5002-1-git-send-email-wjl@icecavern.net","subject":"[PATCH 2/2] Documentation: git-svn: fix a grammatical error without awkwardness","fromName":"Wesley J. Landaker","fromEmail":"wjl@icecavern.net","sentAt":"2009-04-22T14:51:47Z","receivedAt":"2009-04-22T14:51:47Z","isPatch":true,"sender":{"key":"wjl@icecavern.net","avatar":"https://avatars.githubusercontent.com/u/67229?v=4"},"body":"The way the sentence is currently written, there needs to be an \"its\",\nbut this leads to: \"however the remote wildcard may be anywhere as long\nas it's its own\" which is awkward to read.\n\nInstead, this patch fixes he grammar in a simpler way.\n\nSigned-off-by: Wesley J. Landaker \n---\n Documentation/git-svn.txt | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex b03c1f0..1b18c19 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -695,7 +695,7 @@ listed below are allowed:\n \n Keep in mind that the '*' (asterisk) wildcard of the local ref\n (right of the ':') must be the farthest right path component;\n-however the remote wildcard may be anywhere as long as it's own\n+however the remote wildcard may be anywhere as long as it's an\n independent path component (surrounded by '/' or EOL). This\n type of configuration is not automatically created by 'init' and\n should be manually entered with a text-editor or using 'git-config'.\n-- \n1.6.2.3\n"},{"id":"111952","messageId":"20090422151515.GA12370@coredump.intra.peff.net","threadId":"19003","inReplyTo":"1240411907-5002-1-git-send-email-wjl@icecavern.net","subject":"Re: [PATCH 1/2] Documentation: git-svn: fix spurious bolding that mangles the output","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2009-04-22T15:15:16Z","receivedAt":"2009-04-22T15:15:16Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Apr 22, 2009 at 08:51:46AM -0600, Wesley J. Landaker wrote:\n\n> Without this fix, the output looks like:\n> \n> \"Keep in mind that the (asterisk) wildcard of the local ref (right of\n> the :) *must be the ...\" -- with half the sentence spuriously bold.\n> \n> This is probably working around an asciidoc bug, but it's better to fix\n> this than to leave the documentation in an unreadable state.\n\nI think it's a documentation bug; the asterisk is a special character,\nso it is seeing the first one as the start of bold, instead of the one\non the left side of *must*.\n\n> Keep in mind that the '*' (asterisk) wildcard of the local ref\n> -(right of the ':') *must* be the farthest right path component;\n> +(right of the ':') must be the farthest right path component;\n\nSo the right fix is probably to quote the asterisk that is not part of\nthe bolding, like:\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex 9229d45..3e22e40 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -693,7 +693,7 @@ listed below are allowed:\n \ttags = tags/*/project-a:refs/remotes/project-a/tags/*\n ------------------------------------------------------------------------\n \n-Keep in mind that the '*' (asterisk) wildcard of the local ref\n+Keep in mind that the '\\*' (asterisk) wildcard of the local ref\n (right of the ':') *must* be the farthest right path component;\n however the remote wildcard may be anywhere as long as it's own\n independent path component (surrounded by '/' or EOL). This\n"},{"id":"111957","messageId":"1240415338-18076-1-git-send-email-wjl@icecavern.net","threadId":"19003","inReplyTo":"20090422151515.GA12370@coredump.intra.peff.net","subject":"[PATCH v2 1/2] Documentation: git-svn: fix spurious bolding that mangles the output","fromName":"Wesley J. Landaker","fromEmail":"wjl@icecavern.net","sentAt":"2009-04-22T15:48:57Z","receivedAt":"2009-04-22T15:48:57Z","isPatch":true,"sender":{"key":"wjl@icecavern.net","avatar":"https://avatars.githubusercontent.com/u/67229?v=4"},"body":"Without this fix, the output looks like:\n\n\"Keep in mind that the (asterisk) wildcard of the local ref (right of\nthe :) *must be the ...\" -- with half the sentence spuriously bold.\n\nThis fixes the problem by simply escaping asciidoc syntax as suggested\nby Jeff King .\n\nSigned-off-by: Wesley J. Landaker \n---\n Documentation/git-svn.txt | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex 9229d45..3e22e40 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -693,7 +693,7 @@ listed below are allowed:\n \ttags = tags/*/project-a:refs/remotes/project-a/tags/*\n ------------------------------------------------------------------------\n \n-Keep in mind that the '*' (asterisk) wildcard of the local ref\n+Keep in mind that the '\\*' (asterisk) wildcard of the local ref\n (right of the ':') *must* be the farthest right path component;\n however the remote wildcard may be anywhere as long as it's own\n independent path component (surrounded by '/' or EOL). This\n-- \n1.6.2.3\n"},{"id":"111958","messageId":"1240415338-18076-2-git-send-email-wjl@icecavern.net","threadId":"19003","inReplyTo":"20090422151515.GA12370@coredump.intra.peff.net","subject":"[PATCH v2 2/2] Documentation: git-svn: fix a grammatical error without awkwardness","fromName":"Wesley J. Landaker","fromEmail":"wjl@icecavern.net","sentAt":"2009-04-22T15:48:58Z","receivedAt":"2009-04-22T15:48:58Z","isPatch":true,"sender":{"key":"wjl@icecavern.net","avatar":"https://avatars.githubusercontent.com/u/67229?v=4"},"body":"The way the sentence is currently written, there needs to be an \"its\",\nbut this leads to: \"however the remote wildcard may be anywhere as long\nas it's its own\" which is awkward to read.\n\nInstead, this patch fixes he grammar in a simpler way.\n\nSigned-off-by: Wesley J. Landaker \n---\n Documentation/git-svn.txt | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex 3e22e40..1c40894 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -695,7 +695,7 @@ listed below are allowed:\n \n Keep in mind that the '\\*' (asterisk) wildcard of the local ref\n (right of the ':') *must* be the farthest right path component;\n-however the remote wildcard may be anywhere as long as it's own\n+however the remote wildcard may be anywhere as long as it's an\n independent path component (surrounded by '/' or EOL). This\n type of configuration is not automatically created by 'init' and\n should be manually entered with a text-editor or using 'git-config'.\n-- \n1.6.2.3\n"},{"id":"112040","messageId":"7vy6tsxao7.fsf@gitster.siamese.dyndns.org","threadId":"19003","inReplyTo":"1240415338-18076-1-git-send-email-wjl@icecavern.net","subject":"Re: [PATCH v2 1/2] Documentation: git-svn: fix spurious bolding that mangles the output","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-04-23T04:21:12Z","receivedAt":"2009-04-23T04:21:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Wesley J. Landaker\" writes:\n\n> Without this fix, the output looks like:\n>\n> \"Keep in mind that the (asterisk) wildcard of the local ref (right of\n> the :) *must be the ...\" -- with half the sentence spuriously bold.\n>\n> This fixes the problem by simply escaping asciidoc syntax as suggested\n> by Jeff King .\n>\n> Signed-off-by: Wesley J. Landaker \n\nThanks, both.\n"}]}