{"thread":{"id":"18906","subject":"[PATCH] get_local_heads(): do not return random pointer if there is no head","startedAt":"2009-04-16T22:16:23Z","lastAt":"2009-04-18T05:02:00Z","messageCount":2,"participants":["Nguyễn Thái Ngọc Duy","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"111466","messageId":"1239920183-29512-1-git-send-email-pclouds@gmail.com","threadId":"18906","inReplyTo":null,"subject":"[PATCH] get_local_heads(): do not return random pointer if there is no head","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2009-04-16T22:16:23Z","receivedAt":"2009-04-16T22:16:23Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"it's silly to do this:\n\nmkdir foo && cd foo && git init && git push somewhere.git\n\nbut segfault should not happen even in that case.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n remote.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/remote.c b/remote.c\nindex d12140e..63f749c 100644\n--- a/remote.c\n+++ b/remote.c\n@@ -1493,7 +1493,7 @@ static int one_local_ref(const char *refname, const unsigned char *sha1, int fla\n \n struct ref *get_local_heads(void)\n {\n-\tstruct ref *local_refs, **local_tail = &local_refs;\n+\tstruct ref *local_refs = NULL, **local_tail = &local_refs;\n \tfor_each_ref(one_local_ref, &local_tail);\n \treturn local_refs;\n }\n-- \n1.6.2.2.693.g5a1be\n"},{"id":"111560","messageId":"7vljpyy2pj.fsf@gitster.siamese.dyndns.org","threadId":"18906","inReplyTo":"1239920183-29512-1-git-send-email-pclouds@gmail.com","subject":"Re: [PATCH] get_local_heads(): do not return random pointer if there is no head","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-04-18T05:02:00Z","receivedAt":"2009-04-18T05:02:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:\n\n> it's silly to do this:\n>\n> mkdir foo && cd foo && git init && git push somewhere.git\n>\n> but segfault should not happen even in that case.\n\nThanks.\n"}]}