{"thread":{"id":"18780","subject":"[PATCH 2/2] Make git submodule --quiet summary obey flag","startedAt":"2009-04-08T07:05:19Z","lastAt":"2009-04-08T07:05:19Z","messageCount":1,"participants":["P Baker"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"110801","messageId":"526944450904080005q115d17b4qcfc82239fc2e4b2d@mail.gmail.com","threadId":"18780","inReplyTo":"1239172707-38915-2-git-send-email-pbaker@retrodict.com","subject":"[PATCH 2/2] Make git submodule --quiet summary obey flag","fromName":"P Baker","fromEmail":"me@retrodict.com","sentAt":"2009-04-08T07:05:19Z","receivedAt":"2009-04-08T07:05:19Z","isPatch":true,"sender":{"key":"me@retrodict.com","avatar":null},"body":"Even with flag, summary would echo output. This patch conforms\ngit-submodule to match user expectations.\n\n Signed-off-by: pbaker <pbaker@retrodict.com>\n ---\n  git-submodule.sh |   16 ++++++++--------\n  1 files changed, 8 insertions(+), 8 deletions(-)\n\n diff --git a/git-submodule.sh b/git-submodule.sh\n index 7c2e060..784c6fa 100755\n --- a/git-submodule.sh\n +++ b/git-submodule.sh\n @@ -187,7 +187,7 @@ cmd_add()\n        then\n                if test -d \"$path\"/.git -o -f \"$path\"/.git\n                then\n -                       echo \"Adding existing repo at '$path' to the index\"\n +                       say \"Adding existing repo at '$path' to the index\"\n                else\n                        die \"'$path' already exists and is not a valid git repo\"\n                fi\n @@ -450,10 +450,10 @@ cmd_summary() {\n                while read mod_src mod_dst sha1_src sha1_dst status name\n                do\n                        # Always show modules deleted or type-changed\n(blob<->module)\n -                       test $status = D -o $status = T && echo\n\"$name\" && continue\n +                       test $status = D -o $status = T && say\n\"$name\" && continue\n                        # Also show added or modified modules which\nare checked out\n                        GIT_DIR=\"$name/.git\" git-rev-parse --git-dir\n>/dev/null 2>&1 &&\n -                       echo \"$name\"\n +                       say \"$name\"\n                done\n        )\n\n @@ -522,25 +522,25 @@ cmd_summary() {\n                        total_commits=\" ($(($total_commits + 0)))\"\n                        ;;\n                esac\n -\n +\n                sha1_abbr_src=$(echo $sha1_src | cut -c1-7)\n                sha1_abbr_dst=$(echo $sha1_dst | cut -c1-7)\n                if test $status = T\n                then\n                        if test $mod_dst = 160000\n                        then\n -                               echo \"* $name\n$sha1_abbr_src(blob)->$sha1_abbr_dst(submodule)$total_commits:\"\n +                               say \"* $name\n$sha1_abbr_src(blob)->$sha1_abbr_dst(submodule)$total_commits:\"\n                        else\n -                               echo \"* $name\n$sha1_abbr_src(submodule)->$sha1_abbr_dst(blob)$total_commits:\"\n +                               say \"* $name\n$sha1_abbr_src(submodule)->$sha1_abbr_dst(blob)$total_commits:\"\n                        fi\n                else\n -                       echo \"* $name\n$sha1_abbr_src...$sha1_abbr_dst$total_commits:\"\n +                       say \"* $name\n$sha1_abbr_src...$sha1_abbr_dst$total_commits:\"\n                fi\n                if test -n \"$errmsg\"\n                then\n                        # Don't give error msg for modification whose\ndst is not submodule\n                        # i.e. deleted or changed to blob\n -                       test $mod_dst = 160000 && echo \"$errmsg\"\n +                       test $mod_dst = 160000 && echo >&2 \"$errmsg\"\n                else\n                        if test $mod_src = 160000 -a $mod_dst = 160000\n                        then\n --\n 1.6.2.1.316.gedbc2\n"}]}