{"thread":{"id":"18753","subject":"[PATCH] git-gui: fix use of undeclared variable diff_empty_count","startedAt":"2009-04-06T19:59:28Z","lastAt":"2009-04-07T08:07:02Z","messageCount":2,"participants":["Joerg Bornemann"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"110624","messageId":"49DA5F20.4030800@web.de","threadId":"18753","inReplyTo":null,"subject":"[PATCH] git-gui: fix use of undeclared variable diff_empty_count","fromName":"Joerg Bornemann","fromEmail":"joerg.bornemann@web.de","sentAt":"2009-04-06T19:59:28Z","receivedAt":"2009-04-06T19:59:28Z","isPatch":true,"sender":{"key":"joerg.bornemann@web.de","avatar":null},"body":"Commit 584fa9cc introduced the global variable diff_empty_count, which\nis used in diff.tcl. This variable wasn't declared anywhere which\nresulted in an ugly error message box instead of the intended\ninformative message.\n\nSigned-off-by: Joerg Bornemann <joerg.bornemann@web.de>\n---\n  git-gui.sh |    1 +\n  1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/git-gui.sh b/git-gui.sh\nindex e4a9230..46b056f 100755\n--- a/git-gui.sh\n+++ b/git-gui.sh\n@@ -1131,6 +1131,7 @@ set current_diff_path {}\n  set is_3way_diff 0\n  set is_conflict_diff 0\n  set selected_commit_type new\n+set diff_empty_count 0\n\n  set nullid \"0000000000000000000000000000000000000000\"\n  set nullid2 \"0000000000000000000000000000000000000001\"\n--\n1.6.0.2.1172.ga5ed0\n"},{"id":"110677","messageId":"49DB09A6.1070403@web.de","threadId":"18753","inReplyTo":"49DA5F20.4030800@web.de","subject":"Re: [PATCH] git-gui: fix use of undeclared variable diff_empty_count","fromName":"Joerg Bornemann","fromEmail":"joerg.bornemann@web.de","sentAt":"2009-04-07T08:07:02Z","receivedAt":"2009-04-07T08:07:02Z","isPatch":true,"sender":{"key":"joerg.bornemann@web.de","avatar":null},"body":"This bug occurs with msysgit under mysterious circumstances. We have at\nleast two Windows machines where \"git diff\" works correctly but \"git \ngui\" is unable to get the actual diffs. Before commit 584fa9cc, git gui \nfavoured the user with an infinite message box loop. This is what \n584fa9cc should've fixed: display a nice message to the user. Instead I \nsee the Tcl error message box, complaining about the missing variable \ndiff_empty_count.\n"}]}