{"thread":{"id":"18679","subject":"[PATCH] builtin-clone.c: no need to strdup for setenv","startedAt":"2009-04-01T11:22:25Z","lastAt":"2009-04-01T11:22:25Z","messageCount":1,"participants":["Ali Gholami Rudi"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"110121","messageId":"20090401112225.GB2237@lilem.mirepesht","threadId":"18679","inReplyTo":null,"subject":"[PATCH] builtin-clone.c: no need to strdup for setenv","fromName":"Ali Gholami Rudi","fromEmail":"ali@rudi.ir","sentAt":"2009-04-01T11:22:25Z","receivedAt":"2009-04-01T11:22:25Z","isPatch":true,"sender":{"key":"ali@rudi.ir","avatar":null},"body":"The setenv function makes a copy, itself.\n\nSigned-off-by: Ali Gholami Rudi <ali@rudi.ir>\n---\n builtin-clone.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-clone.c b/builtin-clone.c\nindex 0031b5f..28d15bb 100644\n--- a/builtin-clone.c\n+++ b/builtin-clone.c\n@@ -406,7 +406,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)\n \tatexit(remove_junk);\n \tsigchain_push_common(remove_junk_on_signal);\n \n-\tsetenv(CONFIG_ENVIRONMENT, xstrdup(mkpath(\"%s/config\", git_dir)), 1);\n+\tsetenv(CONFIG_ENVIRONMENT, mkpath(\"%s/config\", git_dir), 1);\n \n \tif (safe_create_leading_directories_const(git_dir) < 0)\n \t\tdie(\"could not create leading directories of '%s'\", git_dir);\n"}]}