{"thread":{"id":"18676","subject":"[PATCH] git-gui (Win): make \"Explore Working Copy\" more robust","startedAt":"2009-03-31T23:55:36Z","lastAt":"2009-03-31T23:55:36Z","messageCount":1,"participants":["Markus Heidelberg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"110082","messageId":"200904010155.37318.markus.heidelberg@web.de","threadId":"18676","inReplyTo":null,"subject":"[PATCH] git-gui (Win): make \"Explore Working Copy\" more robust","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2009-03-31T23:55:36Z","receivedAt":"2009-03-31T23:55:36Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"\nStarting the Explorer from the git-gui menu \"Explore Working Copy\"\ndidn't work, when git-gui was started via Windows Explorer shell\nextension (Git GUI Here) from a directory within the project.\nThe Explorer raised an error message like this:\n\n    Path \"C:/somedir/worktree\" is not available or not a directory\n\nIt worked when started from the project directory itself, because then\nthe path argument for the Explorer was just '.' (current directory)\nwithout any problematic forward slashes.\n\nTo make it work, convert the path given as argument to explorer.exe to\nits native format with backslashes.\n\nSigned-off-by: Markus Heidelberg <markus.heidelberg@web.de>\n---\n\nNow this is the real location of the problem in contrast of the\nworkaround attempt from 2 days before.\nI've also tested this change with xdg-open.\n\n git-gui.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-gui.sh b/git-gui.sh\nindex b3aa732..712fe27 100755\n--- a/git-gui.sh\n+++ b/git-gui.sh\n@@ -1924,7 +1924,7 @@ proc do_explore {} {\n \t\t# freedesktop.org-conforming system is our best shot\n \t\tset explorer \"xdg-open\"\n \t}\n-\teval exec $explorer [file dirname [gitdir]] &\n+\teval exec $explorer [list [file nativename [file dirname [gitdir]]]] &\n }\n \n set is_quitting 0\n-- \n1.6.2.1.428.g41b20c\n"}]}