{"thread":{"id":"18619","subject":"[PATCH] git-svn: don't output git commits in quiet mode","startedAt":"2009-03-29T19:34:50Z","lastAt":"2009-04-02T05:24:55Z","messageCount":6,"participants":["Simon Arlott","Eric Wong","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"109781","messageId":"49CFCD5A.1080801@simon.arlott.org.uk","threadId":"18619","inReplyTo":null,"subject":"[PATCH] git-svn: don't output git commits in quiet mode","fromName":"Simon Arlott","fromEmail":"simon@fire.lp0.eu","sentAt":"2009-03-29T19:34:50Z","receivedAt":"2009-03-29T19:34:50Z","isPatch":true,"sender":{"key":"simon@fire.lp0.eu","avatar":"https://avatars.githubusercontent.com/u/70171?v=4"},"body":"Ideally only errors should be output in this mode so fetch\ncan be run from cron and normally produce no output. Without\nthis change it would output a single line on each git commit,\ne.g.\nr1909 = 32ef87860662526d4a62f903949ed21e0341079e (u2_10_12_branch)\n\nSigned-off-by: Simon Arlott \n---\n git-svn.perl | 6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 8be6be0..e100b69 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -2331,13 +2331,13 @@ sub do_git_commit {\n \n \t$self->{last_rev} = $log_entry->{revision};\n \t$self->{last_commit} = $commit;\n-\tprint \"r$log_entry->{revision}\";\n+\tprint \"r$log_entry->{revision}\" unless $::_q;\n \tif (defined $log_entry->{svm_revision}) {\n-\t\t print \" (\\@$log_entry->{svm_revision})\";\n+\t\t print \" (\\@$log_entry->{svm_revision})\" unless $::_q;\n \t\t $self->rev_map_set($log_entry->{svm_revision}, $commit,\n \t\t 0, $self->svm_uuid);\n \t}\n-\tprint \" = $commit ($self->{ref_id})\\n\";\n+\tprint \" = $commit ($self->{ref_id})\\n\" unless $::_q;\n \tif (--$_gc_nr == 0) {\n \t\t$_gc_nr = $_gc_period;\n \t\tgc();\n-- \n1.6.2\n\n-- \nSimon Arlott\n"},{"id":"109796","messageId":"20090329224324.GB20675@dcvr.yhbt.net","threadId":"18619","inReplyTo":"49CFCD5A.1080801@simon.arlott.org.uk","subject":"Re: [PATCH] git-svn: don't output git commits in quiet mode","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2009-03-29T22:43:24Z","receivedAt":"2009-03-29T22:43:24Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Simon Arlott wrote:\n> Ideally only errors should be output in this mode so fetch\n> can be run from cron and normally produce no output. Without\n> this change it would output a single line on each git commit,\n> e.g.\n> r1909 = 32ef87860662526d4a62f903949ed21e0341079e (u2_10_12_branch)\n> \n> Signed-off-by: Simon Arlott \n\nThanks Simon,\n\nAcked-by: Eric Wong \n\nand pushed to git://git.bogomips.org/git-svn\n\n> ---\n> git-svn.perl | 6 +++---\n> 1 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/git-svn.perl b/git-svn.perl\n> index 8be6be0..e100b69 100755\n> --- a/git-svn.perl\n> +++ b/git-svn.perl\n> @@ -2331,13 +2331,13 @@ sub do_git_commit {\n> \n> \t$self->{last_rev} = $log_entry->{revision};\n> \t$self->{last_commit} = $commit;\n> -\tprint \"r$log_entry->{revision}\";\n> +\tprint \"r$log_entry->{revision}\" unless $::_q;\n> \tif (defined $log_entry->{svm_revision}) {\n> -\t\t print \" (\\@$log_entry->{svm_revision})\";\n> +\t\t print \" (\\@$log_entry->{svm_revision})\" unless $::_q;\n> \t\t $self->rev_map_set($log_entry->{svm_revision}, $commit,\n> \t\t 0, $self->svm_uuid);\n> \t}\n> -\tprint \" = $commit ($self->{ref_id})\\n\";\n> +\tprint \" = $commit ($self->{ref_id})\\n\" unless $::_q;\n> \tif (--$_gc_nr == 0) {\n> \t\t$_gc_nr = $_gc_period;\n> \t\tgc();\n> -- \n> 1.6.2\n"},{"id":"109836","messageId":"7vvdprjyrc.fsf@gitster.siamese.dyndns.org","threadId":"18619","inReplyTo":"20090329224324.GB20675@dcvr.yhbt.net","subject":"Re: [PATCH] git-svn: don't output git commits in quiet mode","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-03-30T06:44:23Z","receivedAt":"2009-03-30T06:44:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong writes:\n\n> Simon Arlott wrote:\n>> Ideally only errors should be output in this mode so fetch\n>> can be run from cron and normally produce no output. Without\n>> this change it would output a single line on each git commit,\n>> e.g.\n>> r1909 = 32ef87860662526d4a62f903949ed21e0341079e (u2_10_12_branch)\n>> \n>> Signed-off-by: Simon Arlott \n>\n> Thanks Simon,\n>\n> Acked-by: Eric Wong \n>\n> and pushed to git://git.bogomips.org/git-svn\n\n... and pulled from there. Thanks, both.\n"},{"id":"109935","messageId":"49D1100D.8010206@simon.arlott.org.uk","threadId":"18619","inReplyTo":"7vvdprjyrc.fsf@gitster.siamese.dyndns.org","subject":"[PATCH] git-svn: add a double quiet option to hide git commits","fromName":"Simon Arlott","fromEmail":"simon@fire.lp0.eu","sentAt":"2009-03-30T18:31:41Z","receivedAt":"2009-03-30T18:31:41Z","isPatch":true,"sender":{"key":"simon@fire.lp0.eu","avatar":"https://avatars.githubusercontent.com/u/70171?v=4"},"body":"People may expect/prefer -q to still show git commits,\nso this change allows a second -q to hide them.\n\nSigned-off-by: Michael Poole \nSigned-off-by: Simon Arlott \n---\nOn 30/03/09 07:44, Junio C Hamano wrote:\n> Eric Wong writes:\n>> Simon Arlott wrote:\n>>> Ideally only errors should be output in this mode so fetch\n>>> can be run from cron and normally produce no output. Without\n>>> this change it would output a single line on each git commit,\n>>> e.g.\n>>> r1909 = 32ef87860662526d4a62f903949ed21e0341079e (u2_10_12_branch)\n\n Documentation/git-svn.txt | 3 ++-\n git-svn.perl | 9 +++++----\n 2 files changed, 7 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex cda3389..8163a19 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -385,7 +385,8 @@ config key: svn.authorsfile\n \n -q::\n --quiet::\n-\tMake 'git-svn' less verbose.\n+\tMake 'git-svn' less verbose. Specify a second time to make it\n+\teven less verbose.\n \n --repack[=]::\n --repack-flags=::\ndiff --git a/git-svn.perl b/git-svn.perl\nindex e5c3dfe..d919798 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -68,6 +68,7 @@ my ($_stdin, $_help, $_edit,\n \t$_prefix, $_no_checkout, $_url, $_verbose,\n \t$_git_format, $_commit_url, $_tag);\n $Git::SVN::_follow_parent = 1;\n+$_q ||= 0;\n my %remote_opts = ( 'username=s' => \\$Git::SVN::Prompt::_username,\n 'config-dir=s' => \\$Git::SVN::Ra::config_dir,\n 'no-auth-cache' => \\$Git::SVN::Prompt::_no_auth_cache,\n@@ -80,7 +81,7 @@ my %fc_opts = ( 'follow-parent|follow!' => \\$Git::SVN::_follow_parent,\n \t\t'useSvnsyncProps' => \\$Git::SVN::_use_svnsync_props,\n \t\t'log-window-size=i' => \\$Git::SVN::Ra::_log_window_size,\n \t\t'no-checkout' => \\$_no_checkout,\n-\t\t'quiet|q' => \\$_q,\n+\t\t'quiet|q+' => \\$_q,\n \t\t'repack-flags|repack-args|repack-opts=s' =>\n \t\t \\$Git::SVN::_repack_flags,\n \t\t'use-log-author' => \\$Git::SVN::_use_log_author,\n@@ -2331,13 +2332,13 @@ sub do_git_commit {\n \n \t$self->{last_rev} = $log_entry->{revision};\n \t$self->{last_commit} = $commit;\n-\tprint \"r$log_entry->{revision}\" unless $::_q;\n+\tprint \"r$log_entry->{revision}\" unless $::_q > 1;\n \tif (defined $log_entry->{svm_revision}) {\n-\t\t print \" (\\@$log_entry->{svm_revision})\" unless $::_q;\n+\t\t print \" (\\@$log_entry->{svm_revision})\" unless $::_q > 1;\n \t\t $self->rev_map_set($log_entry->{svm_revision}, $commit,\n \t\t 0, $self->svm_uuid);\n \t}\n-\tprint \" = $commit ($self->{ref_id})\\n\" unless $::_q;\n+\tprint \" = $commit ($self->{ref_id})\\n\" unless $::_q > 1;\n \tif (--$_gc_nr == 0) {\n \t\t$_gc_nr = $_gc_period;\n \t\tgc();\n-- \n1.6.2\n-- \nSimon Arlott\n"},{"id":"109977","messageId":"20090331065231.GA32142@dcvr.yhbt.net","threadId":"18619","inReplyTo":"49D1100D.8010206@simon.arlott.org.uk","subject":"Re: [PATCH] git-svn: add a double quiet option to hide git commits","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2009-03-31T06:52:31Z","receivedAt":"2009-03-31T06:52:31Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Simon Arlott wrote:\n> People may expect/prefer -q to still show git commits,\n> so this change allows a second -q to hide them.\n> \n> Signed-off-by: Michael Poole \n> Signed-off-by: Simon Arlott \n\nThanks,\n Acked-by: Eric Wong \nand pushed out to git://git.bogomips.org/git-svn\n\n> ---\n> On 30/03/09 07:44, Junio C Hamano wrote:\n> > Eric Wong writes:\n> >> Simon Arlott wrote:\n> >>> Ideally only errors should be output in this mode so fetch\n> >>> can be run from cron and normally produce no output. Without\n> >>> this change it would output a single line on each git commit,\n> >>> e.g.\n> >>> r1909 = 32ef87860662526d4a62f903949ed21e0341079e (u2_10_12_branch)\n> \n> Documentation/git-svn.txt | 3 ++-\n> git-svn.perl | 9 +++++----\n> 2 files changed, 7 insertions(+), 5 deletions(-)\n> \n> diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\n> index cda3389..8163a19 100644\n> --- a/Documentation/git-svn.txt\n> +++ b/Documentation/git-svn.txt\n> @@ -385,7 +385,8 @@ config key: svn.authorsfile\n> \n> -q::\n> --quiet::\n> -\tMake 'git-svn' less verbose.\n> +\tMake 'git-svn' less verbose. Specify a second time to make it\n> +\teven less verbose.\n> \n> --repack[=]::\n> --repack-flags=::\n> diff --git a/git-svn.perl b/git-svn.perl\n> index e5c3dfe..d919798 100755\n> --- a/git-svn.perl\n> +++ b/git-svn.perl\n> @@ -68,6 +68,7 @@ my ($_stdin, $_help, $_edit,\n> \t$_prefix, $_no_checkout, $_url, $_verbose,\n> \t$_git_format, $_commit_url, $_tag);\n> $Git::SVN::_follow_parent = 1;\n> +$_q ||= 0;\n> my %remote_opts = ( 'username=s' => \\$Git::SVN::Prompt::_username,\n> 'config-dir=s' => \\$Git::SVN::Ra::config_dir,\n> 'no-auth-cache' => \\$Git::SVN::Prompt::_no_auth_cache,\n> @@ -80,7 +81,7 @@ my %fc_opts = ( 'follow-parent|follow!' => \\$Git::SVN::_follow_parent,\n> \t\t'useSvnsyncProps' => \\$Git::SVN::_use_svnsync_props,\n> \t\t'log-window-size=i' => \\$Git::SVN::Ra::_log_window_size,\n> \t\t'no-checkout' => \\$_no_checkout,\n> -\t\t'quiet|q' => \\$_q,\n> +\t\t'quiet|q+' => \\$_q,\n> \t\t'repack-flags|repack-args|repack-opts=s' =>\n> \t\t \\$Git::SVN::_repack_flags,\n> \t\t'use-log-author' => \\$Git::SVN::_use_log_author,\n> @@ -2331,13 +2332,13 @@ sub do_git_commit {\n> \n> \t$self->{last_rev} = $log_entry->{revision};\n> \t$self->{last_commit} = $commit;\n> -\tprint \"r$log_entry->{revision}\" unless $::_q;\n> +\tprint \"r$log_entry->{revision}\" unless $::_q > 1;\n> \tif (defined $log_entry->{svm_revision}) {\n> -\t\t print \" (\\@$log_entry->{svm_revision})\" unless $::_q;\n> +\t\t print \" (\\@$log_entry->{svm_revision})\" unless $::_q > 1;\n> \t\t $self->rev_map_set($log_entry->{svm_revision}, $commit,\n> \t\t 0, $self->svm_uuid);\n> \t}\n> -\tprint \" = $commit ($self->{ref_id})\\n\" unless $::_q;\n> +\tprint \" = $commit ($self->{ref_id})\\n\" unless $::_q > 1;\n> \tif (--$_gc_nr == 0) {\n> \t\t$_gc_nr = $_gc_period;\n> \t\tgc();\n> -- \n> 1.6.2\n> -- \n> Simon Arlott\n"},{"id":"110191","messageId":"7vk563k4pk.fsf@gitster.siamese.dyndns.org","threadId":"18619","inReplyTo":"20090331065231.GA32142@dcvr.yhbt.net","subject":"Re: [PATCH] git-svn: add a double quiet option to hide git commits","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-04-02T05:24:55Z","receivedAt":"2009-04-02T05:24:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong writes:\n\n> Simon Arlott wrote:\n>> People may expect/prefer -q to still show git commits,\n>> so this change allows a second -q to hide them.\n>> \n>> Signed-off-by: Michael Poole \n>> Signed-off-by: Simon Arlott \n>\n> Thanks,\n> Acked-by: Eric Wong \n> and pushed out to git://git.bogomips.org/git-svn\n\nThanks, and pulled.\n"}]}