{"thread":{"id":"18547","subject":"[PATCH 1/2] t7005-editor: Use $SHELL_PATH in the editor scripts","startedAt":"2009-03-25T20:31:26Z","lastAt":"2009-03-25T20:33:46Z","messageCount":2,"participants":["Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"109410","messageId":"200903252131.26561.j6t@kdbg.org","threadId":"18547","inReplyTo":null,"subject":"[PATCH 1/2] t7005-editor: Use $SHELL_PATH in the editor scripts","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2009-03-25T20:31:26Z","receivedAt":"2009-03-25T20:31:26Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"The test sets up various shell scripts and uses them as commit message\neditors.  On Windows, we need a shebang line in order to recognize the\nfiles as executable shell scripts.  This adds it.\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n This one and the next patch can go on top of js/windows-tests.\n Or you again pull from\n\n   git://repo.or.cz/git/mingw/j6t.git for-junio\n\n -- Hannes\n\n t/t7005-editor.sh |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/t/t7005-editor.sh b/t/t7005-editor.sh\nindex 2f8404a..e83bc8f 100755\n--- a/t/t7005-editor.sh\n+++ b/t/t7005-editor.sh\n@@ -7,6 +7,7 @@ test_description='GIT_EDITOR, core.editor, and stuff'\n for i in GIT_EDITOR core_editor EDITOR VISUAL vi\n do\n \tcat >e-$i.sh <<-EOF\n+\t#!$SHELL_PATH\n \techo \"Edited by $i\" >\"\\$1\"\n \tEOF\n \tchmod +x e-$i.sh\n-- \n1.6.2.1.224.g2225f\n"},{"id":"109411","messageId":"200903252133.46594.j6t@kdbg.org","threadId":"18547","inReplyTo":"200903252131.26561.j6t@kdbg.org","subject":"[PATCH 2/2] t7502-commit: Skip SIGTERM test on Windows","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2009-03-25T20:33:46Z","receivedAt":"2009-03-25T20:33:46Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"The implementation of exec on Windows is just a rough approximation of the\nPOSIX behavior. In particular, no real process \"overlay\" happens (a new\nprocess is spawned instead and the parent process waits until the child\nterminates). In particular, the process ID cannot be taken by the exec'd\nprocess. But there is one test in t7502-commit.sh that depends on this.\nWe have to skip it on Windows.\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n t/t7502-commit.sh |    2 +-\n t/test-lib.sh     |    2 ++\n 2 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t7502-commit.sh b/t/t7502-commit.sh\nindex ad42c78..56cd866 100755\n--- a/t/t7502-commit.sh\n+++ b/t/t7502-commit.sh\n@@ -234,7 +234,7 @@ cat >.git/FAKE_EDITOR <<EOF\n # kill -TERM command added below.\n EOF\n \n-test_expect_success 'a SIGTERM should break locks' '\n+test_expect_success EXECKEEPSPID 'a SIGTERM should break locks' '\n \techo >>negative &&\n \t! \"$SHELL_PATH\" -c '\\''\n \t  echo kill -TERM $$ >> .git/FAKE_EDITOR\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex 8de5ee1..2979e8e 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -697,10 +697,12 @@ case $(uname -s) in\n \t}\n \t# no POSIX permissions\n \t# backslashes in pathspec are converted to '/'\n+\t# exec does not inherit the PID\n \t;;\n *)\n \ttest_set_prereq POSIXPERM\n \ttest_set_prereq BSLASHPSPEC\n+\ttest_set_prereq EXECKEEPSPID\n \t;;\n esac\n \n-- \n1.6.2.1.224.g2225f\n"}]}