{"thread":{"id":"18537","subject":"[PATCH] Guard a few Makefile variables against user environments","startedAt":"2009-03-25T16:27:28Z","lastAt":"2009-03-25T16:27:28Z","messageCount":1,"participants":["Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"109372","messageId":"1d60c2034e0b5058cb691f572eb57f0aefb9fdc7.1237998428u.git.johannes.schindelin@gmx.de","threadId":"18537","inReplyTo":"cover.1237998428u.git.johannes.schindelin@gmx.de","subject":"[PATCH] Guard a few Makefile variables against user environments","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-03-25T16:27:28Z","receivedAt":"2009-03-25T16:27:28Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Some variables are not initialized in the Makefile, but appended to.  If\nthe user has those variables in her environment, it will break the\nbuild.\n\nThe variable names were found using these commands:\n\n\t$ s='[ \\t]';\n\t$ S='[^ \\t]';\n\t$ comm -23 \\\n\t\t<(sed -n \"s/^$s*\\($S*\\)$s$s*+=.*/\\1/p\" < Makefile |\n\t\t  sort | uniq) \\\n\t\t<(sed -n \"s/^$s*\\($S*\\)$s$s*=.*/\\1/p\" < Makefile |\n\t\t  sort | uniq)\n\nThis fixes msysGit issue 216.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n Makefile |   12 ++++++++++++\n 1 files changed, 12 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 43a8364..d77fd71 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -263,6 +263,18 @@ SPARSE_FLAGS = -D__BIG_ENDIAN__ -D__powerpc__\n BASIC_CFLAGS =\n BASIC_LDFLAGS =\n \n+# Guard against environment variables\n+BUILTIN_OBJS =\n+BUILT_INS =\n+COMPAT_CFLAGS =\n+COMPAT_OBJS =\n+LIB_H =\n+LIB_OBJS =\n+PROGRAMS =\n+SCRIPT_PERL =\n+SCRIPT_SH =\n+TEST_PROGRAMS =\n+\n SCRIPT_SH += git-am.sh\n SCRIPT_SH += git-bisect.sh\n SCRIPT_SH += git-difftool-helper.sh\n-- \n1.6.2.1.493.g67cf3\n"}]}