{"thread":{"id":"18499","subject":"[PATCH 2/9] builtin-apply: use warning() instead of fprintf(stderr, \"warning: \")","startedAt":"2009-03-24T01:09:08Z","lastAt":"2009-03-24T08:01:33Z","messageCount":16,"participants":["Miklos Vajna","Erik Faye-Lund","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":9},"messages":[{"id":"109130","messageId":"cover.1237856682.git.vmiklos@frugalware.org","threadId":"18499","inReplyTo":"7v3ad5dxt5.fsf@gitster.siamese.dyndns.org","subject":"[PATCH 0/9] fprintf(stderr, \"warning: \") -> warning() patches","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2009-03-24T01:09:08Z","receivedAt":"2009-03-24T01:09:08Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Sun, Mar 22, 2009 at 02:58:46PM -0700, Junio C Hamano wrote:\n> > Should I rebase the series against current master and resend?\n>\n> Yes, please, if the overlap with \"diff master next\" is small enough.\n\nOkay, here it is, applies on top of master. All, except the http-push\none, applies cleanly on top of next as well here.\n\nMiklos Vajna (9):\n http-push: using error() and warning() as appropriate\n builtin-apply: use warning() instead of fprintf(stderr, \"warning: \")\n builtin-checkout: use warning() instead of fprintf(stderr, \"warning:\n \")\n builtin-fetch-pack: use warning() instead of fprintf(stderr,\n \"warning: \")\n builtin-init-db: use warning() instead of fprintf(stderr, \"warning:\n \")\n builtin-rm: use warning() instead of fprintf(stderr, \"warning: \")\n builtin-show-branch: use warning() instead of fprintf(stderr,\n \"warning: \")\n builtin-show-ref: use warning() instead of fprintf(stderr, \"warning:\n \")\n refs: use warning() instead of fprintf(stderr, \"warning: \")\n\n builtin-apply.c | 15 +++++++--------\n builtin-checkout.c | 4 ++--\n builtin-fetch-pack.c | 2 +-\n builtin-init-db.c | 7 +++----\n builtin-rm.c | 3 +--\n builtin-show-branch.c | 3 +--\n builtin-show-ref.c | 2 +-\n http-push.c | 6 +++---\n refs.c | 8 +++-----\n 9 files changed, 22 insertions(+), 28 deletions(-)\n"},{"id":"109136","messageId":"1fcc4848dd7a24f846bb302bbb555bf1bac795a5.1237856682.git.vmiklos@frugalware.org","threadId":"18499","inReplyTo":"cover.1237856682.git.vmiklos@frugalware.org","subject":"[PATCH 1/9] http-push: using error() and warning() as appropriate","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2009-03-24T01:09:09Z","receivedAt":"2009-03-24T01:09:09Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Change three occurences of using inconsistent error/warning reporting by\nusing the relevant error() / warning() calls to be consitent with the\nrest of the code.\n\nSigned-off-by: Miklos Vajna \n---\n http-push.c | 6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/http-push.c b/http-push.c\nindex 48e5f38..e6bd01a 100644\n--- a/http-push.c\n+++ b/http-push.c\n@@ -759,7 +759,7 @@ static void finish_request(struct transfer_request *request)\n \t\t\t}\n \t\t} else {\n \t\t\tif (request->http_code == 416)\n-\t\t\t\tfprintf(stderr, \"Warning: requested range invalid; we may already have all the data.\\n\");\n+\t\t\t\twarning(\"requested range invalid; we may already have all the data.\");\n \n \t\t\tgit_inflate_end(&request->stream);\n \t\t\tgit_SHA1_Final(request->real_sha1, &request->c);\n@@ -1616,7 +1616,7 @@ static int locking_available(void)\n \t\t\t}\n \t\t\tXML_ParserFree(parser);\n \t\t\tif (!lock_flags)\n-\t\t\t\terror(\"Error: no DAV locking support on %s\",\n+\t\t\t\terror(\"no DAV locking support on %s\",\n \t\t\t\t remote->url);\n \n \t\t} else {\n@@ -2225,7 +2225,7 @@ int main(int argc, char **argv)\n \t\tif (info_ref_lock)\n \t\t\tremote->can_update_info_refs = 1;\n \t\telse {\n-\t\t\tfprintf(stderr, \"Error: cannot lock existing info/refs\\n\");\n+\t\t\terror(\"cannot lock existing info/refs\");\n \t\t\trc = 1;\n \t\t\tgoto cleanup;\n \t\t}\n-- \n1.6.2\n"},{"id":"109127","messageId":"9287282d966904f06ae4b3d7cfdf1d79eb645b69.1237856682.git.vmiklos@frugalware.org","threadId":"18499","inReplyTo":"1fcc4848dd7a24f846bb302bbb555bf1bac795a5.1237856682.git.vmiklos@frugalware.org","subject":"[PATCH 2/9] builtin-apply: use warning() instead of fprintf(stderr, \"warning: \")","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2009-03-24T01:09:10Z","receivedAt":"2009-03-24T01:09:10Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Signed-off-by: Miklos Vajna \n---\n builtin-apply.c | 15 +++++++--------\n 1 files changed, 7 insertions(+), 8 deletions(-)\n\ndiff --git a/builtin-apply.c b/builtin-apply.c\nindex b52aa20..1926cd8 100644\n--- a/builtin-apply.c\n+++ b/builtin-apply.c\n@@ -2451,7 +2451,7 @@ static int check_preimage(struct patch *patch, struct cache_entry **ce, struct s\n \tif ((st_mode ^ patch->old_mode) & S_IFMT)\n \t\treturn error(\"%s: wrong type\", old_name);\n \tif (st_mode != patch->old_mode)\n-\t\tfprintf(stderr, \"warning: %s has type %o, expected %o\\n\",\n+\t\twarning(\"%s has type %o, expected %o\",\n \t\t\told_name, st_mode, patch->old_mode);\n \tif (!patch->new_mode && !patch->is_delete)\n \t\tpatch->new_mode = st_mode;\n@@ -2932,8 +2932,7 @@ static int write_out_one_reject(struct patch *patch)\n \tcnt = strlen(patch->new_name);\n \tif (ARRAY_SIZE(namebuf) <= cnt + 5) {\n \t\tcnt = ARRAY_SIZE(namebuf) - 5;\n-\t\tfprintf(stderr,\n-\t\t\t\"warning: truncating .rej filename to %.*s.rej\",\n+\t\twarning(\"truncating .rej filename to %.*s.rej\",\n \t\t\tcnt - 1, patch->new_name);\n \t}\n \tmemcpy(namebuf, patch->new_name, cnt);\n@@ -3315,8 +3314,8 @@ int cmd_apply(int argc, const char **argv, const char *unused_prefix)\n \t\t squelch_whitespace_errors < whitespace_error) {\n \t\t\tint squelched =\n \t\t\t\twhitespace_error - squelch_whitespace_errors;\n-\t\t\tfprintf(stderr, \"warning: squelched %d \"\n-\t\t\t\t\"whitespace error%s\\n\",\n+\t\t\twarning(\"squelched %d \"\n+\t\t\t\t\"whitespace error%s\",\n \t\t\t\tsquelched,\n \t\t\t\tsquelched == 1 ? \"\" : \"s\");\n \t\t}\n@@ -3326,12 +3325,12 @@ int cmd_apply(int argc, const char **argv, const char *unused_prefix)\n \t\t\t whitespace_error == 1 ? \"\" : \"s\",\n \t\t\t whitespace_error == 1 ? \"s\" : \"\");\n \t\tif (applied_after_fixing_ws && apply)\n-\t\t\tfprintf(stderr, \"warning: %d line%s applied after\"\n-\t\t\t\t\" fixing whitespace errors.\\n\",\n+\t\t\twarning(\"%d line%s applied after\"\n+\t\t\t\t\" fixing whitespace errors.\",\n \t\t\t\tapplied_after_fixing_ws,\n \t\t\t\tapplied_after_fixing_ws == 1 ? \"\" : \"s\");\n \t\telse if (whitespace_error)\n-\t\t\tfprintf(stderr, \"warning: %d line%s add%s whitespace errors.\\n\",\n+\t\t\twarning(\"%d line%s add%s whitespace errors.\",\n \t\t\t\twhitespace_error,\n \t\t\t\twhitespace_error == 1 ? \"\" : \"s\",\n \t\t\t\twhitespace_error == 1 ? \"s\" : \"\");\n-- \n1.6.2\n"},{"id":"109128","messageId":"a1165f8583c71de7fb053e83ddf1d7acd2e48024.1237856682.git.vmiklos@frugalware.org","threadId":"18499","inReplyTo":"9287282d966904f06ae4b3d7cfdf1d79eb645b69.1237856682.git.vmiklos@frugalware.org","subject":"[PATCH 3/9] builtin-checkout: use warning() instead of fprintf(stderr, \"warning: \")","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2009-03-24T01:09:11Z","receivedAt":"2009-03-24T01:09:11Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Signed-off-by: Miklos Vajna \n---\n builtin-checkout.c | 4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin-checkout.c b/builtin-checkout.c\nindex 9fdfc58..fc55bbe 100644\n--- a/builtin-checkout.c\n+++ b/builtin-checkout.c\n@@ -558,8 +558,8 @@ static int switch_branches(struct checkout_opts *opts, struct branch_info *new)\n \n \tif (!old.commit && !opts->force) {\n \t\tif (!opts->quiet) {\n-\t\t\tfprintf(stderr, \"warning: You appear to be on a branch yet to be born.\\n\");\n-\t\t\tfprintf(stderr, \"warning: Forcing checkout of %s.\\n\", new->name);\n+\t\t\twarning(\"You appear to be on a branch yet to be born.\");\n+\t\t\twarning(\"Forcing checkout of %s.\", new->name);\n \t\t}\n \t\topts->force = 1;\n \t}\n-- \n1.6.2\n"},{"id":"109132","messageId":"d499d514cd704edfc54ad62422e77aca275c9527.1237856682.git.vmiklos@frugalware.org","threadId":"18499","inReplyTo":"a1165f8583c71de7fb053e83ddf1d7acd2e48024.1237856682.git.vmiklos@frugalware.org","subject":"[PATCH 4/9] builtin-fetch-pack: use warning() instead of fprintf(stderr, \"warning: \")","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2009-03-24T01:09:12Z","receivedAt":"2009-03-24T01:09:12Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"---\n builtin-fetch-pack.c | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-fetch-pack.c b/builtin-fetch-pack.c\nindex d571253..5d134be 100644\n--- a/builtin-fetch-pack.c\n+++ b/builtin-fetch-pack.c\n@@ -605,7 +605,7 @@ static struct ref *do_fetch_pack(int fd[2],\n \t\t\t/* When cloning, it is not unusual to have\n \t\t\t * no common commit.\n \t\t\t */\n-\t\t\tfprintf(stderr, \"warning: no common commits\\n\");\n+\t\t\twarning(\"no common commits\");\n \n \tif (get_pack(fd, pack_lockfile))\n \t\tdie(\"git fetch-pack: fetch failed.\");\n-- \n1.6.2\n"},{"id":"109131","messageId":"6ca31ce7256d8945f520b7d57e2a14b890731abd.1237856682.git.vmiklos@frugalware.org","threadId":"18499","inReplyTo":"d499d514cd704edfc54ad62422e77aca275c9527.1237856682.git.vmiklos@frugalware.org","subject":"[PATCH 5/9] builtin-init-db: use warning() instead of fprintf(stderr, \"warning: \")","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2009-03-24T01:09:13Z","receivedAt":"2009-03-24T01:09:13Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"---\n builtin-init-db.c | 7 +++----\n 1 files changed, 3 insertions(+), 4 deletions(-)\n\ndiff --git a/builtin-init-db.c b/builtin-init-db.c\nindex ee3911f..fc63d0f 100644\n--- a/builtin-init-db.c\n+++ b/builtin-init-db.c\n@@ -130,8 +130,7 @@ static void copy_templates(const char *template_dir)\n \t}\n \tdir = opendir(template_path);\n \tif (!dir) {\n-\t\tfprintf(stderr, \"warning: templates not found %s\\n\",\n-\t\t\ttemplate_dir);\n+\t\twarning(\"templates not found %s\", template_dir);\n \t\treturn;\n \t}\n \n@@ -144,8 +143,8 @@ static void copy_templates(const char *template_dir)\n \n \tif (repository_format_version &&\n \t repository_format_version != GIT_REPO_VERSION) {\n-\t\tfprintf(stderr, \"warning: not copying templates of \"\n-\t\t\t\"a wrong format version %d from '%s'\\n\",\n+\t\twarning(\"not copying templates of \"\n+\t\t\t\"a wrong format version %d from '%s'\",\n \t\t\trepository_format_version,\n \t\t\ttemplate_dir);\n \t\tclosedir(dir);\n-- \n1.6.2\n"},{"id":"109133","messageId":"83e5caf5764a146779d8cefbf874f540a6160eb4.1237856682.git.vmiklos@frugalware.org","threadId":"18499","inReplyTo":"6ca31ce7256d8945f520b7d57e2a14b890731abd.1237856682.git.vmiklos@frugalware.org","subject":"[PATCH 6/9] builtin-rm: use warning() instead of fprintf(stderr, \"warning: \")","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2009-03-24T01:09:14Z","receivedAt":"2009-03-24T01:09:14Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Signed-off-by: Miklos Vajna \n---\n builtin-rm.c | 3 +--\n 1 files changed, 1 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin-rm.c b/builtin-rm.c\nindex c11f455..269d608 100644\n--- a/builtin-rm.c\n+++ b/builtin-rm.c\n@@ -59,8 +59,7 @@ static int check_local_mod(unsigned char *head, int index_only)\n \n \t\tif (lstat(ce->name, &st) < 0) {\n \t\t\tif (errno != ENOENT)\n-\t\t\t\tfprintf(stderr, \"warning: '%s': %s\",\n-\t\t\t\t\tce->name, strerror(errno));\n+\t\t\t\twarning(\"'%s': %s\", ce->name, strerror(errno));\n \t\t\t/* It already vanished from the working tree */\n \t\t\tcontinue;\n \t\t}\n-- \n1.6.2\n"},{"id":"109134","messageId":"5e3412be5d72bce2bf36fdcc2734b89386fdfc21.1237856682.git.vmiklos@frugalware.org","threadId":"18499","inReplyTo":"83e5caf5764a146779d8cefbf874f540a6160eb4.1237856682.git.vmiklos@frugalware.org","subject":"[PATCH 7/9] builtin-show-branch: use warning() instead of fprintf(stderr, \"warning: \")","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2009-03-24T01:09:15Z","receivedAt":"2009-03-24T01:09:15Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Signed-off-by: Miklos Vajna \n---\n builtin-show-branch.c | 3 +--\n 1 files changed, 1 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin-show-branch.c b/builtin-show-branch.c\nindex 306b850..828e6f8 100644\n--- a/builtin-show-branch.c\n+++ b/builtin-show-branch.c\n@@ -365,8 +365,7 @@ static int append_ref(const char *refname, const unsigned char *sha1,\n \t\t\t\treturn 0;\n \t}\n \tif (MAX_REVS <= ref_name_cnt) {\n-\t\tfprintf(stderr, \"warning: ignoring %s; \"\n-\t\t\t\"cannot handle more than %d refs\\n\",\n+\t\twarning(\"ignoring %s; cannot handle more than %d refs\",\n \t\t\trefname, MAX_REVS);\n \t\treturn 0;\n \t}\n-- \n1.6.2\n"},{"id":"109135","messageId":"607f1ab07464931305b62599805f898e2bf2ca98.1237856682.git.vmiklos@frugalware.org","threadId":"18499","inReplyTo":"5e3412be5d72bce2bf36fdcc2734b89386fdfc21.1237856682.git.vmiklos@frugalware.org","subject":"[PATCH 8/9] builtin-show-ref: use warning() instead of fprintf(stderr, \"warning: \")","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2009-03-24T01:09:16Z","receivedAt":"2009-03-24T01:09:16Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Signed-off-by: Miklos Vajna \n---\n builtin-show-ref.c | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-show-ref.c b/builtin-show-ref.c\nindex 572b114..dc76c50 100644\n--- a/builtin-show-ref.c\n+++ b/builtin-show-ref.c\n@@ -140,7 +140,7 @@ static int exclude_existing(const char *match)\n \t\t\t\tcontinue;\n \t\t}\n \t\tif (check_ref_format(ref)) {\n-\t\t\tfprintf(stderr, \"warning: ref '%s' ignored\\n\", ref);\n+\t\t\twarning(\"ref '%s' ignored\", ref);\n \t\t\tcontinue;\n \t\t}\n \t\tif (!string_list_has_string(&existing_refs, ref)) {\n-- \n1.6.2\n"},{"id":"109129","messageId":"f6b2ede9af2bd40ce89f0251b32861098af46aad.1237856682.git.vmiklos@frugalware.org","threadId":"18499","inReplyTo":"607f1ab07464931305b62599805f898e2bf2ca98.1237856682.git.vmiklos@frugalware.org","subject":"[PATCH 9/9] refs: use warning() instead of fprintf(stderr, \"warning: \")","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2009-03-24T01:09:17Z","receivedAt":"2009-03-24T01:09:17Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Signed-off-by: Miklos Vajna \n---\n refs.c | 8 +++-----\n 1 files changed, 3 insertions(+), 5 deletions(-)\n\ndiff --git a/refs.c b/refs.c\nindex 8d3c502..aeef257 100644\n--- a/refs.c\n+++ b/refs.c\n@@ -996,7 +996,7 @@ int delete_ref(const char *refname, const unsigned char *sha1, int delopt)\n \n \terr = unlink(git_path(\"logs/%s\", lock->ref_name));\n \tif (err && errno != ENOENT)\n-\t\tfprintf(stderr, \"warning: unlink(%s) failed: %s\",\n+\t\twarning(\"unlink(%s) failed: %s\",\n \t\t\tgit_path(\"logs/%s\", lock->ref_name), strerror(errno));\n \tinvalidate_cached_refs();\n \tunlock_ref(lock);\n@@ -1438,8 +1438,7 @@ int read_ref_at(const char *ref, unsigned long at_time, int cnt, unsigned char *\n \t\t\t\tif (get_sha1_hex(rec + 41, sha1))\n \t\t\t\t\tdie(\"Log %s is corrupt.\", logfile);\n \t\t\t\tif (hashcmp(logged_sha1, sha1)) {\n-\t\t\t\t\tfprintf(stderr,\n-\t\t\t\t\t\t\"warning: Log %s has gap after %s.\\n\",\n+\t\t\t\t\twarning(\"Log %s has gap after %s.\",\n \t\t\t\t\t\tlogfile, show_date(date, tz, DATE_RFC2822));\n \t\t\t\t}\n \t\t\t}\n@@ -1451,8 +1450,7 @@ int read_ref_at(const char *ref, unsigned long at_time, int cnt, unsigned char *\n \t\t\t\tif (get_sha1_hex(rec + 41, logged_sha1))\n \t\t\t\t\tdie(\"Log %s is corrupt.\", logfile);\n \t\t\t\tif (hashcmp(logged_sha1, sha1)) {\n-\t\t\t\t\tfprintf(stderr,\n-\t\t\t\t\t\t\"warning: Log %s unexpectedly ended on %s.\\n\",\n+\t\t\t\t\twarning(\"Log %s unexpectedly ended on %s.\",\n \t\t\t\t\t\tlogfile, show_date(date, tz, DATE_RFC2822));\n \t\t\t\t}\n \t\t\t}\n-- \n1.6.2\n"},{"id":"109137","messageId":"40aa078e0903231817g41fd1bc1s296121d85923f7ea@mail.gmail.com","threadId":"18499","inReplyTo":"f6b2ede9af2bd40ce89f0251b32861098af46aad.1237856682.git.vmiklos@frugalware.org","subject":"Re: [PATCH 9/9] refs: use warning() instead of fprintf(stderr, \"warning: \")","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@googlemail.com","sentAt":"2009-03-24T01:17:24Z","receivedAt":"2009-03-24T01:17:24Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"> @@ -996,7 +996,7 @@ int delete_ref(const char *refname, const unsigned char *sha1, int delopt)\n>\n> err = unlink(git_path(\"logs/%s\", lock->ref_name));\n> if (err && errno != ENOENT)\n> - fprintf(stderr, \"warning: unlink(%s) failed: %s\",\n> + warning(\"unlink(%s) failed: %s\",\n\nDoesn't this add a newline? The original string doesn't have a '\\n' at\nthe end of the format-field, but AFAIK warning() terminates with one.\nI'm not saying it's a problem, I'm just pointing it out.\n\n-- \nErik \"kusma\" Faye-Lund\nkusmabite@gmail.com\n(+47) 986 59 656\n"},{"id":"109139","messageId":"20090324012334.GL27459@genesis.frugalware.org","threadId":"18499","inReplyTo":"40aa078e0903231817g41fd1bc1s296121d85923f7ea@mail.gmail.com","subject":"Re: [PATCH 9/9] refs: use warning() instead of fprintf(stderr, \"warning: \")","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2009-03-24T01:23:34Z","receivedAt":"2009-03-24T01:23:34Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Tue, Mar 24, 2009 at 02:17:24AM +0100, Erik Faye-Lund wrote:\n> > @@ -996,7 +996,7 @@ int delete_ref(const char *refname, const unsigned char *sha1, int delopt)\n> >\n> > err = unlink(git_path(\"logs/%s\", lock->ref_name));\n> > if (err && errno != ENOENT)\n> > - fprintf(stderr, \"warning: unlink(%s) failed: %s\",\n> > + warning(\"unlink(%s) failed: %s\",\n> \n> Doesn't this add a newline? The original string doesn't have a '\\n' at\n> the end of the format-field, but AFAIK warning() terminates with one.\n> I'm not saying it's a problem, I'm just pointing it out.\n\nYes, it adds. As Jeff pointed out earlier in this thread, the lack of\nnewline was a bug:\n\nhttp://article.gmane.org/gmane.comp.version-control.git/110783\n"},{"id":"109140","messageId":"40aa078e0903231825w54c9dca2xc68a849d245916a4@mail.gmail.com","threadId":"18499","inReplyTo":"9287282d966904f06ae4b3d7cfdf1d79eb645b69.1237856682.git.vmiklos@frugalware.org","subject":"Re: [PATCH 2/9] builtin-apply: use warning() instead of fprintf(stderr, \"warning: \")","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@googlemail.com","sentAt":"2009-03-24T01:25:02Z","receivedAt":"2009-03-24T01:25:02Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Tue, Mar 24, 2009 at 2:09 AM, Miklos Vajna wrote:\n> @@ -2932,8 +2932,7 @@ static int write_out_one_reject(struct patch *patch)\n>        cnt = strlen(patch->new_name);\n>        if (ARRAY_SIZE(namebuf) <= cnt + 5) {\n>                cnt = ARRAY_SIZE(namebuf) - 5;\n> -               fprintf(stderr,\n> -                       \"warning: truncating .rej filename to %.*s.rej\",\n> +               warning(\"truncating .rej filename to %.*s.rej\",\n\nAgain, doesn't this change the output?\n\n-- \nErik \"kusma\" Faye-Lund\nkusmabite@gmail.com\n(+47) 986 59 656\n"},{"id":"109141","messageId":"40aa078e0903231828t2c5ff976m491ba0f739b0ea27@mail.gmail.com","threadId":"18499","inReplyTo":"20090324012334.GL27459@genesis.frugalware.org","subject":"Re: [PATCH 9/9] refs: use warning() instead of fprintf(stderr, \"warning: \")","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@googlemail.com","sentAt":"2009-03-24T01:28:07Z","receivedAt":"2009-03-24T01:28:07Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"OK, sorry for not reading the old discussion before commenting. :)\n\nOn Tue, Mar 24, 2009 at 2:23 AM, Miklos Vajna wrote:\n> On Tue, Mar 24, 2009 at 02:17:24AM +0100, Erik Faye-Lund wrote:\n>> > @@ -996,7 +996,7 @@ int delete_ref(const char *refname, const unsigned char *sha1, int delopt)\n>> >\n>> >        err = unlink(git_path(\"logs/%s\", lock->ref_name));\n>> >        if (err && errno != ENOENT)\n>> > -               fprintf(stderr, \"warning: unlink(%s) failed: %s\",\n>> > +               warning(\"unlink(%s) failed: %s\",\n>>\n>> Doesn't this add a newline? The original string doesn't have a '\\n' at\n>> the end of the format-field, but AFAIK warning() terminates with one.\n>> I'm not saying it's a problem, I'm just pointing it out.\n>\n> Yes, it adds. As Jeff pointed out earlier in this thread, the lack of\n> newline was a bug:\n>\n> http://article.gmane.org/gmane.comp.version-control.git/110783\n>\n\n\n\n-- \nErik \"kusma\" Faye-Lund\nkusmabite@gmail.com\n(+47) 986 59 656\n"},{"id":"109160","messageId":"20090324073513.GA32400@coredump.intra.peff.net","threadId":"18499","inReplyTo":"cover.1237856682.git.vmiklos@frugalware.org","subject":"Re: [PATCH 0/9] fprintf(stderr, \"warning: \") -> warning() patches","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2009-03-24T07:35:13Z","receivedAt":"2009-03-24T07:35:13Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Mar 24, 2009 at 02:09:08AM +0100, Miklos Vajna wrote:\n\n> Okay, here it is, applies on top of master. All, except the http-push\n> one, applies cleanly on top of next as well here.\n\nI manually scanned the patches and they all look sane to me.\nThanks.\n\n-Peff\n"},{"id":"109165","messageId":"7vr60n2vtu.fsf@gitster.siamese.dyndns.org","threadId":"18499","inReplyTo":"20090324073513.GA32400@coredump.intra.peff.net","subject":"Re: [PATCH 0/9] fprintf(stderr, \"warning: \") -> warning() patches","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-03-24T08:01:33Z","receivedAt":"2009-03-24T08:01:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> On Tue, Mar 24, 2009 at 02:09:08AM +0100, Miklos Vajna wrote:\n>\n>> Okay, here it is, applies on top of master. All, except the http-push\n>> one, applies cleanly on top of next as well here.\n>\n> I manually scanned the patches and they all look sane to me.\n> Thanks.\n\nThanks; I've done the same and three sets of eyeballs give me a warm fuzzy\nfeeling ;-)\n\nApplied.\n"}]}