{"thread":{"id":"18496","subject":"[PATCH] Documentation: push.default applies to all remotes","startedAt":"2009-03-23T23:18:38Z","lastAt":"2009-03-24T09:39:17Z","messageCount":4,"participants":["Santi Béjar","Junio C Hamano","Finn Arne Gangstad"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"109113","messageId":"1237850318-3671-1-git-send-email-santi@agolina.net","threadId":"18496","inReplyTo":null,"subject":"[PATCH] Documentation: push.default applies to all remotes","fromName":"Santi Béjar","fromEmail":"santi@agolina.net","sentAt":"2009-03-23T23:18:38Z","receivedAt":"2009-03-23T23:18:38Z","isPatch":true,"sender":{"key":"santi@agolina.net","avatar":null},"body":"push.default is not only for the current remote but setting the default\nbehavior for all remotes.\n\nSigned-off-by: Santi Béjar \n---\nHi,\n\n this applies on top of next.\n\n Documentation/config.txt | 11 +++--------\n 1 files changed, 3 insertions(+), 8 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 089569a..7f5fe43 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -1215,19 +1215,14 @@ push.default::\n \tDefines the action git push should take if no refspec is given\n \ton the command line, no refspec is configured in the remote, and\n \tno refspec is implied by any of the options given on the command\n-\tline.\n-+\n-The term `current remote` means the remote configured for the current\n-branch, or `origin` if no remote is configured. `origin` is also used\n-if you are not on any branch. Possible values are:\n+\tline. Possible values are:\n +\n * `nothing` do not push anything.\n-* `matching` push all matching branches to the current remote.\n+* `matching` push all matching branches.\n All branches having the same name in both ends are considered to be\n matching. This is the current default value.\n * `tracking` push the current branch to the branch it is tracking.\n-* `current` push the current branch to a branch of the same name on the\n- current remote.\n+* `current` push the current branch to a branch of the same name.\n \n rebase.stat::\n \tWhether to show a diffstat of what changed upstream since the last\n-- \n1.6.1.258.g7ff14\n"},{"id":"109116","messageId":"7v7i2f6cj7.fsf@gitster.siamese.dyndns.org","threadId":"18496","inReplyTo":"1237850318-3671-1-git-send-email-santi@agolina.net","subject":"Re: [PATCH] Documentation: push.default applies to all remotes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-03-23T23:32:28Z","receivedAt":"2009-03-23T23:32:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Santi Béjar writes:\n\n> push.default is not only for the current remote but setting the default\n> behavior for all remotes.\n>\n> Signed-off-by: Santi Béjar \n> ---\n> Hi,\n>\n> this applies on top of next.\n>\n> Documentation/config.txt | 11 +++--------\n> 1 files changed, 3 insertions(+), 8 deletions(-)\n>\n> diff --git a/Documentation/config.txt b/Documentation/config.txt\n> index 089569a..7f5fe43 100644\n> --- a/Documentation/config.txt\n> +++ b/Documentation/config.txt\n> @@ -1215,19 +1215,14 @@ push.default::\n> \tDefines the action git push should take if no refspec is given\n> \ton the command line, no refspec is configured in the remote, and\n> \tno refspec is implied by any of the options given on the command\n> -\tline.\n> -+\n> -The term `current remote` means the remote configured for the current\n> -branch, or `origin` if no remote is configured. `origin` is also used\n> -if you are not on any branch. Possible values are:\n> +\tline. Possible values are:\n> +\n> * `nothing` do not push anything.\n> -* `matching` push all matching branches to the current remote.\n> +* `matching` push all matching branches.\n> All branches having the same name in both ends are considered to be\n> matching. This is the current default value.\n> * `tracking` push the current branch to the branch it is tracking.\n> -* `current` push the current branch to a branch of the same name on the\n> - current remote.\n> +* `current` push the current branch to a branch of the same name.\n> \n> rebase.stat::\n> \tWhether to show a diffstat of what changed upstream since the last\n\nThis makes sense; I can understand why \"same name\" wanted to be qualified\nwith \"on the current remote\", but the sentence reads just fine without it.\nIt is clear that the \"same name\" compares the set of branches the local\nrepository has with the set of branches in the other repository we are\npushing into.\n\nIf we want to explain that a \"git push\" that does not say where-to decides\nwhere to push by looking at branch..remote configuration and falling\nback to origin, push.default is not the place to explain it. This\nconfiguration variable is not involved in that decision in any way.\n\nThe description for branch..remote can be updated to say it is used\nfor both fetch and push.\n"},{"id":"109180","messageId":"20090324083015.GA22271@pvv.org","threadId":"18496","inReplyTo":"7v7i2f6cj7.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Documentation: push.default applies to all remotes","fromName":"Finn Arne Gangstad","fromEmail":"finnag@pvv.org","sentAt":"2009-03-24T08:30:15Z","receivedAt":"2009-03-24T08:30:15Z","isPatch":true,"sender":{"key":"finnag@pvv.org","avatar":"https://gravatar.com/avatar/b421ddd58c3f0f93aa473e17b98bb8d53c221fef741746bc8cb59fae4ec6d95e?d=mp&s=160"},"body":"On Mon, Mar 23, 2009 at 04:32:28PM -0700, Junio C Hamano wrote:\n> Santi Béjar writes:\n> \n> > push.default is not only for the current remote but setting the default\n> > behavior for all remotes.\n> >\n> > Signed-off-by: Santi Béjar \n> > ---\n> > Hi,\n> >\n> > this applies on top of next.\n> >\n> > Documentation/config.txt | 11 +++--------\n> > 1 files changed, 3 insertions(+), 8 deletions(-)\n> >\n> > diff --git a/Documentation/config.txt b/Documentation/config.txt\n> > index 089569a..7f5fe43 100644\n> > --- a/Documentation/config.txt\n> > +++ b/Documentation/config.txt\n> > @@ -1215,19 +1215,14 @@ push.default::\n> > \tDefines the action git push should take if no refspec is given\n> > \ton the command line, no refspec is configured in the remote, and\n> > \tno refspec is implied by any of the options given on the command\n> > -\tline.\n> > -+\n> > -The term `current remote` means the remote configured for the current\n> > -branch, or `origin` if no remote is configured. `origin` is also used\n> > -if you are not on any branch. Possible values are:\n> > +\tline. Possible values are:\n> > +\n> > * `nothing` do not push anything.\n> > -* `matching` push all matching branches to the current remote.\n> > +* `matching` push all matching branches.\n> > All branches having the same name in both ends are considered to be\n> > matching. This is the current default value.\n> > * `tracking` push the current branch to the branch it is tracking.\n> > -* `current` push the current branch to a branch of the same name on the\n> > - current remote.\n> > +* `current` push the current branch to a branch of the same name.\n> > \n> > rebase.stat::\n> > \tWhether to show a diffstat of what changed upstream since the last\n> [...]\n> If we want to explain that a \"git push\" that does not say where-to decides\n> where to push by looking at branch..remote configuration and falling\n> back to origin, push.default is not the place to explain it. This\n> configuration variable is not involved in that decision in any way.\n\nI originally had an option to push all tracking branches to their\nrespective counterparts here, but decided against including it. Then\nit made sense to distinguish which options pushed to the current\nremote, and which did not. Since that option is gone, removing the\nextra text seems like an improvement.\n\n- Finn Arne\n"},{"id":"109196","messageId":"adf1fd3d0903240239l7997b77dw24ee304659f70d44@mail.gmail.com","threadId":"18496","inReplyTo":"20090324083015.GA22271@pvv.org","subject":"Re: [PATCH] Documentation: push.default applies to all remotes","fromName":"Santi Béjar","fromEmail":"santi@agolina.net","sentAt":"2009-03-24T09:39:17Z","receivedAt":"2009-03-24T09:39:17Z","isPatch":true,"sender":{"key":"santi@agolina.net","avatar":null},"body":"Hi,\n\n one thing I wonder is if push.default is too generic, maybe\npush.style matches more the meaning.\n\nSanti\n"}]}