{"thread":{"id":"18458","subject":"[PATCH] Add --staged to bash completion for git diff","startedAt":"2009-03-21T23:29:27Z","lastAt":"2009-03-23T00:33:41Z","messageCount":2,"participants":["Kevin McConnell","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"108853","messageId":"372194e70903211629w52705806l5a82c2dde19b73f7@mail.gmail.com","threadId":"18458","inReplyTo":null,"subject":"[PATCH] Add --staged to bash completion for git diff","fromName":"Kevin McConnell","fromEmail":"kevin.mcconnell@gmail.com","sentAt":"2009-03-21T23:29:27Z","receivedAt":"2009-03-21T23:29:27Z","isPatch":true,"sender":{"key":"kevin.mcconnell@gmail.com","avatar":null},"body":"The --staged option (synonym for --cached) isn't listed in the\ncompletion choices for git diff.  This tiny patch adds it.\n---\n contrib/completion/git-completion.bash |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash\nb/contrib/completion/git-completion.bash\nindex ed235f7..6bc32df 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -899,7 +899,7 @@ _git_diff ()\n \tlocal cur=\"${COMP_WORDS[COMP_CWORD]}\"\n \tcase \"$cur\" in\n \t--*)\n-\t\t__gitcomp \"--cached --pickaxe-all --pickaxe-regex\n+\t\t__gitcomp \"--cached --staged --pickaxe-all --pickaxe-regex\n \t\t\t--base --ours --theirs\n \t\t\t$__git_diff_common_options\n \t\t\t\"\n-- \n1.6.2.1\n"},{"id":"108968","messageId":"20090323003341.GJ23521@spearce.org","threadId":"18458","inReplyTo":"372194e70903211629w52705806l5a82c2dde19b73f7@mail.gmail.com","subject":"Re: [PATCH] Add --staged to bash completion for git diff","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2009-03-23T00:33:41Z","receivedAt":"2009-03-23T00:33:41Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Kevin McConnell <kevin.mcconnell@gmail.com> wrote:\n> The --staged option (synonym for --cached) isn't listed in the\n> completion choices for git diff.  This tiny patch adds it.\n\nMissing Signed-off-by line?\n\nOtherwise though,\n\nTrivially-Acked-by: Shawn O. Pearce <spearce@spearce.org>\n\n> ---\n>  contrib/completion/git-completion.bash |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/contrib/completion/git-completion.bash\n> b/contrib/completion/git-completion.bash\n> index ed235f7..6bc32df 100755\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -899,7 +899,7 @@ _git_diff ()\n>  \tlocal cur=\"${COMP_WORDS[COMP_CWORD]}\"\n>  \tcase \"$cur\" in\n>  \t--*)\n> -\t\t__gitcomp \"--cached --pickaxe-all --pickaxe-regex\n> +\t\t__gitcomp \"--cached --staged --pickaxe-all --pickaxe-regex\n>  \t\t\t--base --ours --theirs\n>  \t\t\t$__git_diff_common_options\n>  \t\t\t\"\n\n-- \nShawn.\n"}]}