{"thread":{"id":"18424","subject":"[PATCH] Documentation/git-filter-branch.txt: Remove unnecessary URL quoting","startedAt":"2009-03-19T23:12:10Z","lastAt":"2009-03-22T23:20:10Z","messageCount":3,"participants":["Johan Herland","Thomas Rast"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"108626","messageId":"200903200012.10454.johan@herland.net","threadId":"18424","inReplyTo":null,"subject":"[PATCH] Documentation/git-filter-branch.txt: Remove unnecessary URL quoting","fromName":"Johan Herland","fromEmail":"johan@herland.net","sentAt":"2009-03-19T23:12:10Z","receivedAt":"2009-03-19T23:12:10Z","isPatch":true,"sender":{"key":"johan@herland.net","avatar":"https://avatars.githubusercontent.com/u/547031?v=4"},"body":"Embedding the URL in '+++' causes AsciiDoc (v8.4.1) to generate invalid XML.\nNone of the other URLs in Git's documentation are quoted in this manner.\nThere's no reason to treat this URL differently.\n\nSigned-off-by: Johan Herland \n---\n Documentation/git-filter-branch.txt | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-filter-branch.txt b/Documentation/git-filter-branch.txt\nindex 237f85e..64b99d7 100644\n--- a/Documentation/git-filter-branch.txt\n+++ b/Documentation/git-filter-branch.txt\n@@ -361,7 +361,7 @@ objects until you tell it to. First make sure that:\n Then there are two ways to get a smaller repository. A safer way is\n to clone, that keeps your original intact.\n \n-* Clone it with `git clone +++file:///path/to/repo+++`. The clone\n+* Clone it with `git clone file:///path/to/repo`. The clone\n will not have the removed objects. See linkgit:git-clone[1]. (Note\n that cloning with a plain path just hardlinks everything!)\n \n-- \n1.6.2.1.352.gae594.dirty\n"},{"id":"108727","messageId":"200903201619.56600.trast@student.ethz.ch","threadId":"18424","inReplyTo":"200903200012.10454.johan@herland.net","subject":"Re: [PATCH] Documentation/git-filter-branch.txt: Remove unnecessary URL quoting","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2009-03-20T15:19:50Z","receivedAt":"2009-03-20T15:19:50Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Johan Herland wrote:\n> Embedding the URL in '+++' causes AsciiDoc (v8.4.1) to generate invalid XML.\n> None of the other URLs in Git's documentation are quoted in this manner.\n> There's no reason to treat this URL differently.\n> \n> Signed-off-by: Johan Herland \n[...]\n> -* Clone it with `git clone +++file:///path/to/repo+++`. The clone\n> +* Clone it with `git clone file:///path/to/repo`. The clone\n\nI deliberately wrote it that way because *not* quoting it, at least on\nmy box, formats the entire paragraph in monospace. Apparently it\ntreats the ` as part of an autodetected URL or some such. This is\nindependent of my choice of ASCIIDOC8 or DOCBOOK_XSL_172 settings. Am\nI missing another flag that avoids this problem?\n\nI have these packages installed from opensuse:\n\n asciidoc-8.2.7-29.10\n docbook_4-4.5-111.8\n docbook-xsl-stylesheets-1.74.0-1.35\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"},{"id":"108958","messageId":"200903230020.10128.johan@herland.net","threadId":"18424","inReplyTo":"200903201619.56600.trast@student.ethz.ch","subject":"Re: [PATCH] Documentation/git-filter-branch.txt: Remove unnecessary URL quoting","fromName":"Johan Herland","fromEmail":"johan@herland.net","sentAt":"2009-03-22T23:20:10Z","receivedAt":"2009-03-22T23:20:10Z","isPatch":true,"sender":{"key":"johan@herland.net","avatar":"https://avatars.githubusercontent.com/u/547031?v=4"},"body":"On Friday 20 March 2009, Thomas Rast wrote:\n> Johan Herland wrote:\n> > Embedding the URL in '+++' causes AsciiDoc (v8.4.1) to generate invalid\n> > XML. None of the other URLs in Git's documentation are quoted in this\n> > manner. There's no reason to treat this URL differently.\n>\n> [...]\n>\n> > -* Clone it with `git clone +++file:///path/to/repo+++`. The clone\n> > +* Clone it with `git clone file:///path/to/repo`. The clone\n>\n> I deliberately wrote it that way because *not* quoting it, at least on\n> my box, formats the entire paragraph in monospace. Apparently it\n> treats the ` as part of an autodetected URL or some such. This is\n> independent of my choice of ASCIIDOC8 or DOCBOOK_XSL_172 settings. Am\n> I missing another flag that avoids this problem?\n\nNo, I think this is due to version differences in AsciiDoc.\n\n> I have these packages installed from opensuse:\n> asciidoc-8.2.7-29.10\n\nI use AsciiDoc v8.4.1 (from Arch Linux), and according to \nhttp://www.methods.co.nz/asciidoc/CHANGELOG.html there are some regression \nissues regarding backtick quoting and \"inline literal passthrough\"s when \nupgrading to v8.4.1. According to the changelog I should be able to revert \nAsciiDoc to the old behaviour by putting\n\n [attributes]\n no-inline-literal=\n\nin my Documentation/asciidoc.conf. However, with this in place, I _still_ \nget invalid XML generated for git-filter-branch.txt... :(\n\nSo, it seems to be an AsciiDoc versioning issue. I'm not sure which of these \nAsciiDoc versions are preferable, of if it is possible to format the text in \nsuch a manner that it'll work in both versions.\n\n\n...Johan\n\n-- \nJohan Herland, \nwww.herland.net\n"}]}