{"thread":{"id":"18397","subject":"[PATCH 0/2] gitk window icons","startedAt":"2009-03-19T08:54:16Z","lastAt":"2009-03-23T10:59:53Z","messageCount":4,"participants":["Stephen Boyd","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"108491","messageId":"cover.1237451887.git.bebarino@gmail.com","threadId":"18397","inReplyTo":null,"subject":"[PATCH 0/2] gitk window icons","fromName":"Stephen Boyd","fromEmail":"bebarino@gmail.com","sentAt":"2009-03-19T08:54:16Z","receivedAt":"2009-03-19T08:54:16Z","isPatch":true,"sender":{"key":"bebarino@gmail.com","avatar":"https://avatars.githubusercontent.com/u/38832?v=4"},"body":"These two patches set the git logo, three red minus signs and three green plus\nsigns below on a white background, as the window icon for gitk.\n\nI found this first patch by Giuseppe posted to the mailing list a couple months\nago. I've simply added a 32x32 icon in the second patch so that window managers\ncan provide a slightly better looking icon when they need a bigger icon\n(ALT-TAB for example).\n\nThis logo is different than the logo used by git-gui. Do we want to use that\nlogo instead?\n\nGiuseppe Bilotta (1):\n  gitk: try to provide a window icon\n\nStephen Boyd (1):\n  gitk: provide a 32x32 window icon based on the git logo\n\n gitk |   23 +++++++++++++++++++++++\n 1 files changed, 23 insertions(+), 0 deletions(-)\n"},{"id":"108492","messageId":"61242ff6c582f3b82b7ddf4db75bdad45f0a457e.1237451887.git.bebarino@gmail.com","threadId":"18397","inReplyTo":"cover.1237451887.git.bebarino@gmail.com","subject":"[PATCH 1/2] gitk: try to provide a window icon","fromName":"Stephen Boyd","fromEmail":"bebarino@gmail.com","sentAt":"2009-03-19T08:54:17Z","receivedAt":"2009-03-19T08:54:17Z","isPatch":true,"sender":{"key":"bebarino@gmail.com","avatar":"https://avatars.githubusercontent.com/u/38832?v=4"},"body":"From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>\n\nTry to set up a 16x16 Tk photo image (based on the git logo) and use it\nas window icon. Wrap the code in a catch because it may fail in earlier\nTcl/Tk 8.4 releases that don't provide 'wm iconphoto'.\n\nSigned-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>\nSigned-off-by: Stephen Boyd <bebarino@gmail.com>\n---\n gitk |   20 ++++++++++++++++++++\n 1 files changed, 20 insertions(+), 0 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 1773ae6..cfbb699 100755\n--- a/gitk\n+++ b/gitk\n@@ -10883,6 +10883,26 @@ set lserial 0\n set isworktree [expr {[exec git rev-parse --is-inside-work-tree] == \"true\"}]\n setcoords\n makewindow\n+catch {\n+\timage create photo gitlogo      -width 16 -height 16\n+\n+\timage create photo gitlogominus -width  4 -height  2\n+\tgitlogominus put #C00000 -to 0 0 4 2\n+\tgitlogo copy gitlogominus -to  1 5\n+\tgitlogo copy gitlogominus -to  6 5\n+\tgitlogo copy gitlogominus -to 11 5\n+\timage delete gitlogominus\n+\n+\timage create photo gitlogoplus  -width  4 -height  4\n+\tgitlogoplus  put #008000 -to 1 0 3 4\n+\tgitlogoplus  put #008000 -to 0 1 4 3\n+\tgitlogo copy gitlogoplus  -to  1 9\n+\tgitlogo copy gitlogoplus  -to  6 9\n+\tgitlogo copy gitlogoplus  -to 11 9\n+\timage delete gitlogoplus\n+\n+\twm iconphoto . -default gitlogo\n+}\n # wait for the window to become visible\n tkwait visibility .\n wm title . \"[file tail $argv0]: [file tail [pwd]]\"\n-- \n1.6.2\n"},{"id":"108493","messageId":"9a1d5cc34e91679beec3e82c52512f33b2ba9d7e.1237451887.git.bebarino@gmail.com","threadId":"18397","inReplyTo":"61242ff6c582f3b82b7ddf4db75bdad45f0a457e.1237451887.git.bebarino@gmail.com","subject":"[PATCH 2/2] gitk: provide a 32x32 window icon based on the git logo","fromName":"Stephen Boyd","fromEmail":"bebarino@gmail.com","sentAt":"2009-03-19T08:54:18Z","receivedAt":"2009-03-19T08:54:18Z","isPatch":true,"sender":{"key":"bebarino@gmail.com","avatar":"https://avatars.githubusercontent.com/u/38832?v=4"},"body":"Signed-off-by: Stephen Boyd <bebarino@gmail.com>\n---\n gitk |    5 ++++-\n 1 files changed, 4 insertions(+), 1 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex cfbb699..5a09eca 100755\n--- a/gitk\n+++ b/gitk\n@@ -10901,7 +10901,10 @@ catch {\n \tgitlogo copy gitlogoplus  -to 11 9\n \timage delete gitlogoplus\n \n-\twm iconphoto . -default gitlogo\n+\timage create photo gitlogo32    -width 32 -height 32\n+\tgitlogo32 copy gitlogo -zoom 2 2\n+\n+\twm iconphoto . -default gitlogo gitlogo32\n }\n # wait for the window to become visible\n tkwait visibility .\n-- \n1.6.2\n"},{"id":"109043","messageId":"18887.27561.995982.97262@cargo.ozlabs.ibm.com","threadId":"18397","inReplyTo":"cover.1237451887.git.bebarino@gmail.com","subject":"Re: [PATCH 0/2] gitk window icons","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2009-03-23T10:59:53Z","receivedAt":"2009-03-23T10:59:53Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Stephen Boyd writes:\n\n> These two patches set the git logo, three red minus signs and three green plus\n> signs below on a white background, as the window icon for gitk.\n\nThanks, applied.  (I adjusted the indentation in both and wrote a\nbrief commit message for the second.)\n\nPaul.\n"}]}