{"thread":{"id":"18363","subject":"[EGIT PATCH 01/25] Use generics for collections in commit dialog and import page","startedAt":"2009-03-18T00:40:49Z","lastAt":"2009-03-18T06:32:21Z","messageCount":3,"participants":["Robin Rosenberg","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":25},"messages":[{"id":"108299","messageId":"1237336849-2036-1-git-send-email-robin.rosenberg@dewire.com","threadId":"18363","inReplyTo":null,"subject":"[EGIT PATCH 01/25] Use generics for collections in commit dialog and import page","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2009-03-18T00:40:49Z","receivedAt":"2009-03-18T00:40:49Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"A little cleaner and fewer warnings.\n\nSigned-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>\n---\n .../ui/internal/clone/GitProjectsImportPage.java   |   16 ++++++++--------\n .../egit/ui/internal/dialogs/CommitDialog.java     |    2 +-\n 2 files changed, 9 insertions(+), 9 deletions(-)\n\ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/GitProjectsImportPage.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/GitProjectsImportPage.java\nindex ece585a..5d82edc 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/GitProjectsImportPage.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/GitProjectsImportPage.java\n@@ -508,7 +508,7 @@ public void run(IProgressMonitor monitor) {\n \t\t\t\t\t\t\tUIText.WizardProjectsImportPage_SearchingMessage,\n \t\t\t\t\t\t\t100);\n \t\t\t\t\tselectedProjects = new ProjectRecord[0];\n-\t\t\t\t\tCollection files = new ArrayList();\n+\t\t\t\t\tCollection<File> files = new ArrayList<File>();\n \t\t\t\t\tmonitor.worked(10);\n \t\t\t\t\tif (directory.isDirectory()) {\n \n@@ -516,14 +516,14 @@ public void run(IProgressMonitor monitor) {\n \t\t\t\t\t\t\t\tnull, monitor)) {\n \t\t\t\t\t\t\treturn;\n \t\t\t\t\t\t}\n-\t\t\t\t\t\tIterator filesIterator = files.iterator();\n+\t\t\t\t\t\tIterator<File> filesIterator = files.iterator();\n \t\t\t\t\t\tselectedProjects = new ProjectRecord[files.size()];\n \t\t\t\t\t\tint index = 0;\n \t\t\t\t\t\tmonitor.worked(50);\n \t\t\t\t\t\tmonitor\n \t\t\t\t\t\t\t\t.subTask(UIText.WizardProjectsImportPage_ProcessingMessage);\n \t\t\t\t\t\twhile (filesIterator.hasNext()) {\n-\t\t\t\t\t\t\tFile file = (File) filesIterator.next();\n+\t\t\t\t\t\t\tFile file = filesIterator.next();\n \t\t\t\t\t\t\tselectedProjects[index] = new ProjectRecord(file);\n \t\t\t\t\t\t\tindex++;\n \t\t\t\t\t\t}\n@@ -562,8 +562,8 @@ setMessage(UIText.WizardProjectsImportPage_projectsInWorkspace,\n \t *            The monitor to report to\n \t * @return boolean <code>true</code> if the operation was completed.\n \t */\n-\tprivate boolean collectProjectFilesFromDirectory(Collection files,\n-\t\t\tFile directory, Set directoriesVisited, IProgressMonitor monitor) {\n+\tprivate boolean collectProjectFilesFromDirectory(Collection<File> files,\n+\t\t\tFile directory, Set<String> directoriesVisited, IProgressMonitor monitor) {\n \n \t\tif (monitor.isCanceled()) {\n \t\t\treturn false;\n@@ -577,7 +577,7 @@ private boolean collectProjectFilesFromDirectory(Collection files,\n \n \t\t// Initialize recursion guard for recursive symbolic links\n \t\tif (directoriesVisited == null) {\n-\t\t\tdirectoriesVisited = new HashSet();\n+\t\t\tdirectoriesVisited = new HashSet<String>();\n \t\t\ttry {\n \t\t\t\tdirectoriesVisited.add(directory.getCanonicalPath());\n \t\t\t} catch (IOException exception) {\n@@ -759,13 +759,13 @@ public CheckboxTreeViewer getProjectsList() {\n \t *         workspace\n \t */\n \tpublic ProjectRecord[] getValidProjects() {\n-\t\tList validProjects = new ArrayList();\n+\t\tList<ProjectRecord> validProjects = new ArrayList<ProjectRecord>();\n \t\tfor (int i = 0; i < selectedProjects.length; i++) {\n \t\t\tif (!isProjectInWorkspace(selectedProjects[i].getProjectName())) {\n \t\t\t\tvalidProjects.add(selectedProjects[i]);\n \t\t\t}\n \t\t}\n-\t\treturn (ProjectRecord[]) validProjects\n+\t\treturn validProjects\n \t\t\t\t.toArray(new ProjectRecord[validProjects.size()]);\n \t}\n \ndiff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java\nindex b69a4ba..e6bd02d 100644\n--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java\n+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java\n@@ -366,7 +366,7 @@ public void handleEvent(Event arg0) {\n \t\t\t\t}\n \t\t\t\ttry {\n \t\t\t\t\tArrayList<GitIndex> changedIndexes = new ArrayList<GitIndex>();\n-\t\t\t\t\tfor (Iterator<Object> it = sel.iterator(); it.hasNext();) {\n+\t\t\t\t\tfor (Iterator<?> it = sel.iterator(); it.hasNext();) {\n \t\t\t\t\t\tCommitItem commitItem = (CommitItem) it.next();\n \n \t\t\t\t\t\tIProject project = commitItem.file.getProject();\n-- \n1.6.1.285.g35d8b\n"},{"id":"108322","messageId":"20090318014537.GC23521@spearce.org","threadId":"18363","inReplyTo":"1237336849-2036-1-git-send-email-robin.rosenberg@dewire.com","subject":"Re: [EGIT PATCH 01/25] Use generics for collections in commit dialog and import page","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2009-03-18T01:45:37Z","receivedAt":"2009-03-18T01:45:37Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"> Subject: Re: [EGIT PATCH 01/25] Use generics for collections in commit\n..............................^^\n\nAre there 24 remaining patches in this series?  I only got this one.\n\n-- \nShawn.\n"},{"id":"108342","messageId":"200903180732.21336.robin.rosenberg.lists@dewire.com","threadId":"18363","inReplyTo":"20090318014537.GC23521@spearce.org","subject":"Re: [EGIT PATCH 01/25] Use generics for collections in commit dialog and import page","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2009-03-18T06:32:21Z","receivedAt":"2009-03-18T06:32:21Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"onsdag 18 mars 2009 02:45:37 skrev \"Shawn O. Pearce\" <spearce@spearce.org>:\n> > Subject: Re: [EGIT PATCH 01/25] Use generics for collections in commit\n> ..............................^^\n> \n> Are there 24 remaining patches in this series?  I only got this one.\n\nAh, sorry. There's only one that I want to submit.\n\n-- robin\n"}]}