{"thread":{"id":"18305","subject":"[PATCH] test-lib: write test results to test-results/-","startedAt":"2009-03-13T16:26:36Z","lastAt":"2009-03-16T10:41:38Z","messageCount":14,"participants":["Johannes Schindelin","SZEDER Gábor","Junio C Hamano","Sverre Rabbelier"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"107966","messageId":"3728317206182c4d4539f3d20b8441cb160e72e3.1236961524u.git.johannes.schindelin@gmx.de","threadId":"18305","inReplyTo":"cover.1236961524u.git.johannes.schindelin@gmx.de","subject":"[PATCH] test-lib: write test results to test-results/-","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-03-13T16:26:36Z","receivedAt":"2009-03-13T16:26:36Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"The earlier code meant to attempt to strip everything except the test\nnumber, but only stripped the part starting with the last dash.\n\nHowever, there is no reason why we should not use the whole basename.\n\nSigned-off-by: Johannes Schindelin \n---\n\n\tEven if this is not strictly necessary after Hannes' test cleanup, \n\tit would still be nice.\n\n\tThe alternative fix would be to use two percent signs instead of \n\tjust one.\n\n t/test-lib.sh | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex 75b5a89..ccb5d0a 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -477,7 +477,7 @@ test_done () {\n \ttrap - EXIT\n \ttest_results_dir=\"$TEST_DIRECTORY/test-results\"\n \tmkdir -p \"$test_results_dir\"\n-\ttest_results_path=\"$test_results_dir/${0%-*}-$$\"\n+\ttest_results_path=\"$test_results_dir/${0%.sh}-$$\"\n \n \techo \"total $test_count\" >> $test_results_path\n \techo \"success $test_success\" >> $test_results_path\n-- \n1.6.2.240.g23c7\n"},{"id":"107967","messageId":"alpine.DEB.1.00.0903131735110.6288@intel-tinevez-2-302","threadId":"18305","inReplyTo":"3728317206182c4d4539f3d20b8441cb160e72e3.1236961524u.git.johannes.schindelin@gmx.de","subject":"Re: [PATCH] test-lib: write test results to test-results/-","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-03-13T16:36:13Z","receivedAt":"2009-03-13T16:36:13Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 13 Mar 2009, Johannes Schindelin wrote:\n\n> The earlier code meant to attempt to strip everything except the test\n> number, but only stripped the part starting with the last dash.\n> \n> However, there is no reason why we should not use the whole basename.\n> \n> Signed-off-by: Johannes Schindelin \n> ---\n> \n> \tEven if this is not strictly necessary after Hannes' test cleanup, \n> \tit would still be nice.\n\nJust to clarify: it fixes the issue that these two tests share the same \nfile in test-results/: t5521-pull-options.sh t5521-pull-symlink.sh\n\nAs a consequence, one's results overwrite the other one's.\n\nCiao,\nDscho\n"},{"id":"107971","messageId":"20090313172002.GA16232@neumann","threadId":"18305","inReplyTo":"alpine.DEB.1.00.0903131735110.6288@intel-tinevez-2-302","subject":"Re: [PATCH] test-lib: write test results to test-results/-","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2009-03-13T17:20:02Z","receivedAt":"2009-03-13T17:20:02Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"Hi,\n\n\nOn Fri, Mar 13, 2009 at 05:36:13PM +0100, Johannes Schindelin wrote:\n> On Fri, 13 Mar 2009, Johannes Schindelin wrote:\n> \n> > The earlier code meant to attempt to strip everything except the test\n> > number, but only stripped the part starting with the last dash.\n> > \n> > However, there is no reason why we should not use the whole basename.\n\nI agree.\n\n> > \n> > Signed-off-by: Johannes Schindelin \n> > ---\n> > \n> > \tEven if this is not strictly necessary after Hannes' test cleanup, \n> > \tit would still be nice.\n>\n> Just to clarify: it fixes the issue that these two tests share the same \n> file in test-results/: t5521-pull-options.sh t5521-pull-symlink.sh\n> \n> As a consequence, one's results overwrite the other one's.\n\nThe pid of the test process makes the name of the test result file\nunique for each test, even in the mentioned case, e.g. it would be\nsomething like t5521-pull-12345 and t5521-pull-23456. However, after\nHannes' patch there is no need for keeping that pid around because the\ntest result file names would be unique for each test anyway.\n\nMoreover, if we would remove the pif from the test result file name,\nwe could also remove the 'pre-clean' target from 't/Makefile'. With\nthe pid appended, we need that 'pre-clean' target to clean up all\nleftovers from the previous run. Without the pid each test will\nalways write to the same test result file, so we could actually just\noverwrite the cruft from the last run.\n\nSomething like the patch below. Thoughts?\n\n\nBest,\nGábor\n\n---\n t/Makefile | 7 ++-----\n t/test-lib.sh | 4 ++--\n 2 files changed, 4 insertions(+), 7 deletions(-)\n\ndiff --git a/t/Makefile b/t/Makefile\nindex 0d65ced..2e6e205 100644\n--- a/t/Makefile\n+++ b/t/Makefile\n@@ -14,14 +14,11 @@ SHELL_PATH_SQ = $(subst ','\\'',$(SHELL_PATH))\n T = $(wildcard t[0-9][0-9][0-9][0-9]-*.sh)\n TSVN = $(wildcard t91[0-9][0-9]-*.sh)\n \n-all: pre-clean $(T) aggregate-results clean\n+all: $(T) aggregate-results clean\n \n $(T):\n \t@echo \"*** $@ ***\"; GIT_CONFIG=.git/config '$(SHELL_PATH_SQ)' $@ $(GIT_TEST_OPTS)\n \n-pre-clean:\n-\t$(RM) -r test-results\n-\n clean:\n \t$(RM) -r 'trash directory' test-results\n \n@@ -33,5 +30,5 @@ full-svn-test:\n \t$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C\n \t$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8\n \n-.PHONY: pre-clean $(T) aggregate-results clean\n+.PHONY: $(T) aggregate-results clean\n .NOTPARALLEL:\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex 0bd24d5..d82c784 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -418,9 +418,9 @@ test_done () {\n \ttrap - exit\n \ttest_results_dir=\"$TEST_DIRECTORY/test-results\"\n \tmkdir -p \"$test_results_dir\"\n-\ttest_results_path=\"$test_results_dir/${0%.sh}-$$\"\n+\ttest_results_path=\"$test_results_dir/${0%.sh}\"\n \n-\techo \"total $test_count\" >> $test_results_path\n+\techo \"total $test_count\" > $test_results_path\n \techo \"success $test_success\" >> $test_results_path\n \techo \"fixed $test_fixed\" >> $test_results_path\n \techo \"broken $test_broken\" >> $test_results_path\n"},{"id":"107972","messageId":"7viqmdgx0b.fsf@gitster.siamese.dyndns.org","threadId":"18305","inReplyTo":"alpine.DEB.1.00.0903131735110.6288@intel-tinevez-2-302","subject":"Re: [PATCH] test-lib: write test results to test-results/-","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-03-13T17:20:36Z","receivedAt":"2009-03-13T17:20:36Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> On Fri, 13 Mar 2009, Johannes Schindelin wrote:\n>\n>> The earlier code meant to attempt to strip everything except the test\n>> number, but only stripped the part starting with the last dash.\n>> \n>> However, there is no reason why we should not use the whole basename.\n>> \n>> Signed-off-by: Johannes Schindelin \n>> ---\n>> \n>> \tEven if this is not strictly necessary after Hannes' test cleanup, \n>> \tit would still be nice.\n>\n> Just to clarify: it fixes the issue that these two tests share the same \n> file in test-results/: t5521-pull-options.sh t5521-pull-symlink.sh\n>\n> As a consequence, one's results overwrite the other one's.\n\nAre you saying that your \"fix\" will break things if we did not have\nrenames from j6t?\n\nWhat bug/problem/issue does this patch fix?\n\nI never look into test-results/ subdirectory myself (I'll let the\nsummarizing code do that for me) and the full names never bothered me.\n\nActually I've always thought it was a very nice touch by you to make sure\nresults will not be mixed up even when we have more than 10 tests in the\nsame category and some tests need to share their numbers, and and your\n\"meant to ... strip everything\" above gave me \"Huh?\"\n"},{"id":"107973","messageId":"7vbps5gwwf.fsf@gitster.siamese.dyndns.org","threadId":"18305","inReplyTo":"7viqmdgx0b.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] test-lib: write test results to test-results/-","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-03-13T17:22:56Z","receivedAt":"2009-03-13T17:22:56Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Johannes Schindelin writes:\n> ...\n>> As a consequence, one's results overwrite the other one's.\n>\n> Are you saying that your \"fix\" will break things if we did not have\n> renames from j6t?\n\nPlease disregard; I shouldn't be writing an e-mail when I do not have time\nto re-read and think. Sorry for the noise.\n"},{"id":"107974","messageId":"20090313174420.GF6808@neumann","threadId":"18305","inReplyTo":"20090313172002.GA16232@neumann","subject":"Re: [PATCH] test-lib: write test results to test-results/-","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2009-03-13T17:44:20Z","receivedAt":"2009-03-13T17:44:20Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"On Fri, Mar 13, 2009 at 06:20:02PM +0100, SZEDER Gábor wrote:\n> Hi,\n> \n> \n> On Fri, Mar 13, 2009 at 05:36:13PM +0100, Johannes Schindelin wrote:\n> > On Fri, 13 Mar 2009, Johannes Schindelin wrote:\n> > \n> > > The earlier code meant to attempt to strip everything except the test\n> > > number, but only stripped the part starting with the last dash.\n> > > \n> > > However, there is no reason why we should not use the whole basename.\n> \n> I agree.\n> \n> > > \n> > > Signed-off-by: Johannes Schindelin \n> > > ---\n> > > \n> > > \tEven if this is not strictly necessary after Hannes' test cleanup, \n> > > \tit would still be nice.\n> >\n> > Just to clarify: it fixes the issue that these two tests share the same \n> > file in test-results/: t5521-pull-options.sh t5521-pull-symlink.sh\n> > \n> > As a consequence, one's results overwrite the other one's.\n> \n> The pid of the test process makes the name of the test result file\n> unique for each test, even in the mentioned case, e.g. it would be\n> something like t5521-pull-12345 and t5521-pull-23456.\n\nCorrection: those files are not always unique, because although\nunlikely, it's possible that these two tests get the same pid.\n\nBut with Hannes' patch this issue goes away, and the rest of my\nprevious mail still holds.\n\n\nBest,\nGábor\n"},{"id":"108005","messageId":"alpine.DEB.1.00.0903141250450.10279@pacific.mpi-cbg.de","threadId":"18305","inReplyTo":"20090313172002.GA16232@neumann","subject":"Re: [PATCH] test-lib: write test results to test-results/-","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-03-14T11:53:06Z","receivedAt":"2009-03-14T11:53:06Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 13 Mar 2009, SZEDER Gábor wrote:\n\n> diff --git a/t/Makefile b/t/Makefile\n> index 0d65ced..2e6e205 100644\n> --- a/t/Makefile\n> +++ b/t/Makefile\n> @@ -14,14 +14,11 @@ SHELL_PATH_SQ = $(subst ','\\'',$(SHELL_PATH))\n> T = $(wildcard t[0-9][0-9][0-9][0-9]-*.sh)\n> TSVN = $(wildcard t91[0-9][0-9]-*.sh)\n> \n> -all: pre-clean $(T) aggregate-results clean\n> +all: $(T) aggregate-results clean\n> \n> $(T):\n> \t@echo \"*** $@ ***\"; GIT_CONFIG=.git/config '$(SHELL_PATH_SQ)' $@ $(GIT_TEST_OPTS)\n> \n> -pre-clean:\n> -\t$(RM) -r test-results\n> -\n> clean:\n> \t$(RM) -r 'trash directory' test-results\n> \n> @@ -33,5 +30,5 @@ full-svn-test:\n> \t$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C\n> \t$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8\n> \n> -.PHONY: pre-clean $(T) aggregate-results clean\n> +.PHONY: $(T) aggregate-results clean\n> .NOTPARALLEL:\n\nThis is wrong. If you have failing tests, or if you interrupt the tests, \nit will never clean the test results, and after Hannes' patch you _will_ \nhave stale files lying around all the time.\n\nI'd rather not have this change.\n\nCiao,\nDscho\n"},{"id":"108007","messageId":"20090314121617.GJ6808@neumann","threadId":"18305","inReplyTo":"alpine.DEB.1.00.0903141250450.10279@pacific.mpi-cbg.de","subject":"Re: [PATCH] test-lib: write test results to test-results/-","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2009-03-14T12:16:17Z","receivedAt":"2009-03-14T12:16:17Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"Hi,\n\nOn Sat, Mar 14, 2009 at 12:53:06PM +0100, Johannes Schindelin wrote:\n> Hi,\n> \n> On Fri, 13 Mar 2009, SZEDER Gábor wrote:\n> \n> > diff --git a/t/Makefile b/t/Makefile\n> > index 0d65ced..2e6e205 100644\n> > --- a/t/Makefile\n> > +++ b/t/Makefile\n> > @@ -14,14 +14,11 @@ SHELL_PATH_SQ = $(subst ','\\'',$(SHELL_PATH))\n> > T = $(wildcard t[0-9][0-9][0-9][0-9]-*.sh)\n> > TSVN = $(wildcard t91[0-9][0-9]-*.sh)\n> > \n> > -all: pre-clean $(T) aggregate-results clean\n> > +all: $(T) aggregate-results clean\n\nWell, this part is wrong, or at least not up-to-date. I just digged\nup an ancient branch in my tree and sent out the diff, without\nrealizing that there were some conflicting changes since then.\n\n> > \n> > $(T):\n> > \t@echo \"*** $@ ***\"; GIT_CONFIG=.git/config '$(SHELL_PATH_SQ)' $@ $(GIT_TEST_OPTS)\n> > \n> > -pre-clean:\n> > -\t$(RM) -r test-results\n> > -\n> > clean:\n> > \t$(RM) -r 'trash directory' test-results\n> > \n> > @@ -33,5 +30,5 @@ full-svn-test:\n> > \t$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C\n> > \t$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8\n> > \n> > -.PHONY: pre-clean $(T) aggregate-results clean\n> > +.PHONY: $(T) aggregate-results clean\n> > .NOTPARALLEL:\n> \n> This is wrong. If you have failing tests, or if you interrupt the tests, \n> it will never clean the test results, and after Hannes' patch you _will_ \n> have stale files lying around all the time.\n\nIf you have failing tests, or if you interrupt the tests, then you\nwill have stale files lying around _anyway_: not only test results\nare left there, but also trash directories. To remove the trash\ndirectories, you'll need to run 'make clean' (in t/), but that will\nremove the test results, too, so there is no difference. But even if\nyou don't run 'make clean' before running the test suite again, test\nresults cruft from the previous run doesn't matter, because they will\nbe overwritten.\n\n\nBest,\nGábor\n"},{"id":"108008","messageId":"alpine.DEB.1.00.0903141321550.10279@pacific.mpi-cbg.de","threadId":"18305","inReplyTo":"20090314121617.GJ6808@neumann","subject":"Re: [PATCH] test-lib: write test results to test-results/-","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-03-14T12:22:59Z","receivedAt":"2009-03-14T12:22:59Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 14 Mar 2009, SZEDER Gábor wrote:\n\n> If you have failing tests, or if you interrupt the tests, then you\n> will have stale files lying around _anyway_: not only test results\n> are left there, but also trash directories.\n\nThe 'pre-clean' target actually cleans test-results/, and test-lib.sh make \nsure that the trash directory is removed and recreated.\n\nCiao,\nDscho\n"},{"id":"108009","messageId":"20090314122833.GK6808@neumann","threadId":"18305","inReplyTo":"alpine.DEB.1.00.0903141321550.10279@pacific.mpi-cbg.de","subject":"Re: [PATCH] test-lib: write test results to test-results/-","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2009-03-14T12:28:33Z","receivedAt":"2009-03-14T12:28:33Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"On Sat, Mar 14, 2009 at 01:22:59PM +0100, Johannes Schindelin wrote:\n> On Sat, 14 Mar 2009, SZEDER Gábor wrote:\n> \n> > If you have failing tests, or if you interrupt the tests, then you\n> > will have stale files lying around _anyway_: not only test results\n> > are left there, but also trash directories.\n> \n> The 'pre-clean' target actually cleans test-results/, and test-lib.sh make \n> sure that the trash directory is removed and recreated.\n\nWith my proposed change there would be no need to clean 'test-results'\nbefore running the tests, because test-lib.sh would take care of that\n(not by removing and recreating 'test-results/', but by overwriting\n(IOW: removing and recreating, but in one step) individual test result\nfiles).\n\n\nBest,\nGábor\n"},{"id":"108011","messageId":"fabb9a1e0903140616q3770f89axff84755abb1f47c7@mail.gmail.com","threadId":"18305","inReplyTo":"20090314122833.GK6808@neumann","subject":"Re: [PATCH] test-lib: write test results to test-results/-","fromName":"Sverre Rabbelier","fromEmail":"srabbelier@gmail.com","sentAt":"2009-03-14T13:16:57Z","receivedAt":"2009-03-14T13:16:57Z","isPatch":true,"sender":{"key":"srabbelier@gmail.com","avatar":"https://avatars.githubusercontent.com/u/3098?v=4"},"body":"Heya,\n\nOn Sat, Mar 14, 2009 at 13:28, SZEDER Gábor wrote:\n> With my proposed change there would be no need to clean 'test-results'\n> before running the tests, because test-lib.sh would take care of that\n> (not by removing and recreating 'test-results/', but by overwriting\n> (IOW: removing and recreating, but in one step) individual test result\n> files).\n\nWouldn't that result in possible stale files being counted in the\nresult (e.g., if those tests were not run this time, but they were run\npreviously)?\n\n-- \nCheers,\n\nSverre Rabbelier\n"},{"id":"108012","messageId":"20090314135904.GL6808@neumann","threadId":"18305","inReplyTo":"fabb9a1e0903140616q3770f89axff84755abb1f47c7@mail.gmail.com","subject":"Re: [PATCH] test-lib: write test results to test-results/-","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2009-03-14T13:59:04Z","receivedAt":"2009-03-14T13:59:04Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"Hi,\n\nOn Sat, Mar 14, 2009 at 02:16:57PM +0100, Sverre Rabbelier wrote:\n> On Sat, Mar 14, 2009 at 13:28, SZEDER Gábor wrote:\n> > With my proposed change there would be no need to clean 'test-results'\n> > before running the tests, because test-lib.sh would take care of that\n> > (not by removing and recreating 'test-results/', but by overwriting\n> > (IOW: removing and recreating, but in one step) individual test result\n> > files).\n> \n> Wouldn't that result in possible stale files being counted in the\n> result (e.g., if those tests were not run this time, but they were run\n> previously)?\n\nIt depends.\n\nIf you run only a few tests, then you do it with a command like 'make\nt1234-foo.sh t5678-bar.sh'.\n\nCurrently this doesn't run the 'pre-clean' target, therefore if you\nrun different tests (e.g. 'make t1234-foo.sh ; make t5678-bar.sh'),\nthen a 'make aggregate-results' will include the result of both of\nthose tests. The same happens with my proposal, too, because the test\nof the last run will not overwrite the results of the test in the\nfirst run.\n\nNow suppose that you want to run the same set of tests twice (or more;\ne.g. 'make t1234-foo.sh ; make t1234-foo.sh ; make\naggregate-results'). Since currently the pid of the test is included\nin the test result file name, there will be two files (t1234-\nand t1234-) created under 'test-results/', and _both_ will be\ncounted by 'aggregate-results'. In this case my proposal is better,\nbecause the last round will overwrite the result of the previous runs,\ntherefore no stale files will be counted.\n\n\nBest,\nGábor\n"},{"id":"108072","messageId":"alpine.DEB.1.00.0903161115520.5741@eeepc-johanness","threadId":"18305","inReplyTo":"fabb9a1e0903140616q3770f89axff84755abb1f47c7@mail.gmail.com","subject":"Re: [PATCH] test-lib: write test results to test-results/-","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-03-16T10:18:19Z","receivedAt":"2009-03-16T10:18:19Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 14 Mar 2009, Sverre Rabbelier wrote:\n\n> On Sat, Mar 14, 2009 at 13:28, SZEDER Gábor wrote:\n> > With my proposed change there would be no need to clean 'test-results'\n> > before running the tests, because test-lib.sh would take care of that\n> > (not by removing and recreating 'test-results/', but by overwriting\n> > (IOW: removing and recreating, but in one step) individual test result\n> > files).\n> \n> Wouldn't that result in possible stale files being counted in the\n> result (e.g., if those tests were not run this time, but they were run\n> previously)?\n\nYes. Stale files would be counted in. The fact that aggregate-results.sh \nis called when running \"make\" in t/ is a sure sign for me that you should \nnot muddy waters by making unnecessary changes that break the default \nusage from time to time.\n\nSo I really, really, really, really would like that patch _not_ to be \napplied.\n\nAnd I really would like to be able to spend my time on other things than \ndiscussing this at more length than necessary.\n\nCiao,\nDscho\n"},{"id":"108076","messageId":"20090316104138.GD10963@neumann","threadId":"18305","inReplyTo":"alpine.DEB.1.00.0903161115520.5741@eeepc-johanness","subject":"Re: [PATCH] test-lib: write test results to test-results/-","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2009-03-16T10:41:38Z","receivedAt":"2009-03-16T10:41:38Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"On Mon, Mar 16, 2009 at 11:18:19AM +0100, Johannes Schindelin wrote:\n> On Sat, 14 Mar 2009, Sverre Rabbelier wrote:\n> \n> > On Sat, Mar 14, 2009 at 13:28, SZEDER Gábor wrote:\n> > > With my proposed change there would be no need to clean 'test-results'\n> > > before running the tests, because test-lib.sh would take care of that\n> > > (not by removing and recreating 'test-results/', but by overwriting\n> > > (IOW: removing and recreating, but in one step) individual test result\n> > > files).\n> > \n> > Wouldn't that result in possible stale files being counted in the\n> > result (e.g., if those tests were not run this time, but they were run\n> > previously)?\n> \n> Yes. Stale files would be counted in. The fact that aggregate-results.sh \n> is called when running \"make\" in t/ is a sure sign for me that you should \n> not muddy waters by making unnecessary changes that break the default \n> usage from time to time.\n\nAs I explained earlier, it won't change the default usage at all, but,\nas I explained in my response to Sverre, it would actually fix a\ncurrent breakage in certain cases (i.e. make t1234-foo.sh ; make\nt1234-foo.sh ; make aggregate-results would report the correct\nnumbers).\n\n> And I really would like to be able to spend my time on other things than \n> discussing this at more length than necessary.\n\nOk, then I will also spare the effort of updating the patch.\nUnless, of course, there are others who are interested.\n\n\nThanks,\nGábor\n"}]}